diff mbox

[2/6] libxl: fix vkb XS entry and type

Message ID 1507194431-17588-3-git-send-email-al1img@gmail.com (mailing list archive)
State New, archived
Headers show

Commit Message

Oleksandr Grytsov Oct. 5, 2017, 9:07 a.m. UTC 
From: Oleksandr Grytsov <oleksandr_grytsov@epam.com>

vkb has vkbd name in XS.

Signed-off-by: Oleksandr Grytsov <oleksandr_grytsov@epam.com>
---
 tools/libxl/libxl_vkb.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Wei Liu Oct. 5, 2017, 9:32 a.m. UTC | #1 
On Thu, Oct 05, 2017 at 12:07:07PM +0300, Oleksandr Grytsov wrote:
> From: Oleksandr Grytsov <oleksandr_grytsov@epam.com>
> 
> vkb has vkbd name in XS.
> 
> Signed-off-by: Oleksandr Grytsov <oleksandr_grytsov@epam.com>

This series won't make it to 4.10 but this issue should be fixed right
away -- assuming the patch is correct.
Oleksandr Grytsov Oct. 5, 2017, 9:49 a.m. UTC | #2 
On Thu, Oct 5, 2017 at 12:32 PM, Wei Liu <wei.liu2@citrix.com> wrote:
> On Thu, Oct 05, 2017 at 12:07:07PM +0300, Oleksandr Grytsov wrote:
>> From: Oleksandr Grytsov <oleksandr_grytsov@epam.com>
>>
>> vkb has vkbd name in XS.
>>
>> Signed-off-by: Oleksandr Grytsov <oleksandr_grytsov@epam.com>
>
> This series won't make it to 4.10 but this issue should be fixed right
> away -- assuming the patch is correct.

Ok. I will send just this fix as another patchset.
Oleksandr Grytsov Oct. 5, 2017, 9:54 a.m. UTC | #3 
On Thu, Oct 5, 2017 at 12:49 PM, Oleksandr Grytsov <al1img@gmail.com> wrote:
> On Thu, Oct 5, 2017 at 12:32 PM, Wei Liu <wei.liu2@citrix.com> wrote:
>> On Thu, Oct 05, 2017 at 12:07:07PM +0300, Oleksandr Grytsov wrote:
>>> From: Oleksandr Grytsov <oleksandr_grytsov@epam.com>
>>>
>>> vkb has vkbd name in XS.
>>>
>>> Signed-off-by: Oleksandr Grytsov <oleksandr_grytsov@epam.com>
>>
>> This series won't make it to 4.10 but this issue should be fixed right
>> away -- assuming the patch is correct.
>
> Ok. I will send just this fix as another patchset.
>
>
> --
> Best Regards,
> Oleksandr Grytsov.

Actually in current implementation it is not possible to create more
than one vkb per domain.
It means this issue will not happen any case.

So, I'm ok to wait with all this patchset for next release.
Wei Liu Oct. 30, 2017, 6:05 p.m. UTC | #4 
On Thu, Oct 05, 2017 at 12:07:07PM +0300, Oleksandr Grytsov wrote:
> From: Oleksandr Grytsov <oleksandr_grytsov@epam.com>
> 
> vkb has vkbd name in XS.
> 
> Signed-off-by: Oleksandr Grytsov <oleksandr_grytsov@epam.com>

Acked-by: Wei Liu <wei.liu2@citrix.com>
diff mbox

Patch

diff --git a/tools/libxl/libxl_vkb.c b/tools/libxl/libxl_vkb.c
index 0d01262..ea6fca8 100644
--- a/tools/libxl/libxl_vkb.c
+++ b/tools/libxl/libxl_vkb.c
@@ -51,7 +51,7 @@  out:
     return AO_INPROGRESS;
 }
 
-static LIBXL_DEFINE_UPDATE_DEVID(vkb, "vkb")
+static LIBXL_DEFINE_UPDATE_DEVID(vkb, "vkbd")
 
 #define libxl__add_vkbs NULL
 #define libxl_device_vkb_list NULL
@@ -59,7 +59,7 @@  static LIBXL_DEFINE_UPDATE_DEVID(vkb, "vkb")
 
 LIBXL_DEFINE_DEVICE_REMOVE(vkb)
 
-DEFINE_DEVICE_TYPE_STRUCT(vkb,
+DEFINE_DEVICE_TYPE_STRUCT_X(vkb, vkb, vkbd
     .skip_attach = 1
 );