Compiling error of backport-4.12.c

Commit Message

Johannes Berg Oct. 30, 2017, 8:03 p.m. UTC

On Thu, 2017-10-26 at 10:06 +0200, Johannes Berg wrote:
> On Thu, 2017-10-26 at 09:29 +0200, Johannes Berg wrote:
> > On Thu, 2017-10-26 at 11:52 +0800, 吳重毅 wrote:
> > > Thankd for fixing, i am able compile now.
> > 
> > Ok, great.
> > 
> > > But when i load the modules and firmware.bin, it crash.
> > 
> > Crap, sorry about that. I'll see what I can do about it right now.
> 
> Ok, I see the bug. Not sure yet how to fix, but yeah.

I thought I said I'd fixed it, but don't see that email.

Anyway, I did, but Luca found another bug ... where it compiles, this
fixes it, I think:


But on older kernels this doesn't compile, and needs more work.

johannes
--
To unsubscribe from this list: send the line "unsubscribe backports" in

Comments

Luca Coelho Oct. 31, 2017, 11:58 a.m. UTC | #1

On Mon, 2017-10-30 at 21:03 +0100, Johannes Berg wrote:
> On Thu, 2017-10-26 at 10:06 +0200, Johannes Berg wrote:
> > On Thu, 2017-10-26 at 09:29 +0200, Johannes Berg wrote:
> > > On Thu, 2017-10-26 at 11:52 +0800, 吳重毅 wrote:
> > > > Thankd for fixing, i am able compile now.
> > > 
> > > Ok, great.
> > > 
> > > > But when i load the modules and firmware.bin, it crash.
> > > 
> > > Crap, sorry about that. I'll see what I can do about it right
> > > now.
> > 
> > Ok, I see the bug. Not sure yet how to fix, but yeah.
> 
> I thought I said I'd fixed it, but don't see that email.
> 
> Anyway, I did, but Luca found another bug ... where it compiles, this
> fixes it, I think:
> 
> --- a/compat/backport-4.12.c
> +++ b/compat/backport-4.12.c
> @@ -225,6 +225,7 @@ int bp_extack_genl_register_family(struct
> genl_family *family)
>  
>  	/* copy this since the family might access it directly */
>  	family->attrbuf = copy->family.attrbuf;
> +	family->mcgrp_offset = copy->family.mcgrp_offset;
>  
>  	mutex_lock(&copies_mutex);
>  	list_add_tail(&copy->list, &copies_list);
> 
> But on older kernels this doesn't compile, and needs more work.

FWIW, this fixes the problem I was having with nl80211 commands that
were never completing.  I tried it in kernel v4.7.

--
Cheers,
Luca.
--
To unsubscribe from this list: send the line "unsubscribe backports" in

Patch

--- a/compat/backport-4.12.c
+++ b/compat/backport-4.12.c
@@ -225,6 +225,7 @@  int bp_extack_genl_register_family(struct genl_family *family)
 
 	/* copy this since the family might access it directly */
 	family->attrbuf = copy->family.attrbuf;
+	family->mcgrp_offset = copy->family.mcgrp_offset;
 
 	mutex_lock(&copies_mutex);
 	list_add_tail(&copy->list, &copies_list);