diff mbox

[1/3] arm: dts: omap3-igep: Update OneNAND node

Message ID 20171103144706.ydj7wavkfmp2iaoe@lenoch (mailing list archive)
State New, archived
Headers show

Commit Message

Ladislav Michl Nov. 3, 2017, 2:47 p.m. UTC
Update node timings to be compatible with actual chip used
(gpmc_cs_show_timings utilized to dump values)
Also specify correct compatible property for upcoming MTD driver
DTfication.

Signed-off-by: Ladislav Michl <ladis@linux-mips.org>
---
 arch/arm/boot/dts/omap3-igep.dtsi | 32 ++++++++++++++++----------------
 1 file changed, 16 insertions(+), 16 deletions(-)

Comments

Tony Lindgren Nov. 3, 2017, 5:40 p.m. UTC | #1
* Ladislav Michl <ladis@linux-mips.org> [171103 14:48]:
> Update node timings to be compatible with actual chip used
> (gpmc_cs_show_timings utilized to dump values)
> Also specify correct compatible property for upcoming MTD driver
> DTfication.

Do other onenand dts files also need patching for this series?

Regards,

Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Ladislav Michl Nov. 3, 2017, 7:06 p.m. UTC | #2
On Fri, Nov 03, 2017 at 10:40:21AM -0700, Tony Lindgren wrote:
> * Ladislav Michl <ladis@linux-mips.org> [171103 14:48]:
> > Update node timings to be compatible with actual chip used
> > (gpmc_cs_show_timings utilized to dump values)
> > Also specify correct compatible property for upcoming MTD driver
> > DTfication.
> 
> Do other onenand dts files also need patching for this series?

IMHO no and this one does not need patching too, patched driver is working
just fine as no DT blob is enabling DMA and I didn't hit situation where
gpio quirk is needed.

I did this just to show others how correct node should look like.

Someone should verify Nokias anyway ;-)

> Regards,
> 
> Tony

Reards,
	ladis
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/arch/arm/boot/dts/omap3-igep.dtsi b/arch/arm/boot/dts/omap3-igep.dtsi
index 4ad7d5565906..47ddb022ce7b 100644
--- a/arch/arm/boot/dts/omap3-igep.dtsi
+++ b/arch/arm/boot/dts/omap3-igep.dtsi
@@ -141,38 +141,38 @@ 
 	};
 
 	onenand@0,0 {
-		compatible = "ti,omap2-onenand";
+		compatible = "ti,omap3-onenand";
 		reg = <0 0 0x20000>;	/* CS0, offset 0, IO size 128K */
 
 		gpmc,sync-read;
 		gpmc,sync-write;
 		gpmc,burst-length = <16>;
-		gpmc,burst-read;
 		gpmc,burst-wrap;
+		gpmc,burst-read;
 		gpmc,burst-write;
 		gpmc,device-width = <2>; /* GPMC_DEVWIDTH_16BIT */
 		gpmc,mux-add-data = <2>; /* GPMC_MUX_AD */
 		gpmc,cs-on-ns = <0>;
-		gpmc,cs-rd-off-ns = <87>;
-		gpmc,cs-wr-off-ns = <87>;
+		gpmc,cs-rd-off-ns = <96>;
+		gpmc,cs-wr-off-ns = <96>;
 		gpmc,adv-on-ns = <0>;
-		gpmc,adv-rd-off-ns = <10>;
-		gpmc,adv-wr-off-ns = <10>;
-		gpmc,oe-on-ns = <15>;
-		gpmc,oe-off-ns = <87>;
+		gpmc,adv-rd-off-ns = <12>;
+		gpmc,adv-wr-off-ns = <12>;
+		gpmc,oe-on-ns = <18>;
+		gpmc,oe-off-ns = <96>;
 		gpmc,we-on-ns = <0>;
-		gpmc,we-off-ns = <87>;
-		gpmc,rd-cycle-ns = <112>;
-		gpmc,wr-cycle-ns = <112>;
-		gpmc,access-ns = <81>;
-		gpmc,page-burst-access-ns = <15>;
+		gpmc,we-off-ns = <96>;
+		gpmc,rd-cycle-ns = <114>;
+		gpmc,wr-cycle-ns = <114>;
+		gpmc,access-ns = <90>;
+		gpmc,page-burst-access-ns = <12>;
 		gpmc,bus-turnaround-ns = <0>;
 		gpmc,cycle2cycle-delay-ns = <0>;
 		gpmc,wait-monitoring-ns = <0>;
-		gpmc,clk-activation-ns = <5>;
+		gpmc,clk-activation-ns = <6>;
 		gpmc,wr-data-mux-bus-ns = <30>;
-		gpmc,wr-access-ns = <81>;
-		gpmc,sync-clk-ps = <15000>;
+		gpmc,wr-access-ns = <90>;
+		gpmc,sync-clk-ps = <12000>;
 
 		#address-cells = <1>;
 		#size-cells = <1>;