| Message ID | 20171105165134.5199-1-mylene.josserand@free-electrons.com (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Headers | show |
On Sun, Nov 05, 2017 at 05:51:34PM +0100, Mylène Josserand wrote: > i2c1 and i2c2 bits for CCU are not bit 0 but bit 1 and bit 2. > Because of that, the i2c0 (bit 0) was not correctly configured. > Fixed the correct bits for i2c1 and i2c2. > > Fixes: 05359be1176b ("clk: sunxi-ng: Add driver for A83T CCU") > > Signed-off-by: Mylène Josserand <mylene.josserand@free-electrons.com> Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com> Stephen, can you merge it directly? It's not super urgent since we don't have i2c enabled for that SoC yet, so it can definitely be in 4.15. Thanks! Maxime
On 11/05, Mylène Josserand wrote: > i2c1 and i2c2 bits for CCU are not bit 0 but bit 1 and bit 2. > Because of that, the i2c0 (bit 0) was not correctly configured. > Fixed the correct bits for i2c1 and i2c2. > > Fixes: 05359be1176b ("clk: sunxi-ng: Add driver for A83T CCU") > > Signed-off-by: Mylène Josserand <mylene.josserand@free-electrons.com> > --- Applied to clk-next
diff --git a/drivers/clk/sunxi-ng/ccu-sun8i-a83t.c b/drivers/clk/sunxi-ng/ccu-sun8i-a83t.c index e43acebdfbcd..f8203115a6bc 100644 --- a/drivers/clk/sunxi-ng/ccu-sun8i-a83t.c +++ b/drivers/clk/sunxi-ng/ccu-sun8i-a83t.c @@ -354,9 +354,9 @@ static SUNXI_CCU_GATE(bus_tdm_clk, "bus-tdm", "apb1", static SUNXI_CCU_GATE(bus_i2c0_clk, "bus-i2c0", "apb2", 0x06c, BIT(0), 0); static SUNXI_CCU_GATE(bus_i2c1_clk, "bus-i2c1", "apb2", - 0x06c, BIT(0), 0); + 0x06c, BIT(1), 0); static SUNXI_CCU_GATE(bus_i2c2_clk, "bus-i2c2", "apb2", - 0x06c, BIT(0), 0); + 0x06c, BIT(2), 0); static SUNXI_CCU_GATE(bus_uart0_clk, "bus-uart0", "apb2", 0x06c, BIT(16), 0); static SUNXI_CCU_GATE(bus_uart1_clk, "bus-uart1", "apb2",
i2c1 and i2c2 bits for CCU are not bit 0 but bit 1 and bit 2. Because of that, the i2c0 (bit 0) was not correctly configured. Fixed the correct bits for i2c1 and i2c2. Fixes: 05359be1176b ("clk: sunxi-ng: Add driver for A83T CCU") Signed-off-by: Mylène Josserand <mylene.josserand@free-electrons.com> --- drivers/clk/sunxi-ng/ccu-sun8i-a83t.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)