| Message ID | 1509528141-4189-3-git-send-email-tina.zhang@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Tina, Please send this patch alone (or in the beginning of your series), so it can be merged already. That'll save you the effort of carrying this patch. Regards, Joonas On Wed, 2017-11-01 at 17:22 +0800, Tina Zhang wrote: > -ENXIO should be returned when operations are banned from changing > backing storage of objects without backing storage. > > v2: > - update the patch description and subject to just mention objects w/o > backing storage, instead of "GEM proxy". (Joonas) > > Signed-off-by: Tina Zhang <tina.zhang@intel.com> > Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk> > Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com> > --- > drivers/gpu/drm/i915/i915_gem.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c > index 13bc18d..e85721c 100644 > --- a/drivers/gpu/drm/i915/i915_gem.c > +++ b/drivers/gpu/drm/i915/i915_gem.c > @@ -1713,7 +1713,7 @@ i915_gem_mmap_ioctl(struct drm_device *dev, void *data, > */ > if (!obj->base.filp) { > i915_gem_object_put(obj); > - return -EINVAL; > + return -ENXIO; > } > > addr = vm_mmap(obj->base.filp, 0, args->size,
> -----Original Message----- > From: Joonas Lahtinen [mailto:joonas.lahtinen@linux.intel.com] > Sent: Monday, November 6, 2017 6:57 PM > To: Zhang, Tina <tina.zhang@intel.com>; zhenyuw@linux.intel.com; Wang, Zhi > A <zhi.a.wang@intel.com>; daniel@ffwll.ch; chris@chris-wilson.co.uk > Cc: intel-gfx@lists.freedesktop.org; intel-gvt-dev@lists.freedesktop.org > Subject: Re: [PATCH v2 2/2] drm/i915: Object w/o backing stroage is banned by > -ENXIO > > Hi Tina, > > Please send this patch alone (or in the beginning of your series), so it can be > merged already. > > That'll save you the effort of carrying this patch. Thank you very much :) BR, Tina > > Regards, Joonas > > On Wed, 2017-11-01 at 17:22 +0800, Tina Zhang wrote: > > -ENXIO should be returned when operations are banned from changing > > backing storage of objects without backing storage. > > > > v2: > > - update the patch description and subject to just mention objects w/o > > backing storage, instead of "GEM proxy". (Joonas) > > > > Signed-off-by: Tina Zhang <tina.zhang@intel.com> > > Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk> > > Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com> > > --- > > drivers/gpu/drm/i915/i915_gem.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/i915/i915_gem.c > > b/drivers/gpu/drm/i915/i915_gem.c index 13bc18d..e85721c 100644 > > --- a/drivers/gpu/drm/i915/i915_gem.c > > +++ b/drivers/gpu/drm/i915/i915_gem.c > > @@ -1713,7 +1713,7 @@ i915_gem_mmap_ioctl(struct drm_device *dev, > void *data, > > */ > > if (!obj->base.filp) { > > i915_gem_object_put(obj); > > - return -EINVAL; > > + return -ENXIO; > > } > > > > addr = vm_mmap(obj->base.filp, 0, args->size, > -- > Joonas Lahtinen > Open Source Technology Center > Intel Corporation
diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c index 13bc18d..e85721c 100644 --- a/drivers/gpu/drm/i915/i915_gem.c +++ b/drivers/gpu/drm/i915/i915_gem.c @@ -1713,7 +1713,7 @@ i915_gem_mmap_ioctl(struct drm_device *dev, void *data, */ if (!obj->base.filp) { i915_gem_object_put(obj); - return -EINVAL; + return -ENXIO; } addr = vm_mmap(obj->base.filp, 0, args->size,