| Message ID | 20171108172404.19118-2-alexander.deucher@amd.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Wed, Nov 08, 2017 at 12:24:02PM -0500, Alex Deucher wrote: > From: Akshu Agrawal <akshu.agrawal@amd.com> > > This fixes the issue of driver not getting auto loaded with > MODULE_ALIAS. Please don't resubmit patches that have already been applied, you should submit patches against current code in the tree you're expecting things to be applied to. If any updates are needed to a patch that's already been applied you should submit incremental patches which make those updates. This avoids having to change published git commits which could cause problems for people working against git.
> -----Original Message----- > From: Mark Brown [mailto:broonie@kernel.org] > Sent: Wednesday, November 08, 2017 1:09 PM > To: Alex Deucher > Cc: amd-gfx@lists.freedesktop.org; alsa-devel@alsa-project.org; dri- > devel@lists.freedesktop.org; Mukunda, Vijendar; lgirdwood@gmail.com; > tiwai@suse.de; Agrawal, Akshu; Deucher, Alexander > Subject: Re: [PATCH 1/3] ASoC: AMD: Make the driver name consistent > across files > > On Wed, Nov 08, 2017 at 12:24:02PM -0500, Alex Deucher wrote: > > From: Akshu Agrawal <akshu.agrawal@amd.com> > > > > This fixes the issue of driver not getting auto loaded with > > MODULE_ALIAS. > > Please don't resubmit patches that have already been applied, you should > submit patches against current code in the tree you're expecting things > to be applied to. If any updates are needed to a patch that's already > been applied you should submit incremental patches which make those > updates. This avoids having to change published git commits which could > cause problems for people working against git. This didn't not appear to be in your tree yet and I never got any confirmation it being applied. Apologies. Alex
On Wed, Nov 08, 2017 at 06:12:34PM +0000, Deucher, Alexander wrote: > This didn't not appear to be in your tree yet and I never got any confirmation it being > applied. Apologies. Ah, sorry - my bad. This was one that I tried to apply but which didn't apply.
diff --git a/sound/soc/amd/Makefile b/sound/soc/amd/Makefile index eed64ff6c73e..f07fd2e2870a 100644 --- a/sound/soc/amd/Makefile +++ b/sound/soc/amd/Makefile @@ -1,5 +1,5 @@ -snd-soc-acp-pcm-objs := acp-pcm-dma.o +acp_audio_dma-objs := acp-pcm-dma.o snd-soc-acp-rt5645-mach-objs := acp-rt5645.o -obj-$(CONFIG_SND_SOC_AMD_ACP) += snd-soc-acp-pcm.o +obj-$(CONFIG_SND_SOC_AMD_ACP) += acp_audio_dma.o obj-$(CONFIG_SND_SOC_AMD_CZ_RT5645_MACH) += snd-soc-acp-rt5645-mach.o diff --git a/sound/soc/amd/acp-pcm-dma.c b/sound/soc/amd/acp-pcm-dma.c index e19f281afeaa..13d040a4d26f 100644 --- a/sound/soc/amd/acp-pcm-dma.c +++ b/sound/soc/amd/acp-pcm-dma.c @@ -40,6 +40,8 @@ #define ST_MAX_BUFFER (ST_PLAYBACK_MAX_PERIOD_SIZE * PLAYBACK_MAX_NUM_PERIODS) #define ST_MIN_BUFFER ST_MAX_BUFFER +#define DRV_NAME "acp_audio_dma" + static const struct snd_pcm_hardware acp_pcm_hardware_playback = { .info = SNDRV_PCM_INFO_INTERLEAVED | SNDRV_PCM_INFO_BLOCK_TRANSFER | SNDRV_PCM_INFO_MMAP | @@ -1189,7 +1191,7 @@ static struct platform_driver acp_dma_driver = { .probe = acp_audio_probe, .remove = acp_audio_remove, .driver = { - .name = "acp_audio_dma", + .name = DRV_NAME, .pm = &acp_pm_ops, }, }; @@ -1200,4 +1202,4 @@ MODULE_AUTHOR("Vijendar.Mukunda@amd.com"); MODULE_AUTHOR("Maruthi.Bayyavarapu@amd.com"); MODULE_DESCRIPTION("AMD ACP PCM Driver"); MODULE_LICENSE("GPL v2"); -MODULE_ALIAS("platform:acp-dma-audio"); +MODULE_ALIAS("platform:"DRV_NAME);