| Message ID | 1509983985-20950-2-git-send-email-benjamin.gaignard@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 11/06/2017 07:59 AM, Benjamin Gaignard wrote: > Put include in alphabetic order > Acked-by: Laura Abbott <labbott@redhat.com> > Signed-off-by: Benjamin Gaignard <benjamin.gaignard@linaro.org> > --- > drivers/staging/android/ion/ion.c | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git a/drivers/staging/android/ion/ion.c b/drivers/staging/android/ion/ion.c > index a7d9b0e..fda9756 100644 > --- a/drivers/staging/android/ion/ion.c > +++ b/drivers/staging/android/ion/ion.c > @@ -15,28 +15,28 @@ > * > */ > > +#include <linux/anon_inodes.h> > +#include <linux/debugfs.h> > #include <linux/device.h> > +#include <linux/dma-buf.h> > #include <linux/err.h> > +#include <linux/export.h> > #include <linux/file.h> > #include <linux/freezer.h> > #include <linux/fs.h> > -#include <linux/anon_inodes.h> > +#include <linux/idr.h> > #include <linux/kthread.h> > #include <linux/list.h> > #include <linux/memblock.h> > #include <linux/miscdevice.h> > -#include <linux/export.h> > #include <linux/mm.h> > #include <linux/mm_types.h> > #include <linux/rbtree.h> > -#include <linux/slab.h> > +#include <linux/sched/task.h> > #include <linux/seq_file.h> > +#include <linux/slab.h> > #include <linux/uaccess.h> > #include <linux/vmalloc.h> > -#include <linux/debugfs.h> > -#include <linux/dma-buf.h> > -#include <linux/idr.h> > -#include <linux/sched/task.h> > > #include "ion.h" > >
On Mon, Nov 06, 2017 at 04:59:44PM +0100, Benjamin Gaignard wrote:
> Put include in alphabetic order
Why???
That should not matter at all.
I'll take this, but really, ick ick ick ick ick.
2017-11-28 14:20 GMT+01:00 Greg KH <gregkh@linuxfoundation.org>: > On Mon, Nov 06, 2017 at 04:59:44PM +0100, Benjamin Gaignard wrote: >> Put include in alphabetic order > > Why??? Mainly because the next patch in the series adds new includes and I have decide to split clean-up and new feature patches > > That should not matter at all. > > I'll take this, but really, ick ick ick ick ick. >
On Tue, Nov 28, 2017 at 02:34:00PM +0100, Benjamin Gaignard wrote: > 2017-11-28 14:20 GMT+01:00 Greg KH <gregkh@linuxfoundation.org>: > > On Mon, Nov 06, 2017 at 04:59:44PM +0100, Benjamin Gaignard wrote: > >> Put include in alphabetic order > > > > Why??? > > Mainly because the next patch in the series adds new includes and I have > decide to split clean-up and new feature patches That's fine, but this really isn't needed for any type of "clean-up" at all. But oh well, if you all like it that way, I'm not going to complain that much :) greg k-h
diff --git a/drivers/staging/android/ion/ion.c b/drivers/staging/android/ion/ion.c index a7d9b0e..fda9756 100644 --- a/drivers/staging/android/ion/ion.c +++ b/drivers/staging/android/ion/ion.c @@ -15,28 +15,28 @@ * */ +#include <linux/anon_inodes.h> +#include <linux/debugfs.h> #include <linux/device.h> +#include <linux/dma-buf.h> #include <linux/err.h> +#include <linux/export.h> #include <linux/file.h> #include <linux/freezer.h> #include <linux/fs.h> -#include <linux/anon_inodes.h> +#include <linux/idr.h> #include <linux/kthread.h> #include <linux/list.h> #include <linux/memblock.h> #include <linux/miscdevice.h> -#include <linux/export.h> #include <linux/mm.h> #include <linux/mm_types.h> #include <linux/rbtree.h> -#include <linux/slab.h> +#include <linux/sched/task.h> #include <linux/seq_file.h> +#include <linux/slab.h> #include <linux/uaccess.h> #include <linux/vmalloc.h> -#include <linux/debugfs.h> -#include <linux/dma-buf.h> -#include <linux/idr.h> -#include <linux/sched/task.h> #include "ion.h"
Put include in alphabetic order Signed-off-by: Benjamin Gaignard <benjamin.gaignard@linaro.org> --- drivers/staging/android/ion/ion.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-)