diff mbox

[1/1] add rgb888 pins to a20 to enable parallel rgb LCD

Message ID 1510058999-6778-1-git-send-email-giulio.benetti@micronovasrl.com (mailing list archive)
State Rejected, archived
Headers show

Commit Message

Giulio Benetti Nov. 7, 2017, 12:49 p.m. UTC
On sun7i-a20-* there's no way to enable PA00--PA27 as RGB888 LCD0 pins.

Add lcd_rgb888_pins in sun7i-a20.dtsi.

It can be used on sun7i-a20-olinuxino-lime.dts.
This patch gives possibility to set parallel lcd pins for RGB888.
To be used with tcon0 in your <target>.dts

Best regards
Giulio Benetti
Micronova srl

Signed-off-by: Giulio Benetti <giulio.benetti@micronovasrl.com>
---
 arch/arm/boot/dts/sun7i-a20.dtsi | 8 ++++++++
 1 file changed, 8 insertions(+)

Comments

Maxime Ripard Nov. 7, 2017, 1:03 p.m. UTC | #1
On Tue, Nov 07, 2017 at 01:49:59PM +0100, Giulio Benetti wrote:
> On sun7i-a20-* there's no way to enable PA00--PA27 as RGB888 LCD0 pins.
> 
> Add lcd_rgb888_pins in sun7i-a20.dtsi.
> 
> It can be used on sun7i-a20-olinuxino-lime.dts.
> This patch gives possibility to set parallel lcd pins for RGB888.
> To be used with tcon0 in your <target>.dts

My question was on which board do you want to use it right now. If the
answer is none, then we won't merge that patch, we have too many
pinctrl already to not add the unused ones.

Maxime
Giulio Benetti Nov. 7, 2017, 4:38 p.m. UTC | #2
Board could be any with A20,
for example Olinuxino A20.
Or our Q027, S027 boards, but final dts still are not complete.
Maxime Ripard Nov. 8, 2017, 10:56 a.m. UTC | #3
Hi,

On Tue, Nov 07, 2017 at 05:38:55PM +0100, Giulio Benetti wrote:
> Board could be any with A20,
> for example Olinuxino A20.
> Or our Q027, S027 boards, but final dts still are not complete.

Therefore no upstream boards are using it right now, so we'll merge it
when that will be the case.

Maxime
Icenowy Zheng Nov. 10, 2017, 1:05 a.m. UTC | #4
在 2017-11-08 18:56,Maxime Ripard 写道:
> Hi,
> 
> On Tue, Nov 07, 2017 at 05:38:55PM +0100, Giulio Benetti wrote:
>> Board could be any with A20,
>> for example Olinuxino A20.
>> Or our Q027, S027 boards, but final dts still are not complete.
> 
> Therefore no upstream boards are using it right now, so we'll merge it
> when that will be the case.

I think the LCD connector on Banana Pi's uses parallel interface,
although the LCD should be an external DT overlay.

> 
> Maxime
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
diff mbox

Patch

diff --git a/arch/arm/boot/dts/sun7i-a20.dtsi b/arch/arm/boot/dts/sun7i-a20.dtsi
index 228c368..b85a917 100644
--- a/arch/arm/boot/dts/sun7i-a20.dtsi
+++ b/arch/arm/boot/dts/sun7i-a20.dtsi
@@ -921,6 +921,14 @@ 
 				pins = "PI20", "PI21";
 				function = "uart7";
 			};
+
+			lcd_rgb888_pins: lcd-rgb888 {
+				pins = "PD0", "PD1", "PD2", "PD3", "PD4", "PD5", "PD6", "PD7", 
+					"PD8", "PD9", "PD10", "PD11", "PD12", "PD13", "PD14", "PD15",
+					"PD16", "PD17", "PD18", "PD19", "PD20", "PD21", "PD22", "PD23",
+					"PD24", "PD25", "PD26", "PD27";
+				function = "lcd0";
+			};
 		};
 
 		timer@1c20c00 {