diff mbox

[2/3] arm64: dts: r8a7795: add DMA for SCIF2

Message ID 1510759510-30295-3-git-send-email-ulrich.hecht+renesas@gmail.com (mailing list archive)
State Superseded
Delegated to: Simon Horman
Headers show

Commit Message

Ulrich Hecht Nov. 15, 2017, 3:25 p.m. UTC
Tested on Draak.

Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@gmail.com>
---
 arch/arm64/boot/dts/renesas/r8a77995.dtsi | 2 ++
 1 file changed, 2 insertions(+)

Comments

Geert Uytterhoeven Nov. 16, 2017, 8:43 a.m. UTC | #1
Hi Ulrich,

On Wed, Nov 15, 2017 at 4:25 PM, Ulrich Hecht
<ulrich.hecht+renesas@gmail.com> wrote:
> Tested on Draak.
>
> Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@gmail.com>

Thanks for your patch!

> --- a/arch/arm64/boot/dts/renesas/r8a77995.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a77995.dtsi
> @@ -393,6 +393,8 @@
>                                  <&cpg CPG_CORE R8A77995_CLK_S3D1C>,
>                                  <&scif_clk>;
>                         clock-names = "fck", "brg_int", "scif_clk";
> +                       dmas = <&dmac1 0x13>, <&dmac1 0x12>;
> +                       dma-names = "tx", "rx";

I guess SCIF2 can work with both dmac1 and dmac2?

>                         power-domains = <&sysc R8A77995_PD_ALWAYS_ON>;
>                         resets = <&cpg 310>;
>                         status = "disabled";

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
Chris Paterson Nov. 16, 2017, 9:07 a.m. UTC | #2
Hello Ulrich,

> From: linux-renesas-soc-owner@vger.kernel.org [mailto:linux-renesas-soc-
> owner@vger.kernel.org] On Behalf Of Ulrich Hecht
> Sent: 15 November 2017 15:25
> 
> Tested on Draak.

I guess you meant for the patch title to use r8a77995?

Kind regards, Chris


> 
> Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@gmail.com>
> ---
>  arch/arm64/boot/dts/renesas/r8a77995.dtsi | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/renesas/r8a77995.dtsi
> b/arch/arm64/boot/dts/renesas/r8a77995.dtsi
> index 04a392a..5fa7572 100644
> --- a/arch/arm64/boot/dts/renesas/r8a77995.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a77995.dtsi
> @@ -393,6 +393,8 @@
>  				 <&cpg CPG_CORE R8A77995_CLK_S3D1C>,
>  				 <&scif_clk>;
>  			clock-names = "fck", "brg_int", "scif_clk";
> +			dmas = <&dmac1 0x13>, <&dmac1 0x12>;
> +			dma-names = "tx", "rx";
>  			power-domains = <&sysc
> R8A77995_PD_ALWAYS_ON>;
>  			resets = <&cpg 310>;
>  			status = "disabled";
> --
> 2.7.4
Simon Horman Nov. 17, 2017, 2:26 p.m. UTC | #3
On Wed, Nov 15, 2017 at 04:25:09PM +0100, Ulrich Hecht wrote:
> Tested on Draak.
> 
> Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@gmail.com>
> ---
>  arch/arm64/boot/dts/renesas/r8a77995.dtsi | 2 ++
>  1 file changed, 2 insertions(+)

Hi Ulrich,

there seem to be some review comments for this patch.
I would like you to address them before I apply this patch.
Simon Horman Nov. 29, 2017, 9:41 a.m. UTC | #4
On Thu, Nov 16, 2017 at 09:07:26AM +0000, Chris Paterson wrote:
> Hello Ulrich,
> 
> > From: linux-renesas-soc-owner@vger.kernel.org [mailto:linux-renesas-soc-
> > owner@vger.kernel.org] On Behalf Of Ulrich Hecht
> > Sent: 15 November 2017 15:25
> > 
> > Tested on Draak.
> 
> I guess you meant for the patch title to use r8a77995?

I assumed so too. I fixed it up when applying.
diff mbox

Patch

diff --git a/arch/arm64/boot/dts/renesas/r8a77995.dtsi b/arch/arm64/boot/dts/renesas/r8a77995.dtsi
index 04a392a..5fa7572 100644
--- a/arch/arm64/boot/dts/renesas/r8a77995.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a77995.dtsi
@@ -393,6 +393,8 @@ 
 				 <&cpg CPG_CORE R8A77995_CLK_S3D1C>,
 				 <&scif_clk>;
 			clock-names = "fck", "brg_int", "scif_clk";
+			dmas = <&dmac1 0x13>, <&dmac1 0x12>;
+			dma-names = "tx", "rx";
 			power-domains = <&sysc R8A77995_PD_ALWAYS_ON>;
 			resets = <&cpg 310>;
 			status = "disabled";