| Message ID | 1510759526-30346-6-git-send-email-ulrich.hecht+renesas@gmail.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Commit | 480215e2875cff00f71132e1ba24bf9c74e65fc0 |
| Delegated to: | Simon Horman |
| Headers | show |
Hi Uli, On Wed, Nov 15, 2017 at 4:25 PM, Ulrich Hecht <ulrich.hecht+renesas@gmail.com> wrote: > No devices to add, I2C1 has an external connector only. > > Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@gmail.com> Thanks for your patch! Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> but please see below. > --- a/arch/arm64/boot/dts/renesas/r8a77995-draak.dts > +++ b/arch/arm64/boot/dts/renesas/r8a77995-draak.dts > @@ -84,6 +89,12 @@ > }; > }; > > +&i2c1 { > + pinctrl-0 = <&i2c1_pins>; > + pinctrl-names = "default"; > + status = "okay"; If no devices are connected, perhaps it's wise to defer the status update to e.g. an overlay that describes what's connected to CN23? Or do you want it enabled to allow adding devices manually using /sys/bus/i2c/devices/i2c-1/new_device? > +}; Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
On Thu, Nov 16, 2017 at 10:31:31AM +0100, Geert Uytterhoeven wrote: > Hi Uli, > > On Wed, Nov 15, 2017 at 4:25 PM, Ulrich Hecht > <ulrich.hecht+renesas@gmail.com> wrote: > > No devices to add, I2C1 has an external connector only. > > > > Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@gmail.com> > > Thanks for your patch! > > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> > but please see below. Thanks, applied. > > --- a/arch/arm64/boot/dts/renesas/r8a77995-draak.dts > > +++ b/arch/arm64/boot/dts/renesas/r8a77995-draak.dts > > > @@ -84,6 +89,12 @@ > > }; > > }; > > > > +&i2c1 { > > + pinctrl-0 = <&i2c1_pins>; > > + pinctrl-names = "default"; > > + status = "okay"; > > If no devices are connected, perhaps it's wise to defer the status update > to e.g. an overlay that describes what's connected to CN23? > > Or do you want it enabled to allow adding devices manually using > /sys/bus/i2c/devices/i2c-1/new_device? Ulrich, please consider following up on this.
On Fri, Nov 17, 2017 at 06:32:19AM -0800, Simon Horman wrote: > On Thu, Nov 16, 2017 at 10:31:31AM +0100, Geert Uytterhoeven wrote: > > Hi Uli, > > > > On Wed, Nov 15, 2017 at 4:25 PM, Ulrich Hecht > > <ulrich.hecht+renesas@gmail.com> wrote: > > > No devices to add, I2C1 has an external connector only. > > > > > > Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@gmail.com> > > > > Thanks for your patch! > > > > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> > > but please see below. > > Thanks, applied. Sorry, I was a bit hasty there as this patch depends on a patch earlier in the series which I have not applied. I've dropped this patch for now and will wait a bit longer for the review to unfold. > > > --- a/arch/arm64/boot/dts/renesas/r8a77995-draak.dts > > > +++ b/arch/arm64/boot/dts/renesas/r8a77995-draak.dts > > > > > @@ -84,6 +89,12 @@ > > > }; > > > }; > > > > > > +&i2c1 { > > > + pinctrl-0 = <&i2c1_pins>; > > > + pinctrl-names = "default"; > > > + status = "okay"; > > > > If no devices are connected, perhaps it's wise to defer the status update > > to e.g. an overlay that describes what's connected to CN23? > > > > Or do you want it enabled to allow adding devices manually using > > /sys/bus/i2c/devices/i2c-1/new_device? > > Ulrich, please consider following up on this. >
On Thu, Nov 16, 2017 at 10:31 AM, Geert Uytterhoeven <geert@linux-m68k.org> wrote: > If no devices are connected, perhaps it's wise to defer the status update > to e.g. an overlay that describes what's connected to CN23? > > Or do you want it enabled to allow adding devices manually using > /sys/bus/i2c/devices/i2c-1/new_device? Indeed. It's an unpopulated bus on a development board with an external connector, so I think it's valid to assume that it is intended to be used for experimentation. CU Uli
diff --git a/arch/arm64/boot/dts/renesas/r8a77995-draak.dts b/arch/arm64/boot/dts/renesas/r8a77995-draak.dts index 64a6339..91f247f 100644 --- a/arch/arm64/boot/dts/renesas/r8a77995-draak.dts +++ b/arch/arm64/boot/dts/renesas/r8a77995-draak.dts @@ -51,6 +51,11 @@ function = "i2c0"; }; + i2c1_pins: i2c1 { + groups = "i2c1"; + function = "i2c1"; + }; + pwm0_pins: pwm0 { groups = "pwm0_c"; function = "pwm0"; @@ -84,6 +89,12 @@ }; }; +&i2c1 { + pinctrl-0 = <&i2c1_pins>; + pinctrl-names = "default"; + status = "okay"; +}; + &ehci0 { status = "okay"; };
No devices to add, I2C1 has an external connector only. Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@gmail.com> --- arch/arm64/boot/dts/renesas/r8a77995-draak.dts | 11 +++++++++++ 1 file changed, 11 insertions(+)