diff mbox

ARM: dts: vf610-zii-dev-c: Fix switch EEPROM size

Message ID 1510271336-30769-1-git-send-email-andrew@lunn.ch (mailing list archive)
State New, archived
Headers show

Commit Message

Andrew Lunn Nov. 9, 2017, 11:48 p.m. UTC
The two Ethernet switches have an AT24C512 each. This is a 64K device,
not 512 bytes as currently listed in the device tree.

Reported-by: Chris Healy <cphealy@gmail.com>
Signed-off-by: Andrew Lunn <andrew@lunn.ch>
---
 arch/arm/boot/dts/vf610-zii-dev-rev-c.dts | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Chris Healy Nov. 10, 2017, 12:02 a.m. UTC | #1
Reviewed-by: Chris Healy <cphealy@gmail.com>

On Thu, Nov 9, 2017 at 3:48 PM, Andrew Lunn <andrew@lunn.ch> wrote:
> The two Ethernet switches have an AT24C512 each. This is a 64K device,
> not 512 bytes as currently listed in the device tree.
>
> Reported-by: Chris Healy <cphealy@gmail.com>
> Signed-off-by: Andrew Lunn <andrew@lunn.ch>
> ---
>  arch/arm/boot/dts/vf610-zii-dev-rev-c.dts | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/vf610-zii-dev-rev-c.dts b/arch/arm/boot/dts/vf610-zii-dev-rev-c.dts
> index db3b408ea55a..0c557a9e7e17 100644
> --- a/arch/arm/boot/dts/vf610-zii-dev-rev-c.dts
> +++ b/arch/arm/boot/dts/vf610-zii-dev-rev-c.dts
> @@ -73,7 +73,7 @@
>                                 #size-cells = <0>;
>                                 reg = <0>;
>                                 dsa,member = <0 0>;
> -                               eeprom-length = <512>;
> +                               eeprom-length = <65536>;
>                                 interrupt-parent = <&gpio0>;
>                                 interrupts = <27 IRQ_TYPE_LEVEL_LOW>;
>                                 interrupt-controller;
> @@ -170,7 +170,7 @@
>                                 #size-cells = <0>;
>                                 reg = <0>;
>                                 dsa,member = <0 1>;
> -                               eeprom-length = <512>;
> +                               eeprom-length = <65536>;
>                                 interrupt-parent = <&gpio0>;
>                                 interrupts = <26 IRQ_TYPE_LEVEL_LOW>;
>                                 interrupt-controller;
> --
> 2.15.0
>
Fabio Estevam Nov. 10, 2017, 12:18 a.m. UTC | #2
Hi Andrew,

On Thu, Nov 9, 2017 at 9:48 PM, Andrew Lunn <andrew@lunn.ch> wrote:
> The two Ethernet switches have an AT24C512 each. This is a 64K device,
> not 512 bytes as currently listed in the device tree.
>
> Reported-by: Chris Healy <cphealy@gmail.com>
> Signed-off-by: Andrew Lunn <andrew@lunn.ch>
> ---
>  arch/arm/boot/dts/vf610-zii-dev-rev-c.dts | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/vf610-zii-dev-rev-c.dts b/arch/arm/boot/dts/vf610-zii-dev-rev-c.dts
> index db3b408ea55a..0c557a9e7e17 100644
> --- a/arch/arm/boot/dts/vf610-zii-dev-rev-c.dts
> +++ b/arch/arm/boot/dts/vf610-zii-dev-rev-c.dts
> @@ -73,7 +73,7 @@
>                                 #size-cells = <0>;
>                                 reg = <0>;
>                                 dsa,member = <0 0>;
> -                               eeprom-length = <512>;
> +                               eeprom-length = <65536>;

vf610-zii-dev-rev-b.dts also uses 512.

Should it be also changed or is it correct for the rev-b?
Andrew Lunn Nov. 10, 2017, 1:03 a.m. UTC | #3
Hi Fabio

> vf610-zii-dev-rev-b.dts also uses 512.
> 
> Should it be also changed or is it correct for the rev-b?

Rev-B is correct. Rev-C has a newer generation of Ethernet switch,
which has a little microcontroller in it. That microcontroller gets
its code from the EEPROM. So a bigger EEPROM is required.

    Andrew
Fabio Estevam Nov. 10, 2017, 1:09 a.m. UTC | #4
On Thu, Nov 9, 2017 at 11:03 PM, Andrew Lunn <andrew@lunn.ch> wrote:
> Hi Fabio
>
>> vf610-zii-dev-rev-b.dts also uses 512.
>>
>> Should it be also changed or is it correct for the rev-b?
>
> Rev-B is correct. Rev-C has a newer generation of Ethernet switch,
> which has a little microcontroller in it. That microcontroller gets
> its code from the EEPROM. So a bigger EEPROM is required.

Thanks for the clarification:

Reviewed-by: Fabio Estevam <fabio.estevam@nxp.com>
Shawn Guo Nov. 16, 2017, 11:19 a.m. UTC | #5
On Fri, Nov 10, 2017 at 12:48:56AM +0100, Andrew Lunn wrote:
> The two Ethernet switches have an AT24C512 each. This is a 64K device,
> not 512 bytes as currently listed in the device tree.
> 
> Reported-by: Chris Healy <cphealy@gmail.com>
> Signed-off-by: Andrew Lunn <andrew@lunn.ch>

Applied, thanks.
diff mbox

Patch

diff --git a/arch/arm/boot/dts/vf610-zii-dev-rev-c.dts b/arch/arm/boot/dts/vf610-zii-dev-rev-c.dts
index db3b408ea55a..0c557a9e7e17 100644
--- a/arch/arm/boot/dts/vf610-zii-dev-rev-c.dts
+++ b/arch/arm/boot/dts/vf610-zii-dev-rev-c.dts
@@ -73,7 +73,7 @@ 
 				#size-cells = <0>;
 				reg = <0>;
 				dsa,member = <0 0>;
-				eeprom-length = <512>;
+				eeprom-length = <65536>;
 				interrupt-parent = <&gpio0>;
 				interrupts = <27 IRQ_TYPE_LEVEL_LOW>;
 				interrupt-controller;
@@ -170,7 +170,7 @@ 
 				#size-cells = <0>;
 				reg = <0>;
 				dsa,member = <0 1>;
-				eeprom-length = <512>;
+				eeprom-length = <65536>;
 				interrupt-parent = <&gpio0>;
 				interrupts = <26 IRQ_TYPE_LEVEL_LOW>;
 				interrupt-controller;