diff mbox

[2/3] xfsprogs: fix wrong do_pwritev definition

Message ID 20171111172155.31941-2-zlang@redhat.com (mailing list archive)
State Accepted, archived
Headers show

Commit Message

Zorro Lang Nov. 11, 2017, 5:21 p.m. UTC
In io/pwrite.c, if not define HAVE_PWRITEV, we will use:
  #define do_pwritev(fd, offset, count, buffer_size) (0)

But the real do_pwritev() function is:
  do_pwritev(fd, offset, count, buffer_size, pwritev2_flags);

There's one more 'pwritev2_flags' argument.

Signed-off-by: Zorro Lang <zlang@redhat.com>
---
 io/pwrite.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Eric Sandeen Nov. 16, 2017, 8:33 p.m. UTC | #1
On 11/11/17 11:21 AM, Zorro Lang wrote:
> In io/pwrite.c, if not define HAVE_PWRITEV, we will use:
>   #define do_pwritev(fd, offset, count, buffer_size) (0)
> 
> But the real do_pwritev() function is:
>   do_pwritev(fd, offset, count, buffer_size, pwritev2_flags);
> 
> There's one more 'pwritev2_flags' argument.
> 
> Signed-off-by: Zorro Lang <zlang@redhat.com>

Reviewed-by: Eric Sandeen <sandeen@redhat.com>

> ---
>  io/pwrite.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/io/pwrite.c b/io/pwrite.c
> index 3df976a8..a89edfd0 100644
> --- a/io/pwrite.c
> +++ b/io/pwrite.c
> @@ -102,7 +102,7 @@ do_pwritev(
>  	return bytes;
>  }
>  #else
> -#define do_pwritev(fd, offset, count, buffer_size) (0)
> +#define do_pwritev(fd, offset, count, buffer_size, pwritev2_flags) (0)
>  #endif
>  
>  static ssize_t
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/io/pwrite.c b/io/pwrite.c
index 3df976a8..a89edfd0 100644
--- a/io/pwrite.c
+++ b/io/pwrite.c
@@ -102,7 +102,7 @@  do_pwritev(
 	return bytes;
 }
 #else
-#define do_pwritev(fd, offset, count, buffer_size) (0)
+#define do_pwritev(fd, offset, count, buffer_size, pwritev2_flags) (0)
 #endif
 
 static ssize_t