| Message ID | 20171110084650.31325-2-yixun.lan@amlogic.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
On 10/11/2017 09:46, Yixun Lan wrote: > Try to add compatible string explictly to support new Meson-AXG SoC. > > Signed-off-by: Yixun Lan <yixun.lan@amlogic.com> > --- > drivers/reset/reset-meson.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/reset/reset-meson.c b/drivers/reset/reset-meson.c > index c419a3753d00..93cbee1ae8ef 100644 > --- a/drivers/reset/reset-meson.c > +++ b/drivers/reset/reset-meson.c > @@ -139,6 +139,8 @@ static const struct of_device_id meson_reset_dt_ids[] = { > .data = &meson_reset_meson8_ops, }, > { .compatible = "amlogic,meson-gxbb-reset", > .data = &meson_reset_gx_ops, }, > + { .compatible = "amlogic,meson-axg-reset", > + .data = &meson_reset_gx_ops, }, > { /* sentinel */ }, > }; > > Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
Hi Philipp On 11/10/2017 04:46 PM, Yixun Lan wrote: > Try to add compatible string explictly to support new Meson-AXG SoC. > > Signed-off-by: Yixun Lan <yixun.lan@amlogic.com> > --- > drivers/reset/reset-meson.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/reset/reset-meson.c b/drivers/reset/reset-meson.c > index c419a3753d00..93cbee1ae8ef 100644 > --- a/drivers/reset/reset-meson.c > +++ b/drivers/reset/reset-meson.c > @@ -139,6 +139,8 @@ static const struct of_device_id meson_reset_dt_ids[] = { > .data = &meson_reset_meson8_ops, }, > { .compatible = "amlogic,meson-gxbb-reset", > .data = &meson_reset_gx_ops, }, > + { .compatible = "amlogic,meson-axg-reset", > + .data = &meson_reset_gx_ops, }, > { /* sentinel */ }, > }; > > it's generally a ping to the status of these two patches[1], are they ready to go? or do you have any comment? or do you want me to send another version with Neil's Reviewed-by added[1] thanks Yixun [1] http://lists.infradead.org/pipermail/linux-amlogic/2017-November/005278.html [2] http://lists.infradead.org/pipermail/linux-amlogic/2017-November/005318.html http://lists.infradead.org/pipermail/linux-amlogic/2017-November/005319.html
Hi Yixun, On Wed, 2017-12-13 at 22:07 +0800, Yixun Lan wrote: > Hi Philipp > > On 11/10/2017 04:46 PM, Yixun Lan wrote: > > Try to add compatible string explictly to support new Meson-AXG SoC. > > > > Signed-off-by: Yixun Lan <yixun.lan@amlogic.com> > > --- > > drivers/reset/reset-meson.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/drivers/reset/reset-meson.c b/drivers/reset/reset-meson.c > > index c419a3753d00..93cbee1ae8ef 100644 > > --- a/drivers/reset/reset-meson.c > > +++ b/drivers/reset/reset-meson.c > > @@ -139,6 +139,8 @@ static const struct of_device_id meson_reset_dt_ids[] = { > > .data = &meson_reset_meson8_ops, }, > > { .compatible = "amlogic,meson-gxbb-reset", > > .data = &meson_reset_gx_ops, }, > > + { .compatible = "amlogic,meson-axg-reset", > > + .data = &meson_reset_gx_ops, }, > > { /* sentinel */ }, > > }; > > > > > > it's generally a ping to the status of these two patches[1], are they > ready to go? or do you have any comment? or do you want me to send > another version with Neil's Reviewed-by added[1] I forgot to update you on the status. I have put both patches on the reset/next branch with Neil's R-b, they are in linux-next: 0e5721f76252 ("reset: meson-axg: add compatible string for Meson-AXG SoC") c16292578ffa ("dt-bindings: reset: Add bindings for the Meson-AXG SoC Reset Controller") I'll include them with the next pull request. regards Philipp
On 12/14/17 00:01, Philipp Zabel wrote: > Hi Yixun, > > On Wed, 2017-12-13 at 22:07 +0800, Yixun Lan wrote: >> Hi Philipp >> >> On 11/10/2017 04:46 PM, Yixun Lan wrote: >>> Try to add compatible string explictly to support new Meson-AXG SoC. >>> >>> Signed-off-by: Yixun Lan <yixun.lan@amlogic.com> >>> --- >>> drivers/reset/reset-meson.c | 2 ++ >>> 1 file changed, 2 insertions(+) >>> >>> diff --git a/drivers/reset/reset-meson.c b/drivers/reset/reset-meson.c >>> index c419a3753d00..93cbee1ae8ef 100644 >>> --- a/drivers/reset/reset-meson.c >>> +++ b/drivers/reset/reset-meson.c >>> @@ -139,6 +139,8 @@ static const struct of_device_id meson_reset_dt_ids[] = { >>> .data = &meson_reset_meson8_ops, }, >>> { .compatible = "amlogic,meson-gxbb-reset", >>> .data = &meson_reset_gx_ops, }, >>> + { .compatible = "amlogic,meson-axg-reset", >>> + .data = &meson_reset_gx_ops, }, >>> { /* sentinel */ }, >>> }; >>> >>> >> >> it's generally a ping to the status of these two patches[1], are they >> ready to go? or do you have any comment? or do you want me to send >> another version with Neil's Reviewed-by added[1] > > I forgot to update you on the status. I have put both patches on the > reset/next branch with Neil's R-b, they are in linux-next: > > 0e5721f76252 ("reset: meson-axg: add compatible string for Meson-AXG SoC") > c16292578ffa ("dt-bindings: reset: Add bindings for the Meson-AXG SoC Reset Controller") > > I'll include them with the next pull request. > Hi Philipp great & thanks. Hi Kevin: could you take the DT part[1] via your tree, also with Neil's Reviewed-by added? I've checked, it could apply cleanly to your v4.16/dt64 branch many thanks Yixun [1] http://lists.infradead.org/pipermail/linux-amlogic/2017-November/005280.html
diff --git a/drivers/reset/reset-meson.c b/drivers/reset/reset-meson.c index c419a3753d00..93cbee1ae8ef 100644 --- a/drivers/reset/reset-meson.c +++ b/drivers/reset/reset-meson.c @@ -139,6 +139,8 @@ static const struct of_device_id meson_reset_dt_ids[] = { .data = &meson_reset_meson8_ops, }, { .compatible = "amlogic,meson-gxbb-reset", .data = &meson_reset_gx_ops, }, + { .compatible = "amlogic,meson-axg-reset", + .data = &meson_reset_gx_ops, }, { /* sentinel */ }, };
Try to add compatible string explictly to support new Meson-AXG SoC. Signed-off-by: Yixun Lan <yixun.lan@amlogic.com> --- drivers/reset/reset-meson.c | 2 ++ 1 file changed, 2 insertions(+)