| Message ID | 20171117213753.21050-1-christophe.jaillet@wanadoo.fr (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
On 11/17/2017 02:37 PM, Christophe JAILLET wrote: > If the last test in 'ioat_dma_self_test()' fails, we must release all > the allocated resources and not just part of them. > > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> Good catch! Thanks! Acked-by: Dave Jiang <dave.jiang@intel.com> > --- > drivers/dma/ioat/init.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/dma/ioat/init.c b/drivers/dma/ioat/init.c > index 2f31d3d0caa6..7792a9186f9c 100644 > --- a/drivers/dma/ioat/init.c > +++ b/drivers/dma/ioat/init.c > @@ -390,7 +390,7 @@ static int ioat_dma_self_test(struct ioatdma_device *ioat_dma) > if (memcmp(src, dest, IOAT_TEST_SIZE)) { > dev_err(dev, "Self-test copy failed compare, disabling\n"); > err = -ENODEV; > - goto free_resources; > + goto unmap_dma; > } > > unmap_dma: > -- To unsubscribe from this list: send the line "unsubscribe dmaengine" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, Nov 17, 2017 at 10:37:53PM +0100, Christophe JAILLET wrote: > If the last test in 'ioat_dma_self_test()' fails, we must release all > the allocated resources and not just part of them. Applied, thanks
diff --git a/drivers/dma/ioat/init.c b/drivers/dma/ioat/init.c index 2f31d3d0caa6..7792a9186f9c 100644 --- a/drivers/dma/ioat/init.c +++ b/drivers/dma/ioat/init.c @@ -390,7 +390,7 @@ static int ioat_dma_self_test(struct ioatdma_device *ioat_dma) if (memcmp(src, dest, IOAT_TEST_SIZE)) { dev_err(dev, "Self-test copy failed compare, disabling\n"); err = -ENODEV; - goto free_resources; + goto unmap_dma; } unmap_dma:
If the last test in 'ioat_dma_self_test()' fails, we must release all the allocated resources and not just part of them. Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> --- drivers/dma/ioat/init.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)