diff mbox

drivers/video/udlfb bind framebuffer to interface.

Message ID 1309910651-3483-1-git-send-email-bernie@plugable.com (mailing list archive)
State New, archived
Headers show

Commit Message

bernie@plugable.com July 6, 2011, 12:04 a.m. UTC 
From: Kay Sievers <kay.sievers@vrfy.org>

Udlfb has been binding the framebuffer device to its parent, which
isn't correct and causes confusion with operations like udev remove.

Coming plug and play multiseat support is dependent on this fix.

Signed-off-by: Bernie Thompson <bernie@plugable.com>
---
 drivers/video/udlfb.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Comments

Paul Mundt July 13, 2011, 8:17 a.m. UTC | #1 
On Tue, Jul 05, 2011 at 05:04:11PM -0700, bernie@plugable.com wrote:
> Udlfb has been binding the framebuffer device to its parent, which
> isn't correct and causes confusion with operations like udev remove.
> 
> Coming plug and play multiseat support is dependent on this fix.
> 
> Signed-off-by: Bernie Thompson <bernie@plugable.com>

On Sun, Jul 10, 2011 at 12:30:00AM -0700, bernie@plugable.com wrote:
> Match udlfb only against vendor-specific class (e.g. only DisplayLink
> graphics, not composite standard audio class interfaces). This enables
> compatibility with composite graphics+audio devices (e.g. HDMI).
> 
> Match udlfb only against compatible subclass 0 and protocol 0 chips.
> DisplayLink's USB 3.0 generation chips increment these values
> to signal that they have a incompatible protocol, preventing udlfb
> from erroneously matching to hardware it does not support.
> 
> Tested to confirm proper behavior on both USB 2.0 and USB 3.0
> generation devices.
> 
> Reported-by: Andrew Kephart <akephart@akephart.org>
> Signed-off-by: Bernie Thompson <bernie@plugable.com>

Both queued for 3.0, thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/video/udlfb.c b/drivers/video/udlfb.c
index 816a4fd..c6584c9 100644
--- a/drivers/video/udlfb.c
+++ b/drivers/video/udlfb.c
@@ -1549,7 +1549,7 @@  static int dlfb_usb_probe(struct usb_interface *interface,
 	/* We don't register a new USB class. Our client interface is fbdev */
 
 	/* allocates framebuffer driver structure, not framebuffer memory */
-	info = framebuffer_alloc(0, &usbdev->dev);
+	info = framebuffer_alloc(0, &interface->dev);
 	if (!info) {
 		retval = -ENOMEM;
 		pr_err("framebuffer_alloc failed\n");