| Message ID | 1510041442-15176-3-git-send-email-yamada.masahiro@socionext.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
2017-11-07 16:57 GMT+09:00 Masahiro Yamada <yamada.masahiro@socionext.com>: > ARCH_RENESAS is a stronger condition than (ARM || ARM64). > If ARCH_RENESAS is enabled, (ARM || ARM64) is met as well. > > What is worse, the first depends on line prevents COMPILE_TEST from > enabling this driver. It should be removed. > > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> > --- A typo in the subject. renesas_shci -> renesas_sdhc > drivers/mmc/host/Kconfig | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig > index 5420da5..5bc6388 100644 > --- a/drivers/mmc/host/Kconfig > +++ b/drivers/mmc/host/Kconfig > @@ -581,7 +581,6 @@ config MMC_TMIO > > config MMC_SDHI > tristate "Renesas SDHI SD/SDIO controller support" > - depends on SUPERH || ARM || ARM64 > depends on SUPERH || ARCH_RENESAS || COMPILE_TEST > select MMC_TMIO_CORE > help > -- > 2.7.4 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-mmc" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, Nov 07, 2017 at 04:57:22PM +0900, Masahiro Yamada wrote: > ARCH_RENESAS is a stronger condition than (ARM || ARM64). > If ARCH_RENESAS is enabled, (ARM || ARM64) is met as well. > > What is worse, the first depends on line prevents COMPILE_TEST from > enabling this driver. It should be removed. > > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> Acked-by: Wolfram Sang <wsa+renesas@sang-engineering.com> Simon, you did the last refactoring, can you have a look, too?
> A typo in the subject. > > renesas_shci -> renesas_sdhc renesas_sdhi ;)
diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig index 5420da5..5bc6388 100644 --- a/drivers/mmc/host/Kconfig +++ b/drivers/mmc/host/Kconfig @@ -581,7 +581,6 @@ config MMC_TMIO config MMC_SDHI tristate "Renesas SDHI SD/SDIO controller support" - depends on SUPERH || ARM || ARM64 depends on SUPERH || ARCH_RENESAS || COMPILE_TEST select MMC_TMIO_CORE help
ARCH_RENESAS is a stronger condition than (ARM || ARM64). If ARCH_RENESAS is enabled, (ARM || ARM64) is met as well. What is worse, the first depends on line prevents COMPILE_TEST from enabling this driver. It should be removed. Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> --- drivers/mmc/host/Kconfig | 1 - 1 file changed, 1 deletion(-)