| Message ID | 20171109222614.5719-3-robh@kernel.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Thu, Nov 9, 2017 at 4:26 PM, Rob Herring <robh@kernel.org> wrote: > "usb-nop-xceiv" is using the phy binding, but is missing #phy-cells > property. This is probably because the binding was the precursor to the phy > binding. > > Fixes the following warning in Marvell dts files: > > Warning (phys_property): Missing property '#phy-cells' in node ... > > Signed-off-by: Rob Herring <robh@kernel.org> > Cc: Jason Cooper <jason@lakedaemon.net> > Cc: Andrew Lunn <andrew@lunn.ch> > Cc: Gregory Clement <gregory.clement@free-electrons.com> > Cc: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com> > --- > Please apply to Marvell tree. Ping. Arnd, can you apply if you'd like the warnings fixed and Marvell maintainers don't respond. > > arch/arm/boot/dts/armada-385-db-ap.dts | 1 + > arch/arm/boot/dts/armada-385-linksys.dtsi | 1 + > arch/arm/boot/dts/armada-385-synology-ds116.dts | 2 ++ > arch/arm/boot/dts/armada-388-gp.dts | 2 ++ > 4 files changed, 6 insertions(+)
On Tue, Nov 21, 2017 at 12:29:48PM -0600, Rob Herring wrote: > On Thu, Nov 9, 2017 at 4:26 PM, Rob Herring <robh@kernel.org> wrote: > > "usb-nop-xceiv" is using the phy binding, but is missing #phy-cells > > property. This is probably because the binding was the precursor to the phy > > binding. > > > > Fixes the following warning in Marvell dts files: > > > > Warning (phys_property): Missing property '#phy-cells' in node ... > > > > Signed-off-by: Rob Herring <robh@kernel.org> > > Cc: Jason Cooper <jason@lakedaemon.net> > > Cc: Andrew Lunn <andrew@lunn.ch> > > Cc: Gregory Clement <gregory.clement@free-electrons.com> > > Cc: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com> > > --- > > Please apply to Marvell tree. > > Ping. > > Arnd, can you apply if you'd like the warnings fixed and Marvell > maintainers don't respond. Hi Rob Patches submitted a week before the merge window opens are generally deferred to the next cycle. I expect that once -rc1 is out, Gregory will pick up this patch. Andrew
On Tue, Nov 21, 2017 at 9:09 PM, Andrew Lunn <andrew@lunn.ch> wrote: > On Tue, Nov 21, 2017 at 12:29:48PM -0600, Rob Herring wrote: >> On Thu, Nov 9, 2017 at 4:26 PM, Rob Herring <robh@kernel.org> wrote: >> > "usb-nop-xceiv" is using the phy binding, but is missing #phy-cells >> > property. This is probably because the binding was the precursor to the phy >> > binding. >> > >> > Fixes the following warning in Marvell dts files: >> > >> > Warning (phys_property): Missing property '#phy-cells' in node ... >> > >> > Signed-off-by: Rob Herring <robh@kernel.org> >> > Cc: Jason Cooper <jason@lakedaemon.net> >> > Cc: Andrew Lunn <andrew@lunn.ch> >> > Cc: Gregory Clement <gregory.clement@free-electrons.com> >> > Cc: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com> >> > --- >> > Please apply to Marvell tree. >> >> Ping. >> >> Arnd, can you apply if you'd like the warnings fixed and Marvell >> maintainers don't respond. > > Hi Rob > > Patches submitted a week before the merge window opens are generally > deferred to the next cycle. I expect that once -rc1 is out, Gregory > will pick up this patch. These are real bugfixes, I want them in 4.15, since we now get a loud warning for them. I'd rather not shut up that warning because it's not a false-positive. Arnd
On Thu, Nov 09, 2017 at 04:26:11PM -0600, Rob Herring wrote: > "usb-nop-xceiv" is using the phy binding, but is missing #phy-cells > property. This is probably because the binding was the precursor to the phy > binding. > > Fixes the following warning in Marvell dts files: > > Warning (phys_property): Missing property '#phy-cells' in node ... > > Signed-off-by: Rob Herring <robh@kernel.org> Reviewed-by: Andrew Lunn <andrew@lunn.ch> Andrew
Hi Arnd, On mar., nov. 21 2017, Arnd Bergmann <arnd@arndb.de> wrote: > On Tue, Nov 21, 2017 at 9:09 PM, Andrew Lunn <andrew@lunn.ch> wrote: >> On Tue, Nov 21, 2017 at 12:29:48PM -0600, Rob Herring wrote: >>> On Thu, Nov 9, 2017 at 4:26 PM, Rob Herring <robh@kernel.org> wrote: >>> > "usb-nop-xceiv" is using the phy binding, but is missing #phy-cells >>> > property. This is probably because the binding was the precursor to the phy >>> > binding. >>> > >>> > Fixes the following warning in Marvell dts files: >>> > >>> > Warning (phys_property): Missing property '#phy-cells' in node ... >>> > >>> > Signed-off-by: Rob Herring <robh@kernel.org> >>> > Cc: Jason Cooper <jason@lakedaemon.net> >>> > Cc: Andrew Lunn <andrew@lunn.ch> >>> > Cc: Gregory Clement <gregory.clement@free-electrons.com> >>> > Cc: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com> >>> > --- >>> > Please apply to Marvell tree. >>> >>> Ping. >>> >>> Arnd, can you apply if you'd like the warnings fixed and Marvell >>> maintainers don't respond. >> >> Hi Rob >> >> Patches submitted a week before the merge window opens are generally >> deferred to the next cycle. I expect that once -rc1 is out, Gregory >> will pick up this patch. > > These are real bugfixes, I want them in 4.15, since we now get a > loud warning for them. I'd rather not shut up that warning because > it's not a false-positive. As pointed by Andrew, I planned to take them once the 4.15-rc1 would be released. It was not obvious for me that it was real fixes. Actually I would have expected to have first the dts fixed in a release and then the warning enabled. I am fine if you take this patch, especially if it is merged in 4.15-rc1. So for this patch: Acked-by: Gregory CLEMENT <gregory.clement@free-electrons.com> Thanks, Gregory > > Arnd
On Wed, Nov 22, 2017 at 10:59 AM, Gregory CLEMENT <gregory.clement@free-electrons.com> wrote: > Hi Arnd, > > On mar., nov. 21 2017, Arnd Bergmann <arnd@arndb.de> wrote: > >> On Tue, Nov 21, 2017 at 9:09 PM, Andrew Lunn <andrew@lunn.ch> wrote: >>> On Tue, Nov 21, 2017 at 12:29:48PM -0600, Rob Herring wrote: >>>> On Thu, Nov 9, 2017 at 4:26 PM, Rob Herring <robh@kernel.org> wrote: >>>> > "usb-nop-xceiv" is using the phy binding, but is missing #phy-cells >>>> > property. This is probably because the binding was the precursor to the phy >>>> > binding. >>>> > >>>> > Fixes the following warning in Marvell dts files: >>>> > >>>> > Warning (phys_property): Missing property '#phy-cells' in node ... >>>> > >>>> > Signed-off-by: Rob Herring <robh@kernel.org> >>>> > Cc: Jason Cooper <jason@lakedaemon.net> >>>> > Cc: Andrew Lunn <andrew@lunn.ch> >>>> > Cc: Gregory Clement <gregory.clement@free-electrons.com> >>>> > Cc: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com> >>>> > --- >>>> > Please apply to Marvell tree. >>>> >>>> Ping. >>>> >>>> Arnd, can you apply if you'd like the warnings fixed and Marvell >>>> maintainers don't respond. >>> >>> Hi Rob >>> >>> Patches submitted a week before the merge window opens are generally >>> deferred to the next cycle. I expect that once -rc1 is out, Gregory >>> will pick up this patch. >> >> These are real bugfixes, I want them in 4.15, since we now get a >> loud warning for them. I'd rather not shut up that warning because >> it's not a false-positive. > > As pointed by Andrew, I planned to take them once the 4.15-rc1 would be > released. It was not obvious for me that it was real fixes. Actually I > would have expected to have first the dts fixed in a release and then > the warning enabled. I didn't plan to fix everyone's warnings for them. Unfortunately, the combination of linux-next being infrequent in Oct and kernelci.org failing to report dtc warnings caused all the warnings started to get noticed late, so I fixed the noisier cases. The only way anyone pays attention is when dtc is updated and warnings appear. I've emailed out warnings in advance before. I've turned off the more subjective ones by default. Neither seems to get widely noticed (now in reviews instead of saying "don't do X", I say "don't do X and building with W=2 will tell you this"). More dtc checks are coming, so I'm open to suggestions on the process. Rob
On Tue, Nov 21, 2017 at 09:56:22PM +0100, Andrew Lunn wrote: > On Thu, Nov 09, 2017 at 04:26:11PM -0600, Rob Herring wrote: > > "usb-nop-xceiv" is using the phy binding, but is missing #phy-cells > > property. This is probably because the binding was the precursor to the phy > > binding. > > > > Fixes the following warning in Marvell dts files: > > > > Warning (phys_property): Missing property '#phy-cells' in node ... > > > > Signed-off-by: Rob Herring <robh@kernel.org> > > Reviewed-by: Andrew Lunn <andrew@lunn.ch> I didn't see this come in before -rc1 and in current fixes, so given the acks I've applied it directly now. -Olof
diff --git a/arch/arm/boot/dts/armada-385-db-ap.dts b/arch/arm/boot/dts/armada-385-db-ap.dts index 25d2d720dc0e..678aa023335d 100644 --- a/arch/arm/boot/dts/armada-385-db-ap.dts +++ b/arch/arm/boot/dts/armada-385-db-ap.dts @@ -236,6 +236,7 @@ usb3_phy: usb3_phy { compatible = "usb-nop-xceiv"; vcc-supply = <®_xhci0_vbus>; + #phy-cells = <0>; }; reg_xhci0_vbus: xhci0-vbus { diff --git a/arch/arm/boot/dts/armada-385-linksys.dtsi b/arch/arm/boot/dts/armada-385-linksys.dtsi index e1f355ffc8f7..434dc9aaa5e4 100644 --- a/arch/arm/boot/dts/armada-385-linksys.dtsi +++ b/arch/arm/boot/dts/armada-385-linksys.dtsi @@ -66,6 +66,7 @@ usb3_1_phy: usb3_1-phy { compatible = "usb-nop-xceiv"; vcc-supply = <&usb3_1_vbus>; + #phy-cells = <0>; }; usb3_1_vbus: usb3_1-vbus { diff --git a/arch/arm/boot/dts/armada-385-synology-ds116.dts b/arch/arm/boot/dts/armada-385-synology-ds116.dts index 31510eb56f10..55a3c4870b8c 100644 --- a/arch/arm/boot/dts/armada-385-synology-ds116.dts +++ b/arch/arm/boot/dts/armada-385-synology-ds116.dts @@ -191,11 +191,13 @@ usb3_0_phy: usb3_0_phy { compatible = "usb-nop-xceiv"; vcc-supply = <®_usb3_0_vbus>; + #phy-cells = <0>; }; usb3_1_phy: usb3_1_phy { compatible = "usb-nop-xceiv"; vcc-supply = <®_usb3_1_vbus>; + #phy-cells = <0>; }; reg_usb3_0_vbus: usb3-vbus0 { diff --git a/arch/arm/boot/dts/armada-388-gp.dts b/arch/arm/boot/dts/armada-388-gp.dts index f503955dbd3b..51b4ee6df130 100644 --- a/arch/arm/boot/dts/armada-388-gp.dts +++ b/arch/arm/boot/dts/armada-388-gp.dts @@ -276,11 +276,13 @@ usb2_1_phy: usb2_1_phy { compatible = "usb-nop-xceiv"; vcc-supply = <®_usb2_1_vbus>; + #phy-cells = <0>; }; usb3_phy: usb3_phy { compatible = "usb-nop-xceiv"; vcc-supply = <®_usb3_vbus>; + #phy-cells = <0>; }; reg_usb3_vbus: usb3-vbus {
"usb-nop-xceiv" is using the phy binding, but is missing #phy-cells property. This is probably because the binding was the precursor to the phy binding. Fixes the following warning in Marvell dts files: Warning (phys_property): Missing property '#phy-cells' in node ... Signed-off-by: Rob Herring <robh@kernel.org> Cc: Jason Cooper <jason@lakedaemon.net> Cc: Andrew Lunn <andrew@lunn.ch> Cc: Gregory Clement <gregory.clement@free-electrons.com> Cc: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com> --- Please apply to Marvell tree. arch/arm/boot/dts/armada-385-db-ap.dts | 1 + arch/arm/boot/dts/armada-385-linksys.dtsi | 1 + arch/arm/boot/dts/armada-385-synology-ds116.dts | 2 ++ arch/arm/boot/dts/armada-388-gp.dts | 2 ++ 4 files changed, 6 insertions(+)