| Message ID | b6001c7b7fb98e7a3ad4c712084fea9dae9e6b27.1511884135.git.hns@goldelico.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
* H. Nikolaus Schaller <hns@goldelico.com> [171128 15:52]: > We can remove the unnecessary "omapdss," prefix because > the omapdrm driver takes care of it when matching with > the driver table. So is this needed as a fix or is this another clean-up? So is this is really needed as a fix? If this is just clean-up, again, please resend once the driver changes have cleared. Regards, Tony > Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com> > --- > arch/arm/boot/dts/omap3-pandora-common.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/boot/dts/omap3-pandora-common.dtsi b/arch/arm/boot/dts/omap3-pandora-common.dtsi > index 53e007abdc71..64d967ec8c58 100644 > --- a/arch/arm/boot/dts/omap3-pandora-common.dtsi > +++ b/arch/arm/boot/dts/omap3-pandora-common.dtsi > @@ -626,7 +626,7 @@ > > lcd: lcd@1 { > reg = <1>; /* CS1 */ > - compatible = "omapdss,tpo,td043mtea1"; > + compatible = "tpo,td043mtea1"; > spi-max-frequency = <100000>; > spi-cpol; > spi-cpha; > -- > 2.12.2 >
Hi Tony, > Am 28.11.2017 um 17:04 schrieb Tony Lindgren <tony@atomide.com>: > > * H. Nikolaus Schaller <hns@goldelico.com> [171128 15:52]: >> We can remove the unnecessary "omapdss," prefix because >> the omapdrm driver takes care of it when matching with >> the driver table. > > So is this needed as a fix or is this another clean-up? > > So is this is really needed as a fix? Hm. How do you differentiate between "fix" and "cleanup"? Maybe it is more a wording than a content issue... For me it is a "fix" because it is semantically wrong to have a prefix where it is not needed. And "fixing" it changes the compiler output by 8 bytes. "Cleanup" would be for me removing whitespace or empty lines or typos in comments. > > If this is just clean-up, again, please resend once the driver > changes have cleared. There is no change to the pandora driver involved here. The Pandora panel driver is already correct. Just the DTS has some redundant content which should be removed. So there is no dependency for this patch. BR, Nikolaus > > Regards, > > Tony > >> Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com> >> --- >> arch/arm/boot/dts/omap3-pandora-common.dtsi | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/arch/arm/boot/dts/omap3-pandora-common.dtsi b/arch/arm/boot/dts/omap3-pandora-common.dtsi >> index 53e007abdc71..64d967ec8c58 100644 >> --- a/arch/arm/boot/dts/omap3-pandora-common.dtsi >> +++ b/arch/arm/boot/dts/omap3-pandora-common.dtsi >> @@ -626,7 +626,7 @@ >> >> lcd: lcd@1 { >> reg = <1>; /* CS1 */ >> - compatible = "omapdss,tpo,td043mtea1"; >> + compatible = "tpo,td043mtea1"; >> spi-max-frequency = <100000>; >> spi-cpol; >> spi-cpha; >> -- >> 2.12.2 >>
* H. Nikolaus Schaller <hns@goldelico.com> [171128 16:17]: > Hi Tony, > > > Am 28.11.2017 um 17:04 schrieb Tony Lindgren <tony@atomide.com>: > > > > * H. Nikolaus Schaller <hns@goldelico.com> [171128 15:52]: > >> We can remove the unnecessary "omapdss," prefix because > >> the omapdrm driver takes care of it when matching with > >> the driver table. > > > > So is this needed as a fix or is this another clean-up? > > > > So is this is really needed as a fix? > > Hm. How do you differentiate between "fix" and "cleanup"? > Maybe it is more a wording than a content issue... > > For me it is a "fix" because it is semantically wrong to have > a prefix where it is not needed. And "fixing" it changes the > compiler output by 8 bytes. How about let's call it a "typo fix" then? :) > "Cleanup" would be for me removing whitespace or empty lines > or typos in comments. > > > If this is just clean-up, again, please resend once the driver > > changes have cleared. > > There is no change to the pandora driver involved here. The Pandora > panel driver is already correct. Just the DTS has some redundant > content which should be removed. > > So there is no dependency for this patch. OK please resend separately after the driver changes have merged then. Regards, Tony
Hi, > Am 28.11.2017 um 17:18 schrieb Tony Lindgren <tony@atomide.com>: > > * H. Nikolaus Schaller <hns@goldelico.com> [171128 16:17]: >> Hi Tony, >> >>> Am 28.11.2017 um 17:04 schrieb Tony Lindgren <tony@atomide.com>: >>> >>> * H. Nikolaus Schaller <hns@goldelico.com> [171128 15:52]: >>>> We can remove the unnecessary "omapdss," prefix because >>>> the omapdrm driver takes care of it when matching with >>>> the driver table. >>> >>> So is this needed as a fix or is this another clean-up? >>> >>> So is this is really needed as a fix? >> >> Hm. How do you differentiate between "fix" and "cleanup"? >> Maybe it is more a wording than a content issue... >> >> For me it is a "fix" because it is semantically wrong to have >> a prefix where it is not needed. And "fixing" it changes the >> compiler output by 8 bytes. > > How about let's call it a "typo fix" then? :) Well, it is not really a typo. > >> "Cleanup" would be for me removing whitespace or empty lines >> or typos in comments. >> >>> If this is just clean-up, again, please resend once the driver >>> changes have cleared. >> >> There is no change to the pandora driver involved here. The Pandora >> panel driver is already correct. Just the DTS has some redundant >> content which should be removed. >> >> So there is no dependency for this patch. > > OK please resend separately after the driver changes have merged > then. The Pandora driver does not need an update. Only the DTS. So there is noting to merge or wait for. Maybe the confusion comes that in both cases (GTA04 and OpenPandora) there are changes to DTS. But different ones. GTA04: change vendor prefix to make it consistent Pandora: remove redundant (unnecessary and potentially wrong) omapdss, prefix In addition we have to modify the GTA04 panel to handle the correct vendor prefix. The Pandora panel already uses the right one. Anyways, I think it is now Tomi to decide about the panel driver (vendor prefix) patch 1/4 and 2/4 first. Then we can sort out the DTS changes (3/4 and 4/4). BR and thanks, Nikolaus
* H. Nikolaus Schaller <hns@goldelico.com> [171128 18:35]: > Hi, > > > Am 28.11.2017 um 17:18 schrieb Tony Lindgren <tony@atomide.com>: > > > > * H. Nikolaus Schaller <hns@goldelico.com> [171128 16:17]: > >> Hi Tony, > >> > >>> Am 28.11.2017 um 17:04 schrieb Tony Lindgren <tony@atomide.com>: > >>> > >>> * H. Nikolaus Schaller <hns@goldelico.com> [171128 15:52]: > >>>> We can remove the unnecessary "omapdss," prefix because > >>>> the omapdrm driver takes care of it when matching with > >>>> the driver table. > >>> > >>> So is this needed as a fix or is this another clean-up? > >>> > >>> So is this is really needed as a fix? > >> > >> Hm. How do you differentiate between "fix" and "cleanup"? > >> Maybe it is more a wording than a content issue... > >> > >> For me it is a "fix" because it is semantically wrong to have > >> a prefix where it is not needed. And "fixing" it changes the > >> compiler output by 8 bytes. > > > > How about let's call it a "typo fix" then? :) > > Well, it is not really a typo. Well what if the stable people pick it into earlier stable series based on the word fix in the subject? That has happened before. I suggest you update the dts patches to use wording like "update compatible to use new naming" or something similar. Regards, Tony
Hi, On Thu, Nov 30, 2017 at 07:24:30AM -0800, Tony Lindgren wrote: > * H. Nikolaus Schaller <hns@goldelico.com> [171128 18:35]: > > Hi, > > > > > Am 28.11.2017 um 17:18 schrieb Tony Lindgren <tony@atomide.com>: > > > > > > * H. Nikolaus Schaller <hns@goldelico.com> [171128 16:17]: > > >> Hi Tony, > > >> > > >>> Am 28.11.2017 um 17:04 schrieb Tony Lindgren <tony@atomide.com>: > > >>> > > >>> * H. Nikolaus Schaller <hns@goldelico.com> [171128 15:52]: > > >>>> We can remove the unnecessary "omapdss," prefix because > > >>>> the omapdrm driver takes care of it when matching with > > >>>> the driver table. > > >>> > > >>> So is this needed as a fix or is this another clean-up? > > >>> > > >>> So is this is really needed as a fix? > > >> > > >> Hm. How do you differentiate between "fix" and "cleanup"? > > >> Maybe it is more a wording than a content issue... > > >> > > >> For me it is a "fix" because it is semantically wrong to have > > >> a prefix where it is not needed. And "fixing" it changes the > > >> compiler output by 8 bytes. > > > > > > How about let's call it a "typo fix" then? :) > > > > Well, it is not really a typo. > > Well what if the stable people pick it into earlier stable series > based on the word fix in the subject? That has happened before. > > I suggest you update the dts patches to use wording like > "update compatible to use new naming" or something similar. Patch 4/4 is a Fix and should be applied to stable trees. "omapdss," prefix was never supposed to be in the DTS files, is not supposed to be in there now and will break some time in the future. Explanation: The early init of omapdss adds the prefix at runtime, so that the binding can use generic properties and the kernel can use omapdss specific drivers until the generic ones can be used. -- Sebastian
> Am 30.11.2017 um 16:24 schrieb Tony Lindgren <tony@atomide.com>: > > * H. Nikolaus Schaller <hns@goldelico.com> [171128 18:35]: >> Hi, >> >>> Am 28.11.2017 um 17:18 schrieb Tony Lindgren <tony@atomide.com>: >>> >>> * H. Nikolaus Schaller <hns@goldelico.com> [171128 16:17]: >>>> Hi Tony, >>>> >>>>> Am 28.11.2017 um 17:04 schrieb Tony Lindgren <tony@atomide.com>: >>>>> >>>>> * H. Nikolaus Schaller <hns@goldelico.com> [171128 15:52]: >>>>>> We can remove the unnecessary "omapdss," prefix because >>>>>> the omapdrm driver takes care of it when matching with >>>>>> the driver table. >>>>> >>>>> So is this needed as a fix or is this another clean-up? >>>>> >>>>> So is this is really needed as a fix? >>>> >>>> Hm. How do you differentiate between "fix" and "cleanup"? >>>> Maybe it is more a wording than a content issue... >>>> >>>> For me it is a "fix" because it is semantically wrong to have >>>> a prefix where it is not needed. And "fixing" it changes the >>>> compiler output by 8 bytes. >>> >>> How about let's call it a "typo fix" then? :) >> >> Well, it is not really a typo. > > Well what if the stable people pick it into earlier stable series > based on the word fix in the subject? That has happened before. Well, that may happen but IMHO *every* such backport must be checked for reasonability and compatibility and sometimes even modified to apply. And I think the author of the original patch receives a notification from the stable maintainers and can then veto. For Example I received "[PATCH 4.7 118/186] w1:omap_hdq: fix regression" "4.7-stable review patch. If anyone has any objections, please let me know." If that process still fails, we simply have to revert it... Has also happened before. So it will not be end of mankind :) > > I suggest you update the dts patches to use wording like > "update compatible to use new naming" or something similar. I have applied s/fix/improve/ for patch 3/4 and left 4/4 as suggested by Sebastian since it is really a strongly suggested correction. Since Tomi has already accepted the underlaying driver patch, [PATCH v4] will only have the remaining DTS patches. BR and thanks, Nikolaus
On 01/12/17 00:06, Sebastian Reichel wrote: >>>> How about let's call it a "typo fix" then? :) >>> >>> Well, it is not really a typo. >> >> Well what if the stable people pick it into earlier stable series >> based on the word fix in the subject? That has happened before. >> >> I suggest you update the dts patches to use wording like >> "update compatible to use new naming" or something similar. > > Patch 4/4 is a Fix and should be applied to stable trees. "omapdss," > prefix was never supposed to be in the DTS files, is not supposed to > be in there now and will break some time in the future. > > Explanation: The early init of omapdss adds the prefix at runtime, > so that the binding can use generic properties and the kernel can > use omapdss specific drivers until the generic ones can be used This is true, but the extra "omapdss" does not cause any issues at the moment, and the time when it causes issues is still many kernel versions in the future. But, yes, thinking about this, I agree, it's better to pick this one separately as a fix (after rebasing it on top of current maineline so that it doesn't depend on the toppoly name change), and leaving the toppoly->tpo change as a cleanup.
Hi Tomi, > Am 01.12.2017 um 09:13 schrieb Tomi Valkeinen <tomi.valkeinen@ti.com>: > > On 01/12/17 00:06, Sebastian Reichel wrote: > >>>>> How about let's call it a "typo fix" then? :) >>>> >>>> Well, it is not really a typo. >>> >>> Well what if the stable people pick it into earlier stable series >>> based on the word fix in the subject? That has happened before. >>> >>> I suggest you update the dts patches to use wording like >>> "update compatible to use new naming" or something similar. >> >> Patch 4/4 is a Fix and should be applied to stable trees. "omapdss," >> prefix was never supposed to be in the DTS files, is not supposed to >> be in there now and will break some time in the future. >> >> Explanation: The early init of omapdss adds the prefix at runtime, >> so that the binding can use generic properties and the kernel can >> use omapdss specific drivers until the generic ones can be used > > This is true, but the extra "omapdss" does not cause any issues at the > moment, and the time when it causes issues is still many kernel versions > in the future. > > But, yes, thinking about this, I agree, it's better to pick this one > separately as a fix (after rebasing it on top of current maineline so > that it doesn't depend on the toppoly name change), and leaving the > toppoly->tpo change as a cleanup. Just a note: there is no toppoly->tpo change for *this* panel and Pandora board. Just omapdss removal. The GTA04 needs a toppoly->tpo change but no omapdss, removal. So they solve different problems and are independent of each other. GTA04: change vendor string Pandora: remove omapdss, prefix BR and thanks, Nikolaus
On 01/12/17 11:48, H. Nikolaus Schaller wrote: > Just a note: there is no toppoly->tpo change for *this* panel and > Pandora board. Just omapdss removal. > > The GTA04 needs a toppoly->tpo change but no omapdss, removal. > > So they solve different problems and are independent of each other. > > GTA04: change vendor string > Pandora: remove omapdss, prefix Oh, right, I totally missed that. I thought they were changes to the same file... In that case, Tony, can you pick this one as a fix? I'll pick the toppoly->tpo patch and merge via drm tree, if you give the ack. For this: Acked-by: Tomi Valkeinen <tomi.valkeinen@ti.com> Tomi
* Tomi Valkeinen <tomi.valkeinen@ti.com> [171201 02:03]: > On 01/12/17 11:48, H. Nikolaus Schaller wrote: > > > Just a note: there is no toppoly->tpo change for *this* panel and > > Pandora board. Just omapdss removal. > > > > The GTA04 needs a toppoly->tpo change but no omapdss, removal. > > > > So they solve different problems and are independent of each other. > > > > GTA04: change vendor string > > Pandora: remove omapdss, prefix > > Oh, right, I totally missed that. I thought they were changes to the > same file... > > In that case, Tony, can you pick this one as a fix? I'll pick the > toppoly->tpo patch and merge via drm tree, if you give the ack. > > For this: > > Acked-by: Tomi Valkeinen <tomi.valkeinen@ti.com> Sorry I've lost track of this thread and what if anything is really needed as a fix for v4.16. And now there's newer version of the two dts patches in thread "[PATCH v4 0/2] Fixes for omapdrm on OpenPandora and GTA04" so let's move the discussion there. Regards, Tony
diff --git a/arch/arm/boot/dts/omap3-pandora-common.dtsi b/arch/arm/boot/dts/omap3-pandora-common.dtsi index 53e007abdc71..64d967ec8c58 100644 --- a/arch/arm/boot/dts/omap3-pandora-common.dtsi +++ b/arch/arm/boot/dts/omap3-pandora-common.dtsi @@ -626,7 +626,7 @@ lcd: lcd@1 { reg = <1>; /* CS1 */ - compatible = "omapdss,tpo,td043mtea1"; + compatible = "tpo,td043mtea1"; spi-max-frequency = <100000>; spi-cpol; spi-cpha;
We can remove the unnecessary "omapdss," prefix because the omapdrm driver takes care of it when matching with the driver table. Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com> --- arch/arm/boot/dts/omap3-pandora-common.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)