| Message ID | 1512188864-773-3-git-send-email-okaya@codeaurora.org (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
On Sat, Dec 2, 2017 at 5:27 AM, Sinan Kaya <okaya@codeaurora.org> wrote: > OF has of_device_get_match_data() function to extract driver specific data > structure. Add a similar function for ACPI. > > Signed-off-by: Sinan Kaya <okaya@codeaurora.org> Haven't I ACKed this already? Anyway, please resend the whole series with a CC to linux-acpi. Thanks, Rafael -- To unsubscribe from this list: send the line "unsubscribe dmaengine" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 12/4/2017 4:59 PM, Rafael J. Wysocki wrote: > On Sat, Dec 2, 2017 at 5:27 AM, Sinan Kaya <okaya@codeaurora.org> wrote: >> OF has of_device_get_match_data() function to extract driver specific data >> structure. Add a similar function for ACPI. >> >> Signed-off-by: Sinan Kaya <okaya@codeaurora.org> > > Haven't I ACKed this already? > > Anyway, please resend the whole series with a CC to linux-acpi. Yeah, you acked the previous one. Then, I changed the calling parameter from struct device to struct acpi_device and removed your ACK.
diff --git a/drivers/acpi/bus.c b/drivers/acpi/bus.c index 4d0979e..05d8d9a 100644 --- a/drivers/acpi/bus.c +++ b/drivers/acpi/bus.c @@ -785,6 +785,19 @@ const struct acpi_device_id *acpi_match_device(const struct acpi_device_id *ids, } EXPORT_SYMBOL_GPL(acpi_match_device); +void *acpi_get_match_data(struct acpi_device *device, + const struct acpi_device_id *ids) +{ + const struct acpi_device_id *match; + + match = __acpi_match_device(device, ids, NULL); + if (!match) + return NULL; + + return (void *)match->driver_data; +} +EXPORT_SYMBOL_GPL(acpi_get_match_data); + int acpi_match_device_ids(struct acpi_device *device, const struct acpi_device_id *ids) { diff --git a/include/linux/acpi.h b/include/linux/acpi.h index 502af53..196bc7a 100644 --- a/include/linux/acpi.h +++ b/include/linux/acpi.h @@ -584,6 +584,8 @@ extern int acpi_nvs_for_each_region(int (*func)(__u64, __u64, void *), const struct acpi_device_id *acpi_match_device(const struct acpi_device_id *ids, const struct device *dev); +void *acpi_get_match_data(struct acpi_device *device, + const struct acpi_device_id *ids); extern bool acpi_driver_match_device(struct device *dev, const struct device_driver *drv); int acpi_device_uevent_modalias(struct device *, struct kobj_uevent_env *); @@ -755,6 +757,12 @@ static inline const struct acpi_device_id *acpi_match_device( return NULL; } +static inline void *acpi_get_match_data(struct acpi_device *device, + const struct acpi_device_id *ids) +{ + return NULL; +} + static inline bool acpi_driver_match_device(struct device *dev, const struct device_driver *drv) {
OF has of_device_get_match_data() function to extract driver specific data structure. Add a similar function for ACPI. Signed-off-by: Sinan Kaya <okaya@codeaurora.org> --- drivers/acpi/bus.c | 13 +++++++++++++ include/linux/acpi.h | 8 ++++++++ 2 files changed, 21 insertions(+)