diff mbox

[4/4] spi: sh-msiof: Document hardware limitations related to chip selects

Message ID 1513191913-10612-5-git-send-email-geert+renesas@glider.be (mailing list archive)
State Accepted
Commit c99182f73cce7926c623b5c1c0ff0b7954ac8d81
Headers show

Commit Message

Geert Uytterhoeven Dec. 13, 2017, 7:05 p.m. UTC
Guide users to maintain the proper balance between native and GPIO chip
selects.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 Documentation/devicetree/bindings/spi/sh-msiof.txt | 10 ++++++++++
 1 file changed, 10 insertions(+)

Comments

Mark Brown Dec. 14, 2017, 11:45 a.m. UTC | #1
On Wed, Dec 13, 2017 at 08:05:13PM +0100, Geert Uytterhoeven wrote:

> +			 Hardware limitations related to chip selects:
> +			   - Native chip selects are always deasserted in
> +			     between transfers that are part of the same
> +			     message.  Use cs-gpios to work around this.

Ideally the driver would be generating an error when it sees
multi-transfer messages.
diff mbox

Patch

diff --git a/Documentation/devicetree/bindings/spi/sh-msiof.txt b/Documentation/devicetree/bindings/spi/sh-msiof.txt
index bc8c16a6cfc82685..80710f0f04489174 100644
--- a/Documentation/devicetree/bindings/spi/sh-msiof.txt
+++ b/Documentation/devicetree/bindings/spi/sh-msiof.txt
@@ -41,6 +41,16 @@  Optional properties:
 			   0: MSIOF_SYNC
 			   1: MSIOF_SS1
 			   2: MSIOF_SS2
+			 Hardware limitations related to chip selects:
+			   - Native chip selects are always deasserted in
+			     between transfers that are part of the same
+			     message.  Use cs-gpios to work around this.
+			   - All slaves using native chip selects must use the
+			     same spi-cs-high configuration.  Use cs-gpios to
+			     work around this.
+			   - When using GPIO chip selects, at least one native
+			     chip select must be left unused, as it will be
+			     driven anyway.
 - dmas                 : Must contain a list of two references to DMA
 			 specifiers, one for transmission, and one for
 			 reception.