diff mbox

[1/2] serial: stm32: add default console

Message ID 1512146211-29086-2-git-send-email-ludovic.Barre@st.com (mailing list archive)
State New, archived
Headers show

Commit Message

Ludovic BARRE Dec. 1, 2017, 4:36 p.m. UTC 
From: Ludovic Barre <ludovic.barre@st.com>

This patch adds by default the console support
on stm32.

Signed-off-by: Ludovic Barre <ludovic.barre@st.com>
---
 drivers/tty/serial/Kconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

Greg KH Dec. 15, 2017, 7:25 p.m. UTC | #1 
On Fri, Dec 01, 2017 at 05:36:50PM +0100, Ludovic Barre wrote:
> From: Ludovic Barre <ludovic.barre@st.com>
> 
> This patch adds by default the console support
> on stm32.

Why?  'default y' should only mean "machine will not boot without this".
And I think your machine will boot without the console, right?  :)

thanks,

greg k-h
Ludovic BARRE Dec. 18, 2017, 8:31 a.m. UTC | #2 
hi Greg

Yes, the machine could be boot without console. but our
boards has a console by default. it is just to simplified the
configuration.
you can abandoned this patch, if you prefer.

BR
Ludo

On 12/15/2017 08:25 PM, Greg Kroah-Hartman wrote:
> On Fri, Dec 01, 2017 at 05:36:50PM +0100, Ludovic Barre wrote:
>> From: Ludovic Barre <ludovic.barre@st.com>
>>
>> This patch adds by default the console support
>> on stm32.
> 
> Why?  'default y' should only mean "machine will not boot without this".
> And I think your machine will boot without the console, right?  :)
> 
> thanks,
> 
> greg k-h
>
diff mbox

Patch

diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig
index b788fee..969e598 100644
--- a/drivers/tty/serial/Kconfig
+++ b/drivers/tty/serial/Kconfig
@@ -1664,6 +1664,7 @@  config SERIAL_STM32_CONSOLE
 	bool "Support for console on STM32"
 	depends on SERIAL_STM32=y
 	select SERIAL_CORE_CONSOLE
+	default y
 
 config SERIAL_MVEBU_UART
 	bool "Marvell EBU serial port support"