| Message ID | 20171213125816.18371-3-petri.latvala@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Quoting Petri Latvala (2017-12-13 12:58:14) > Since the test is considered to be HW focused, meaning that it doesn't > really exercise the driver but rather an HW feature, it is placed in > tests/hw-tests. Do we really want to keep this test at all? It's an interesting debate whether we want to show how trivial it is to subvert the kernel and HW (in some circumstances). -Chris
On 13/12/17 05:26, Chris Wilson wrote: > Quoting Petri Latvala (2017-12-13 12:58:14) >> Since the test is considered to be HW focused, meaning that it doesn't >> really exercise the driver but rather an HW feature, it is placed in >> tests/hw-tests. > > Do we really want to keep this test at all? It's an interesting debate This test has been around for a long time now so I think keeping it around would not be a problem, plus it actually gets fixed in this series. -Antonio > whether we want to show how trivial it is to subvert the kernel and HW > (in some circumstances). > -Chris > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx >
diff --git a/tests/Makefile.sources b/tests/Makefile.sources index e4e06d01..29dfd9cd 100644 --- a/tests/Makefile.sources +++ b/tests/Makefile.sources @@ -264,7 +264,6 @@ HANG = \ gem_bad_batch \ gem_hang \ gem_bad_blit \ - gem_bad_address \ gem_non_secure_batch \ $(NULL) diff --git a/tests/hw-tests/Makefile.sources b/tests/hw-tests/Makefile.sources index a224da7c..1fb3ed9e 100644 --- a/tests/hw-tests/Makefile.sources +++ b/tests/hw-tests/Makefile.sources @@ -1,2 +1,3 @@ hw_tests = \ + gem_bad_address \ $(NULL) diff --git a/tests/gem_bad_address.c b/tests/hw-tests/gem_bad_address.c similarity index 100% rename from tests/gem_bad_address.c rename to tests/hw-tests/gem_bad_address.c diff --git a/tests/hw-tests/meson.build b/tests/hw-tests/meson.build index 32bb637d..848d113e 100644 --- a/tests/hw-tests/meson.build +++ b/tests/hw-tests/meson.build @@ -1,4 +1,5 @@ hw_test_progs = [ + 'gem_bad_address', ] hw_test_deps = [ igt_deps ] diff --git a/tests/meson.build b/tests/meson.build index 8ab16a70..5eef1bd6 100644 --- a/tests/meson.build +++ b/tests/meson.build @@ -301,7 +301,6 @@ hang_progs = [ 'gem_bad_batch', 'gem_hang', 'gem_bad_blit', - 'gem_bad_address', 'gem_non_secure_batch', ] foreach prog : hang_progs
Since the test is considered to be HW focused, meaning that it doesn't really exercise the driver but rather an HW feature, it is placed in tests/hw-tests. Signed-off-by: Petri Latvala <petri.latvala@intel.com> Cc: Antonio Argenziano <antonio.argenziano@intel.com> --- tests/Makefile.sources | 1 - tests/hw-tests/Makefile.sources | 1 + tests/{ => hw-tests}/gem_bad_address.c | 0 tests/hw-tests/meson.build | 1 + tests/meson.build | 1 - 5 files changed, 2 insertions(+), 2 deletions(-) rename tests/{ => hw-tests}/gem_bad_address.c (100%)