diff mbox

[resend] examples: fix duplex comparison against best port

Message ID 272c39d5bbc396b421d62030c5cb69d9b749fee3.1513600551.git.mleitner@redhat.com (mailing list archive)
State Accepted
Headers show

Commit Message

Marcelo Ricardo Leitner Dec. 18, 2017, 12:43 p.m. UTC 
Signed-off-by: Marcelo Ricardo Leitner <mleitner@redhat.com>

---
 examples/python/team_daemon.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.14.3

Comments

Marcelo Ricardo Leitner Dec. 18, 2017, 12:45 p.m. UTC | #1 
On Mon, Dec 18, 2017 at 10:43:44AM -0200, Marcelo Ricardo Leitner wrote:

The same patch, sent to the list, doesn't apply, but sent only to me,
applies. Hmmmm..
Marcelo Ricardo Leitner Dec. 18, 2017, 12:51 p.m. UTC | #2 
On Mon, Dec 18, 2017 at 10:49:15AM -0200, Marcelo Ricardo Leitner wrote:
> Signed-off-by: Marcelo Ricardo Leitner <mleitner@redhat.com>

> ---

> 

> Jiri, sending this one directly to you. You may see how the version that

> was sent to the list got a base64 encoding and this one not. Although,

> after deconding, the patches look like the same.

> 

> I hope this one works.


Forgot to update the message-id, sorry.

  Marcelo
diff mbox

Patch

diff --git a/examples/python/team_daemon.py b/examples/python/team_daemon.py
index 476306ef9b248dc23df5212311c8289d6a334e2d..2d2a74f2f96151465b31c38e961faaf922fbcafc 100755
--- a/examples/python/team_daemon.py
+++ b/examples/python/team_daemon.py
@@ -146,7 +146,7 @@  class TeamDaemon(object):
             if port.linkup:
                 if (not best or
                     port.speed > best.speed or
-                    (port.speed == best.speed and port.duplex > port.duplex)):
+                    (port.speed == best.speed and port.duplex > best.duplex)):
                     best = port
         if best:
             self._change_active_port(active, best)