diff mbox

[RFC] OMAP4: I2C : I2C context save

Message ID 1309857646-29401-1-git-send-email-shubhrajyoti@ti.com (mailing list archive)
State New, archived
Headers show

Commit Message

Shubhrajyoti Datta July 5, 2011, 9:20 a.m. UTC
Currently the OMAP4 doesnot hit device off still the
driver may have support for it.Adding support for the
same.

Signed-off-by: Shubhrajyoti D <shubhrajyoti@ti.com>
---
Applies on top of patches from Andy Green
http://www.spinics.net/lists/linux-i2c/msg05632.html
Tested on OMAP4430

 arch/arm/mach-omap2/omap_hwmod_44xx_data.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

Comments

Ben Dooks July 13, 2011, 7:07 p.m. UTC | #1
On Tue, Jul 05, 2011 at 02:50:46PM +0530, Shubhrajyoti D wrote:
> Currently the OMAP4 doesnot hit device off still the
> driver may have support for it.Adding support for the
> same.
> 
> Signed-off-by: Shubhrajyoti D <shubhrajyoti@ti.com>

I guess since the previous set has been taken by Kevin
then these will be too.

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Kevin Hilman July 13, 2011, 9:15 p.m. UTC | #2
Ben Dooks <ben-i2c@fluff.org> writes:

> On Tue, Jul 05, 2011 at 02:50:46PM +0530, Shubhrajyoti D wrote:
>> Currently the OMAP4 doesnot hit device off still the
>> driver may have support for it.Adding support for the
>> same.
>> 
>> Signed-off-by: Shubhrajyoti D <shubhrajyoti@ti.com>
>
> I guess since the previous set has been taken by Kevin
> then these will be too.

Sure, I'll pick these up, but it's probably to late for v3.1.

We've already submitted the bulk of the OMAP stuff for v3.1.

Kevin
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Kevin Hilman July 13, 2011, 9:27 p.m. UTC | #3
On Wed, Jul 13, 2011 at 2:15 PM, Kevin Hilman <khilman@ti.com> wrote:
> Ben Dooks <ben-i2c@fluff.org> writes:
>
>> On Tue, Jul 05, 2011 at 02:50:46PM +0530, Shubhrajyoti D wrote:
>>> Currently the OMAP4 doesnot hit device off still the
>>> driver may have support for it.Adding support for the
>>> same.
>>>
>>> Signed-off-by: Shubhrajyoti D <shubhrajyoti@ti.com>
>>
>> I guess since the previous set has been taken by Kevin
>> then these will be too.
>
> Sure, I'll pick these up, but it's probably to late for v3.1.
>
> We've already submitted the bulk of the OMAP stuff for v3.1.

I should've also said I'll pick these up when they are ready.  There
are still some comments that need addressing.

Kevin
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Shubhrajyoti Datta July 14, 2011, 10:53 a.m. UTC | #4
On Thursday 14 July 2011 02:57 AM, Hilman, Kevin wrote:
> On Wed, Jul 13, 2011 at 2:15 PM, Kevin Hilman<khilman@ti.com>  wrote:
>> Ben Dooks<ben-i2c@fluff.org>  writes:
>>
>>> On Tue, Jul 05, 2011 at 02:50:46PM +0530, Shubhrajyoti D wrote:
>>>> Currently the OMAP4 doesnot hit device off still the
>>>> driver may have support for it.Adding support for the
>>>> same.
>>>>
>>>> Signed-off-by: Shubhrajyoti D<shubhrajyoti@ti.com>
>>> I guess since the previous set has been taken by Kevin
>>> then these will be too.
>> Sure, I'll pick these up, but it's probably to late for v3.1.
>>
>> We've already submitted the bulk of the OMAP stuff for v3.1.
Kevin in the folowing I tried taking the comments do do have any
further comments or suggestions.

http://www.spinics.net/lists/linux-i2c/msg05823.html

> I should've also said I'll pick these up when they are ready.  There
> are still some comments that need addressing.
>
> Kevin

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Kevin Hilman July 14, 2011, 3:38 p.m. UTC | #5
Shubhrajyoti <shubhrajyoti@ti.com> writes:

> On Thursday 14 July 2011 02:57 AM, Hilman, Kevin wrote:
>> On Wed, Jul 13, 2011 at 2:15 PM, Kevin Hilman<khilman@ti.com>  wrote:
>>> Ben Dooks<ben-i2c@fluff.org>  writes:
>>>
>>>> On Tue, Jul 05, 2011 at 02:50:46PM +0530, Shubhrajyoti D wrote:
>>>>> Currently the OMAP4 doesnot hit device off still the
>>>>> driver may have support for it.Adding support for the
>>>>> same.
>>>>>
>>>>> Signed-off-by: Shubhrajyoti D<shubhrajyoti@ti.com>
>>>> I guess since the previous set has been taken by Kevin
>>>> then these will be too.
>>> Sure, I'll pick these up, but it's probably to late for v3.1.
>>>
>>> We've already submitted the bulk of the OMAP stuff for v3.1.
> Kevin in the folowing I tried taking the comments do do have any
> further comments or suggestions.
>
> http://www.spinics.net/lists/linux-i2c/msg05823.html

Sorry, my ti.com email got unsubscribed from vger lists for a couple
days around July 5 & 6, so I missed that one.

It's always best to directly Cc people you are expecting to get review
comments from.

I'll reply to your updated one shortly.

Kevin
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/arch/arm/mach-omap2/omap_hwmod_44xx_data.c b/arch/arm/mach-omap2/omap_hwmod_44xx_data.c
index 0fe9556..5e2c748 100644
--- a/arch/arm/mach-omap2/omap_hwmod_44xx_data.c
+++ b/arch/arm/mach-omap2/omap_hwmod_44xx_data.c
@@ -2130,7 +2130,8 @@  static struct omap_hwmod_class omap44xx_i2c_hwmod_class = {
 };
 
 static struct omap_i2c_dev_attr i2c_dev_attr = {
-	.flags  = OMAP_I2C_FLAG_BUS_SHIFT_NONE,
+	.flags  = OMAP_I2C_FLAG_BUS_SHIFT_NONE |
+			OMAP_I2C_FLAG_RESET_REGS_POSTIDLE,
 };
 
 /* i2c1 */