| Message ID | 20171219092246.3usg5mdyi27ivqlq@valkosipuli.retiisi.org.uk (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Sakari, > -----Original Message----- > From: Sakari Ailus [mailto:sakari.ailus@iki.fi] > Sent: 2017年12月19日 17:23 > To: Wenyou Yang - A41535 <Wenyou.Yang@microchip.com> > Cc: Mauro Carvalho Chehab <mchehab@s-opensource.com>; Rob Herring > <robh+dt@kernel.org>; Mark Rutland <mark.rutland@arm.com>; linux- > kernel@vger.kernel.org; Nicolas Ferre - M43238 <Nicolas.Ferre@microchip.com>; > devicetree@vger.kernel.org; Jonathan Corbet <corbet@lwn.net>; Hans Verkuil > <hverkuil@xs4all.nl>; linux-arm-kernel@lists.infradead.org; Linux Media Mailing List > <linux-media@vger.kernel.org>; Songjun Wu <songjun.wu@microchip.com> > Subject: Re: [PATCH v9 2/2] media: i2c: Add the ov7740 image sensor driver > > On Mon, Dec 11, 2017 at 09:31:46AM +0800, Wenyou Yang wrote: > > The ov7740 (color) image sensor is a high performance VGA CMOS image > > snesor, which supports for output formats: RAW RGB and YUV and image > > sizes: VGA, and QVGA, CIF and any size smaller. > > > > Signed-off-by: Songjun Wu <songjun.wu@microchip.com> > > Signed-off-by: Wenyou Yang <wenyou.yang@microchip.com> > > Applied with this diff: Thank you very much. > > diff --git a/drivers/media/i2c/ov7740.c b/drivers/media/i2c/ov7740.c index > 0308ba437bbb..041a77039d70 100644 > --- a/drivers/media/i2c/ov7740.c > +++ b/drivers/media/i2c/ov7740.c > @@ -1,5 +1,7 @@ > -// SPDX-License-Identifier: GPL-2.0 > -// Copyright (c) 2017 Microchip Corporation. > +/* > + * SPDX-License-Identifier: GPL-2.0 > + * Copyright (c) 2017 Microchip Corporation. > + */ > > #include <linux/clk.h> > #include <linux/delay.h> > > -- > Sakari Ailus > e-mail: sakari.ailus@iki.fi Best Regards, Wenyou Yang
Hi Sakari, On Tue, Dec 19, 2017 at 7:22 AM, Sakari Ailus <sakari.ailus@iki.fi> wrote: > On Mon, Dec 11, 2017 at 09:31:46AM +0800, Wenyou Yang wrote: >> The ov7740 (color) image sensor is a high performance VGA CMOS >> image snesor, which supports for output formats: RAW RGB and YUV >> and image sizes: VGA, and QVGA, CIF and any size smaller. >> >> Signed-off-by: Songjun Wu <songjun.wu@microchip.com> >> Signed-off-by: Wenyou Yang <wenyou.yang@microchip.com> > > Applied with this diff: > > diff --git a/drivers/media/i2c/ov7740.c b/drivers/media/i2c/ov7740.c > index 0308ba437bbb..041a77039d70 100644 > --- a/drivers/media/i2c/ov7740.c > +++ b/drivers/media/i2c/ov7740.c > @@ -1,5 +1,7 @@ > -// SPDX-License-Identifier: GPL-2.0 > -// Copyright (c) 2017 Microchip Corporation. > +/* > + * SPDX-License-Identifier: GPL-2.0 > + * Copyright (c) 2017 Microchip Corporation. > + */ The original version is the recommended format for the SPDX identifier.
On Tue, Dec 19, 2017 at 10:50:44AM -0200, Fabio Estevam wrote: > Hi Sakari, > > On Tue, Dec 19, 2017 at 7:22 AM, Sakari Ailus <sakari.ailus@iki.fi> wrote: > > On Mon, Dec 11, 2017 at 09:31:46AM +0800, Wenyou Yang wrote: > >> The ov7740 (color) image sensor is a high performance VGA CMOS > >> image snesor, which supports for output formats: RAW RGB and YUV > >> and image sizes: VGA, and QVGA, CIF and any size smaller. > >> > >> Signed-off-by: Songjun Wu <songjun.wu@microchip.com> > >> Signed-off-by: Wenyou Yang <wenyou.yang@microchip.com> > > > > Applied with this diff: > > > > diff --git a/drivers/media/i2c/ov7740.c b/drivers/media/i2c/ov7740.c > > index 0308ba437bbb..041a77039d70 100644 > > --- a/drivers/media/i2c/ov7740.c > > +++ b/drivers/media/i2c/ov7740.c > > @@ -1,5 +1,7 @@ > > -// SPDX-License-Identifier: GPL-2.0 > > -// Copyright (c) 2017 Microchip Corporation. > > +/* > > + * SPDX-License-Identifier: GPL-2.0 > > + * Copyright (c) 2017 Microchip Corporation. > > + */ > > The original version is the recommended format for the SPDX identifier. I guess it depends on who do you ask and when. Looking at what has been recently merged to media tree master, the latter is preferred.
Hi Sakari, On Tue, Dec 19, 2017 at 11:05 AM, Sakari Ailus <sakari.ailus@iki.fi> wrote: > I guess it depends on who do you ask and when. Looking at what has been > recently merged to media tree master, the latter is preferred. Just did 'git grep SPDX drivers/media' and it consistently shows // SPDX style for C files.
On Tue, Dec 19, 2017 at 11:19:06AM -0200, Fabio Estevam wrote: > Hi Sakari, > > On Tue, Dec 19, 2017 at 11:05 AM, Sakari Ailus <sakari.ailus@iki.fi> wrote: > > > I guess it depends on who do you ask and when. Looking at what has been > > recently merged to media tree master, the latter is preferred. > > Just did 'git grep SPDX drivers/media' > > and it consistently shows // SPDX style for C files. Both seem to exist. See e.g. c3a3d1d6b8b363a02234e5564692db3647f183e6 .
On Tue, Dec 19, 2017 at 11:43 AM, Sakari Ailus <sakari.ailus@iki.fi> wrote:
> Both seem to exist. See e.g. c3a3d1d6b8b363a02234e5564692db3647f183e6 .
This patch fixes .h files to use /* SPDX style comment, which is the
recommendation.
.c files should use // SPDX style.
On Tue, Dec 19, 2017 at 12:31:46PM -0200, Fabio Estevam wrote: > On Tue, Dec 19, 2017 at 11:43 AM, Sakari Ailus <sakari.ailus@iki.fi> wrote: > > > Both seem to exist. See e.g. c3a3d1d6b8b363a02234e5564692db3647f183e6 . > > This patch fixes .h files to use /* SPDX style comment, which is the > recommendation. > > .c files should use // SPDX style. Agreed. I reverted the changes. Thanks.
diff --git a/drivers/media/i2c/ov7740.c b/drivers/media/i2c/ov7740.c index 0308ba437bbb..041a77039d70 100644 --- a/drivers/media/i2c/ov7740.c +++ b/drivers/media/i2c/ov7740.c @@ -1,5 +1,7 @@ -// SPDX-License-Identifier: GPL-2.0 -// Copyright (c) 2017 Microchip Corporation. +/* + * SPDX-License-Identifier: GPL-2.0 + * Copyright (c) 2017 Microchip Corporation. + */ #include <linux/clk.h> #include <linux/delay.h>