| Message ID | 20171205162046.11621-1-l.stelmach@samsung.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
Am Dienstag, 5. Dezember 2017, 17:20:46 CET schrieb Łukasz Stelmach: Hi Łukasz, > exynos-rng is one of many implementations of stdrng. With priority as > low as 100 it isn't selected, if software implementations (DRBG) are > available. The value 300 was selected to give the PRNG priority before > software implementations, but allow them to be selected in FIPS-mode > (fips=1 in the kernel command line). > > Signed-off-by: Łukasz Stelmach <l.stelmach@samsung.com> Reviewed-by: Stephan Mueller <smueller@chronox.de> Ciao Stephan -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, Dec 05, 2017 at 05:20:46PM +0100, Łukasz Stelmach wrote: > exynos-rng is one of many implementations of stdrng. With priority as > low as 100 it isn't selected, if software implementations (DRBG) are > available. The value 300 was selected to give the PRNG priority before > software implementations, but allow them to be selected in FIPS-mode > (fips=1 in the kernel command line). Typo in subject ("Increase"). Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org> Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, Dec 05, 2017 at 05:20:46PM +0100, Łukasz Stelmach wrote: > exynos-rng is one of many implementations of stdrng. With priority as > low as 100 it isn't selected, if software implementations (DRBG) are > available. The value 300 was selected to give the PRNG priority before > software implementations, but allow them to be selected in FIPS-mode > (fips=1 in the kernel command line). > > Signed-off-by: Łukasz Stelmach <l.stelmach@samsung.com> Patch applied. Thanks.
diff --git a/drivers/crypto/exynos-rng.c b/drivers/crypto/exynos-rng.c index 4b2ed1d178af..5a37397fb1c5 100644 --- a/drivers/crypto/exynos-rng.c +++ b/drivers/crypto/exynos-rng.c @@ -256,7 +256,7 @@ static struct rng_alg exynos_rng_alg = { .base = { .cra_name = "stdrng", .cra_driver_name = "exynos_rng", - .cra_priority = 100, + .cra_priority = 300, .cra_ctxsize = sizeof(struct exynos_rng_ctx), .cra_module = THIS_MODULE, .cra_init = exynos_rng_kcapi_init,
exynos-rng is one of many implementations of stdrng. With priority as low as 100 it isn't selected, if software implementations (DRBG) are available. The value 300 was selected to give the PRNG priority before software implementations, but allow them to be selected in FIPS-mode (fips=1 in the kernel command line). Signed-off-by: Łukasz Stelmach <l.stelmach@samsung.com> --- Thank you Stephan Mueller for explanations. drivers/crypto/exynos-rng.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)