| Message ID | 20171224144911.29064-1-rhyskidd@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Sun, Dec 24, 2017 at 6:49 AM, Rhys Kidd <rhyskidd@gmail.com> wrote: > warning() needs that, which was introduced in a 865a47ca failure path. > > Otherwise we get error messages on that failure path like: > ... > Program leg found: NO > > Meson encountered an error in file overlay/meson.build, line 62, column 1: > Unknown function "warning". > FAILED: build.ninja > ... > > Fixes: 865a47ca ("overlay: parse tracepoints from sysfs to figure out fields' location") > Signed-off-by: Rhys Kidd <rhyskidd@gmail.com> I just had this error and prepared a patch to do the other way around: use message() rather than warning(). I think we could delay raising the dependency to the latest meson version.... on Fedora 27 for example we have meson 0.43 available, not 0.44 (although we could install 0.44 from pypi). I'm not sure which one is best. Lucas De Marchi > --- > meson.build | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/meson.build b/meson.build > index 0950d3c7..20064ae1 100644 > --- a/meson.build > +++ b/meson.build > @@ -5,7 +5,7 @@ project('IGT gpu tests', 'c', > 'c_std=gnu99', > ], > license : 'MIT', > - meson_version : '>0.40.0') > + meson_version : '>=0.44.0') > > cc = meson.get_compiler('c') > > -- > 2.14.1 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
diff --git a/meson.build b/meson.build index 0950d3c7..20064ae1 100644 --- a/meson.build +++ b/meson.build @@ -5,7 +5,7 @@ project('IGT gpu tests', 'c', 'c_std=gnu99', ], license : 'MIT', - meson_version : '>0.40.0') + meson_version : '>=0.44.0') cc = meson.get_compiler('c')
warning() needs that, which was introduced in a 865a47ca failure path. Otherwise we get error messages on that failure path like: ... Program leg found: NO Meson encountered an error in file overlay/meson.build, line 62, column 1: Unknown function "warning". FAILED: build.ninja ... Fixes: 865a47ca ("overlay: parse tracepoints from sysfs to figure out fields' location") Signed-off-by: Rhys Kidd <rhyskidd@gmail.com> --- meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)