diff mbox

[4/4] Drivers:iio:adc: else is not generally useful after a break or return

Message ID 1514566389-3485-1-git-send-email-venkat.prashanth2498@gmail.com (mailing list archive)
State New, archived
Headers show

Commit Message

venkat.prashanth2498@gmail.com Dec. 29, 2017, 4:53 p.m. UTC
From: Venkat Prashanth B U <venkat.prashanth2498@gmail.com>

Fixes checkpatch warnings:
WARNING: else is not generally useful after a break or return

Signed-off-by: Venkat Prashanth B U <venkat.prashanth2498@gmail.com>
---
 drivers/iio/adc/at91_adc.c | 1 -
 1 file changed, 1 deletion(-)

--
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Jonathan Cameron Dec. 29, 2017, 5:55 p.m. UTC | #1
On Fri, 29 Dec 2017 22:23:09 +0530
venkat.prashanth2498@gmail.com wrote:

> From: Venkat Prashanth B U <venkat.prashanth2498@gmail.com>
> 
> Fixes checkpatch warnings:
> WARNING: else is not generally useful after a break or return
> 
> Signed-off-by: Venkat Prashanth B U <venkat.prashanth2498@gmail.com>

Please then run checkpatch on the result + ideally sparse / smatch.

The result of this is wrong indentation.

Jonathan

> ---
>  drivers/iio/adc/at91_adc.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/iio/adc/at91_adc.c b/drivers/iio/adc/at91_adc.c
> index 7b40925..da18c04 100644
> --- a/drivers/iio/adc/at91_adc.c
> +++ b/drivers/iio/adc/at91_adc.c
> @@ -939,7 +939,6 @@ static int at91_adc_probe_dt(struct at91_adc_state *st,
>  	/* Check if touchscreen is supported. */
>  	if (st->caps->has_ts)
>  		return at91_adc_probe_dt_ts(node, st, &idev->dev);
> -	else
>  		dev_info(&idev->dev, "not support touchscreen in the adc compatible string.\n");
> 
>  	return 0;
> --
> 1.9.1
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/iio/adc/at91_adc.c b/drivers/iio/adc/at91_adc.c
index 7b40925..da18c04 100644
--- a/drivers/iio/adc/at91_adc.c
+++ b/drivers/iio/adc/at91_adc.c
@@ -939,7 +939,6 @@  static int at91_adc_probe_dt(struct at91_adc_state *st,
 	/* Check if touchscreen is supported. */
 	if (st->caps->has_ts)
 		return at91_adc_probe_dt_ts(node, st, &idev->dev);
-	else
 		dev_info(&idev->dev, "not support touchscreen in the adc compatible string.\n");

 	return 0;