| Message ID | 20171214173402.19074-14-srinivas.kandagatla@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Thu, Dec 14, 2017 at 05:34:00PM +0000, srinivas.kandagatla@linaro.org wrote: > From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> > > Add devicetree bindings documentation file for Qualcomm apq8096 sound card. > > Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> > --- > .../devicetree/bindings/sound/qcom,apq8096.txt | 22 ++++++++++++++++++++++ > 1 file changed, 22 insertions(+) > create mode 100644 Documentation/devicetree/bindings/sound/qcom,apq8096.txt > > diff --git a/Documentation/devicetree/bindings/sound/qcom,apq8096.txt b/Documentation/devicetree/bindings/sound/qcom,apq8096.txt > new file mode 100644 > index 000000000000..27b511dab533 > --- /dev/null > +++ b/Documentation/devicetree/bindings/sound/qcom,apq8096.txt > @@ -0,0 +1,22 @@ > +* Qualcomm Technologies APQ8096 ASoC sound card driver > + > +This binding describes the APQ8096 sound card, which uses qdsp for audio. > + > +- compatible: > + Usage: required > + Value type: <stringlist> > + Definition: must be "qcom,apq8096-sndcard" > + > +- qcom,audio-routing: > + Usage: Optional > + Value type: <stringlist> > + Definition: A list of the connections between audio components. > + Each entry is a pair of strings, the first being the > + connection's sink, the second being the connection's > + source. Valid names could be power supplies, MicBias > + of codec and the jacks on the board: > +Example: > + sound { > + compatible = "qcom,snd-apq8096"; > + qcom,model = "DB820c"; Not documented, but just use "model". This doesn't look complete. No codec, etc.? Rob
Thanks for your review comments. On 16/12/17 17:44, Rob Herring wrote: > On Thu, Dec 14, 2017 at 05:34:00PM +0000, srinivas.kandagatla@linaro.org wrote: >> From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> >> >> Add devicetree bindings documentation file for Qualcomm apq8096 sound card. >> >> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> >> --- >> .../devicetree/bindings/sound/qcom,apq8096.txt | 22 ++++++++++++++++++++++ >> 1 file changed, 22 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/sound/qcom,apq8096.txt >> >> diff --git a/Documentation/devicetree/bindings/sound/qcom,apq8096.txt b/Documentation/devicetree/bindings/sound/qcom,apq8096.txt >> new file mode 100644 >> index 000000000000..27b511dab533 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/sound/qcom,apq8096.txt >> @@ -0,0 +1,22 @@ >> +* Qualcomm Technologies APQ8096 ASoC sound card driver >> + >> +This binding describes the APQ8096 sound card, which uses qdsp for audio. >> + >> +- compatible: >> + Usage: required >> + Value type: <stringlist> >> + Definition: must be "qcom,apq8096-sndcard" >> + >> +- qcom,audio-routing: >> + Usage: Optional >> + Value type: <stringlist> >> + Definition: A list of the connections between audio components. >> + Each entry is a pair of strings, the first being the >> + connection's sink, the second being the connection's >> + source. Valid names could be power supplies, MicBias >> + of codec and the jacks on the board: >> +Example: >> + sound { >> + compatible = "qcom,snd-apq8096"; >> + qcom,model = "DB820c"; > > Not documented, but just use "model". Yep, I will use that in next version. > > This doesn't look complete. No codec, etc.? All the dai links are done in non-DT way directly in the sound card driver. Thanks, Srini > > Rob >
On Thu 14 Dec 09:34 PST 2017, srinivas.kandagatla@linaro.org wrote: > +++ b/Documentation/devicetree/bindings/sound/qcom,apq8096.txt Wouldn't it be possible to describe all(?) qdsp based machines in this one document? I.e. should we name it a little bit more generic? > @@ -0,0 +1,22 @@ > +* Qualcomm Technologies APQ8096 ASoC sound card driver > + > +This binding describes the APQ8096 sound card, which uses qdsp for audio. > + > +- compatible: > + Usage: required > + Value type: <stringlist> > + Definition: must be "qcom,apq8096-sndcard" > + > +- qcom,audio-routing: > + Usage: Optional > + Value type: <stringlist> > + Definition: A list of the connections between audio components. Double space before A > + Each entry is a pair of strings, the first being the > + connection's sink, the second being the connection's > + source. Valid names could be power supplies, MicBias > + of codec and the jacks on the board: > +Example: > + sound { > + compatible = "qcom,snd-apq8096"; Indentation > + qcom,model = "DB820c"; > + }; Regards, Bjorn
On 03/01/18 00:28, Bjorn Andersson wrote: > On Thu 14 Dec 09:34 PST 2017, srinivas.kandagatla@linaro.org wrote: > >> +++ b/Documentation/devicetree/bindings/sound/qcom,apq8096.txt > > Wouldn't it be possible to describe all(?) qdsp based machines in this > one document? I.e. should we name it a little bit more generic? You mean like downstream ? I see no harm in trying it out and see how it looks like. > >> @@ -0,0 +1,22 @@ >> +* Qualcomm Technologies APQ8096 ASoC sound card driver >> + >> +This binding describes the APQ8096 sound card, which uses qdsp for audio. >> + >> +- compatible: >> + Usage: required >> + Value type: <stringlist> >> + Definition: must be "qcom,apq8096-sndcard" >> + >> +- qcom,audio-routing: >> + Usage: Optional >> + Value type: <stringlist> >> + Definition: A list of the connections between audio components. > > Double space before A yep. > >> + Each entry is a pair of strings, the first being the >> + connection's sink, the second being the connection's >> + source. Valid names could be power supplies, MicBias >> + of codec and the jacks on the board: >> +Example: >> + sound { >> + compatible = "qcom,snd-apq8096"; > > Indentation yep. > >> + qcom,model = "DB820c"; >> + }; > > Regards, > Bjorn >
On Wed 03 Jan 08:27 PST 2018, Srinivas Kandagatla wrote: > > > On 03/01/18 00:28, Bjorn Andersson wrote: > > On Thu 14 Dec 09:34 PST 2017, srinivas.kandagatla@linaro.org wrote: > > > > > +++ b/Documentation/devicetree/bindings/sound/qcom,apq8096.txt > > > > Wouldn't it be possible to describe all(?) qdsp based machines in this > > one document? I.e. should we name it a little bit more generic? > > You mean like downstream ? > I mean that I'm guessing that apq8084, msm8994, msm8998 etc would come with the same binding document, but a different compatible. This is fine for now though, we can always rename the file and reword the description later. Regards, Bjorn
diff --git a/Documentation/devicetree/bindings/sound/qcom,apq8096.txt b/Documentation/devicetree/bindings/sound/qcom,apq8096.txt new file mode 100644 index 000000000000..27b511dab533 --- /dev/null +++ b/Documentation/devicetree/bindings/sound/qcom,apq8096.txt @@ -0,0 +1,22 @@ +* Qualcomm Technologies APQ8096 ASoC sound card driver + +This binding describes the APQ8096 sound card, which uses qdsp for audio. + +- compatible: + Usage: required + Value type: <stringlist> + Definition: must be "qcom,apq8096-sndcard" + +- qcom,audio-routing: + Usage: Optional + Value type: <stringlist> + Definition: A list of the connections between audio components. + Each entry is a pair of strings, the first being the + connection's sink, the second being the connection's + source. Valid names could be power supplies, MicBias + of codec and the jacks on the board: +Example: + sound { + compatible = "qcom,snd-apq8096"; + qcom,model = "DB820c"; + };