diff mbox

[v2,3/3] scsi: libsas: initialize sas_phy status according to response of DISCOVER

Message ID 20180104114741.37358-4-yanaijie@huawei.com (mailing list archive)
State Superseded
Headers show

Commit Message

Jason Yan Jan. 4, 2018, 11:47 a.m. UTC 
From: chenxiang <chenxiang66@hisilicon.com>

The status of SAS PHY is in sas_phy->enabled. There is an issue that the
status of a remote SAS PHY may be initialized incorrectly: if disable remote
SAS PHY through sysfs interface (such as echo 0 > /sys/class/sas_phy/phy-1:0:0/enable),
then reboot the system, and we will find the status of remote SAS PHY which is
disabled before is 1 (cat /sys/class/sas_phy/phy-1:0:0/enable). But actually
the status of remote SAS PHY is disabled and the device attached is not found.

In SAS protocol, NEGOTIATED LOGICAL LINK RATE field of DISCOVER response is 0x1
when remote SAS PHY is disabled. So initialize sas_phy->enabled according to
the value of NEGOTIATED LOGICAL LINK RATE field.

Signed-off-by: chenxiang <chenxiang66@hisilicon.com>
Reviewed-by: John Garry <john.garry@huawei.com>
Signed-off-by: Jason Yan <yanaijie@huawei.com>
---
 drivers/scsi/libsas/sas_expander.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Christoph Hellwig Jan. 4, 2018, 12:41 p.m. UTC | #1 
On Thu, Jan 04, 2018 at 07:47:41PM +0800, Jason Yan wrote:
> +	phy->phy->enabled = (phy->linkrate == SAS_PHY_DISABLED) ? 0:1;

missing whitespaces around the ":, but this could just be simplified to:

	phy->phy->enabled = (phy->linkrate != SAS_PHY_DISABLED);

Otherwise this looks fine.
Jason Yan Jan. 4, 2018, 12:42 p.m. UTC | #2 
On 2018/1/4 20:41, Christoph Hellwig wrote:
> On Thu, Jan 04, 2018 at 07:47:41PM +0800, Jason Yan wrote:
>> +	phy->phy->enabled = (phy->linkrate == SAS_PHY_DISABLED) ? 0:1;
>
> missing whitespaces around the ":, but this could just be simplified to:
>
> 	phy->phy->enabled = (phy->linkrate != SAS_PHY_DISABLED);
>

That's better, will update. Thanks.

> Otherwise this looks fine.
>
> .
>
diff mbox

Patch

diff --git a/drivers/scsi/libsas/sas_expander.c b/drivers/scsi/libsas/sas_expander.c
index 6eab487..c79cfd1 100644
--- a/drivers/scsi/libsas/sas_expander.c
+++ b/drivers/scsi/libsas/sas_expander.c
@@ -293,6 +293,7 @@  static void sas_set_ex_phy(struct domain_device *dev, int phy_id, void *rsp)
 	phy->phy->minimum_linkrate = dr->pmin_linkrate;
 	phy->phy->maximum_linkrate = dr->pmax_linkrate;
 	phy->phy->negotiated_linkrate = phy->linkrate;
+	phy->phy->enabled = (phy->linkrate == SAS_PHY_DISABLED) ? 0:1;
 
  skip:
 	if (new_phy)