| Message ID | 20171212074149.7844-1-andi.shyti@samsung.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
Hi Dmitry, this is a kind ping, would you also mind giving me a feedback to all the previous patches I sent? Thanks, Andi On Tue, Dec 12, 2017 at 04:41:49PM +0900, Andi Shyti wrote: > Replace the original license statement with the SPDX identifier. > > Update also the copyright owner adding myself as co-owner of the > copyright. > > Signed-off-by: Andi Shyti <andi.shyti@samsung.com> > --- > drivers/input/touchscreen/s6sy761.c | 15 +++++---------- > drivers/input/touchscreen/stmfts.c | 15 +++++---------- > 2 files changed, 10 insertions(+), 20 deletions(-) > > diff --git a/drivers/input/touchscreen/s6sy761.c b/drivers/input/touchscreen/s6sy761.c > index 26b1cb8a88ec..675efa93d444 100644 > --- a/drivers/input/touchscreen/s6sy761.c > +++ b/drivers/input/touchscreen/s6sy761.c > @@ -1,13 +1,8 @@ > -/* > - * Copyright (c) 2017 Samsung Electronics Co., Ltd. > - * Author: Andi Shyti <andi.shyti@samsung.com> > - * > - * This program is free software; you can redistribute it and/or modify > - * it under the terms of the GNU General Public License version 2 as > - * published by the Free Software Foundation. > - * > - * Samsung S6SY761 Touchscreen device driver > - */ > +// SPDX-License-Identifier: GPL-2.0 > +// Samsung S6SY761 Touchscreen device driver > +// > +// Copyright (c) 2017 Samsung Electronics Co., Ltd. > +// Copyright (c) 2017 Andi Shyti <andi.shyti@samsung.com> > > #include <asm/unaligned.h> > #include <linux/delay.h> > diff --git a/drivers/input/touchscreen/stmfts.c b/drivers/input/touchscreen/stmfts.c > index c12d01899939..2a123e20a42e 100644 > --- a/drivers/input/touchscreen/stmfts.c > +++ b/drivers/input/touchscreen/stmfts.c > @@ -1,13 +1,8 @@ > -/* > - * Copyright (c) 2017 Samsung Electronics Co., Ltd. > - * Author: Andi Shyti <andi.shyti@samsung.com> > - * > - * This program is free software; you can redistribute it and/or modify > - * it under the terms of the GNU General Public License version 2 as > - * published by the Free Software Foundation. > - * > - * STMicroelectronics FTS Touchscreen device driver > - */ > +// SPDX-License-Identifier: GPL-2.0 > +// STMicroelectronics FTS Touchscreen device driver > +// > +// Copyright (c) 2017 Samsung Electronics Co., Ltd. > +// Copyright (c) 2017 Andi Shyti <andi.shyti@samsung.com> > > #include <linux/delay.h> > #include <linux/i2c.h> > -- > 2.15.1 > -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Andi, On Fri, Jan 05, 2018 at 06:57:15PM +0900, Andi Shyti wrote: > Hi Dmitry, > > this is a kind ping, would you also mind giving me a feedback to Yes, sorry. Could you please split the patch for each driver individually? Also, until we have an update to the CodingStyle doc mandating the C++ style comments, I'd prefer keeping the original style of comments. So // for the SPDX line and /* */ for the rest. Thanks! > all the previous patches I sent? Could you tell me what reviews I owe you? My mailbox keeps growing :( > > Thanks, > Andi > > On Tue, Dec 12, 2017 at 04:41:49PM +0900, Andi Shyti wrote: > > Replace the original license statement with the SPDX identifier. > > > > Update also the copyright owner adding myself as co-owner of the > > copyright. > > > > Signed-off-by: Andi Shyti <andi.shyti@samsung.com> > > --- > > drivers/input/touchscreen/s6sy761.c | 15 +++++---------- > > drivers/input/touchscreen/stmfts.c | 15 +++++---------- > > 2 files changed, 10 insertions(+), 20 deletions(-) > > > > diff --git a/drivers/input/touchscreen/s6sy761.c b/drivers/input/touchscreen/s6sy761.c > > index 26b1cb8a88ec..675efa93d444 100644 > > --- a/drivers/input/touchscreen/s6sy761.c > > +++ b/drivers/input/touchscreen/s6sy761.c > > @@ -1,13 +1,8 @@ > > -/* > > - * Copyright (c) 2017 Samsung Electronics Co., Ltd. > > - * Author: Andi Shyti <andi.shyti@samsung.com> > > - * > > - * This program is free software; you can redistribute it and/or modify > > - * it under the terms of the GNU General Public License version 2 as > > - * published by the Free Software Foundation. > > - * > > - * Samsung S6SY761 Touchscreen device driver > > - */ > > +// SPDX-License-Identifier: GPL-2.0 > > +// Samsung S6SY761 Touchscreen device driver > > +// > > +// Copyright (c) 2017 Samsung Electronics Co., Ltd. > > +// Copyright (c) 2017 Andi Shyti <andi.shyti@samsung.com> > > > > #include <asm/unaligned.h> > > #include <linux/delay.h> > > diff --git a/drivers/input/touchscreen/stmfts.c b/drivers/input/touchscreen/stmfts.c > > index c12d01899939..2a123e20a42e 100644 > > --- a/drivers/input/touchscreen/stmfts.c > > +++ b/drivers/input/touchscreen/stmfts.c > > @@ -1,13 +1,8 @@ > > -/* > > - * Copyright (c) 2017 Samsung Electronics Co., Ltd. > > - * Author: Andi Shyti <andi.shyti@samsung.com> > > - * > > - * This program is free software; you can redistribute it and/or modify > > - * it under the terms of the GNU General Public License version 2 as > > - * published by the Free Software Foundation. > > - * > > - * STMicroelectronics FTS Touchscreen device driver > > - */ > > +// SPDX-License-Identifier: GPL-2.0 > > +// STMicroelectronics FTS Touchscreen device driver > > +// > > +// Copyright (c) 2017 Samsung Electronics Co., Ltd. > > +// Copyright (c) 2017 Andi Shyti <andi.shyti@samsung.com> > > > > #include <linux/delay.h> > > #include <linux/i2c.h> > > -- > > 2.15.1 > >
Hi Dmitry, On Fri, Jan 05, 2018 at 08:49:58AM -0800, Dmitry Torokhov wrote: > Hi Andi, > > On Fri, Jan 05, 2018 at 06:57:15PM +0900, Andi Shyti wrote: > > Hi Dmitry, > > > > this is a kind ping, would you also mind giving me a feedback to > > Yes, sorry. Could you please split the patch for each driver > individually? Also, until we have an update to the CodingStyle doc > mandating the C++ style comments, I'd prefer keeping the original style > of comments. So // for the SPDX line and /* */ for the rest. I was actually following Linus guideline [1] [2]. I also had the same discussion previously in another context [3]. Please let me know if you still want a mixed style of comments in the next patch. Thanks, Andi [1] https://marc.info/?l=linux-kernel&m=151163713125320&w=2 ... └-> https://marc.info/?l=linux-kernel&m=151163867325641&w=2 ... └-> https://marc.info/?l=linux-kernel&m=151163867325641&w=2 [2] https://marc.info/?l=linux-kernel&m=150964359922353 [3] https://marc.info/?l=linux-kernel&m=151312974503109&w=2 -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, Jan 09, 2018 at 02:23:31PM +0900, Andi Shyti wrote: > Hi Dmitry, > > On Fri, Jan 05, 2018 at 08:49:58AM -0800, Dmitry Torokhov wrote: > > Hi Andi, > > > > On Fri, Jan 05, 2018 at 06:57:15PM +0900, Andi Shyti wrote: > > > Hi Dmitry, > > > > > > this is a kind ping, would you also mind giving me a feedback to > > > > Yes, sorry. Could you please split the patch for each driver > > individually? Also, until we have an update to the CodingStyle doc > > mandating the C++ style comments, I'd prefer keeping the original style > > of comments. So // for the SPDX line and /* */ for the rest. > > I was actually following Linus guideline [1] [2]. I also had the > same discussion previously in another context [3]. > > Please let me know if you still want a mixed style of comments in > the next patch. Eh, I guess it does not matter in the grand scheme of things; applied as is. Thank you. > > Thanks, > Andi > > [1] https://marc.info/?l=linux-kernel&m=151163713125320&w=2 > ... > └-> https://marc.info/?l=linux-kernel&m=151163867325641&w=2 > ... > └-> https://marc.info/?l=linux-kernel&m=151163867325641&w=2 > > [2] https://marc.info/?l=linux-kernel&m=150964359922353 > [3] https://marc.info/?l=linux-kernel&m=151312974503109&w=2
diff --git a/drivers/input/touchscreen/s6sy761.c b/drivers/input/touchscreen/s6sy761.c index 26b1cb8a88ec..675efa93d444 100644 --- a/drivers/input/touchscreen/s6sy761.c +++ b/drivers/input/touchscreen/s6sy761.c @@ -1,13 +1,8 @@ -/* - * Copyright (c) 2017 Samsung Electronics Co., Ltd. - * Author: Andi Shyti <andi.shyti@samsung.com> - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License version 2 as - * published by the Free Software Foundation. - * - * Samsung S6SY761 Touchscreen device driver - */ +// SPDX-License-Identifier: GPL-2.0 +// Samsung S6SY761 Touchscreen device driver +// +// Copyright (c) 2017 Samsung Electronics Co., Ltd. +// Copyright (c) 2017 Andi Shyti <andi.shyti@samsung.com> #include <asm/unaligned.h> #include <linux/delay.h> diff --git a/drivers/input/touchscreen/stmfts.c b/drivers/input/touchscreen/stmfts.c index c12d01899939..2a123e20a42e 100644 --- a/drivers/input/touchscreen/stmfts.c +++ b/drivers/input/touchscreen/stmfts.c @@ -1,13 +1,8 @@ -/* - * Copyright (c) 2017 Samsung Electronics Co., Ltd. - * Author: Andi Shyti <andi.shyti@samsung.com> - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License version 2 as - * published by the Free Software Foundation. - * - * STMicroelectronics FTS Touchscreen device driver - */ +// SPDX-License-Identifier: GPL-2.0 +// STMicroelectronics FTS Touchscreen device driver +// +// Copyright (c) 2017 Samsung Electronics Co., Ltd. +// Copyright (c) 2017 Andi Shyti <andi.shyti@samsung.com> #include <linux/delay.h> #include <linux/i2c.h>
Replace the original license statement with the SPDX identifier. Update also the copyright owner adding myself as co-owner of the copyright. Signed-off-by: Andi Shyti <andi.shyti@samsung.com> --- drivers/input/touchscreen/s6sy761.c | 15 +++++---------- drivers/input/touchscreen/stmfts.c | 15 +++++---------- 2 files changed, 10 insertions(+), 20 deletions(-)