| Message ID | 20171215141741.175985-1-yixun.lan@amlogic.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
On 15/12/2017 15:17, Yixun Lan wrote: > Switch the uart_ao pclk to CLK81 since the clock driver is ready. > > Signed-off-by: Yixun Lan <yixun.lan@amlogic.com> > > --- > This is a fixup for the previous version > > Changes in v8 since [1] > - move clock DT info into soc.dtsi > > [1] > http://lists.infradead.org/pipermail/linux-amlogic/2017-December/005741.html > --- > arch/arm64/boot/dts/amlogic/meson-axg.dtsi | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi > index 01beb211f442..d1f8043be426 100644 > --- a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi > +++ b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi > @@ -7,6 +7,7 @@ > #include <dt-bindings/gpio/gpio.h> > #include <dt-bindings/interrupt-controller/irq.h> > #include <dt-bindings/interrupt-controller/arm-gic.h> > +#include <dt-bindings/clock/axg-clkc.h> > > / { > compatible = "amlogic,meson-axg"; > @@ -200,7 +201,7 @@ > compatible = "amlogic,meson-gx-uart", "amlogic,meson-ao-uart"; > reg = <0x0 0x3000 0x0 0x18>; > interrupts = <GIC_SPI 193 IRQ_TYPE_EDGE_RISING>; > - clocks = <&xtal>, <&xtal>, <&xtal>; > + clocks = <&xtal>, <&clkc CLKID_CLK81>, <&xtal>; > clock-names = "xtal", "pclk", "baud"; > status = "disabled"; > }; > @@ -209,7 +210,7 @@ > compatible = "amlogic,meson-gx-uart", "amlogic,meson-ao-uart"; > reg = <0x0 0x4000 0x0 0x18>; > interrupts = <GIC_SPI 197 IRQ_TYPE_EDGE_RISING>; > - clocks = <&xtal>, <&xtal>, <&xtal>; > + clocks = <&xtal>, <&clkc CLKID_CLK81>, <&xtal>; > clock-names = "xtal", "pclk", "baud"; > status = "disabled"; > }; > Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
Hi Yixun,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on robh/for-next]
[also build test ERROR on v4.15-rc4 next-20171215]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Yixun-Lan/arm64-dts-meson-axg-switch-uart_ao-clock-to-CLK81/20171218-100949
base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
config: arm64-defconfig (attached as .config)
compiler: aarch64-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
make.cross ARCH=arm64
All errors (new ones prefixed by >>):
In file included from arch/arm64/boot/dts/amlogic/meson-axg-s400.dts:9:0:
>> arch/arm64/boot/dts/amlogic/meson-axg.dtsi:10:10: fatal error: dt-bindings/clock/axg-clkc.h: No such file or directory
#include <dt-bindings/clock/axg-clkc.h>
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
vim +10 arch/arm64/boot/dts/amlogic/meson-axg.dtsi
> 10 #include <dt-bindings/clock/axg-clkc.h>
11
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
Yixun Lan <yixun.lan@amlogic.com> writes: > Switch the uart_ao pclk to CLK81 since the clock driver is ready. > > Signed-off-by: Yixun Lan <yixun.lan@amlogic.com> Applied to v4.16/dt64 with Neil's tag. Kevin
diff --git a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi index 01beb211f442..d1f8043be426 100644 --- a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi +++ b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi @@ -7,6 +7,7 @@ #include <dt-bindings/gpio/gpio.h> #include <dt-bindings/interrupt-controller/irq.h> #include <dt-bindings/interrupt-controller/arm-gic.h> +#include <dt-bindings/clock/axg-clkc.h> / { compatible = "amlogic,meson-axg"; @@ -200,7 +201,7 @@ compatible = "amlogic,meson-gx-uart", "amlogic,meson-ao-uart"; reg = <0x0 0x3000 0x0 0x18>; interrupts = <GIC_SPI 193 IRQ_TYPE_EDGE_RISING>; - clocks = <&xtal>, <&xtal>, <&xtal>; + clocks = <&xtal>, <&clkc CLKID_CLK81>, <&xtal>; clock-names = "xtal", "pclk", "baud"; status = "disabled"; }; @@ -209,7 +210,7 @@ compatible = "amlogic,meson-gx-uart", "amlogic,meson-ao-uart"; reg = <0x0 0x4000 0x0 0x18>; interrupts = <GIC_SPI 197 IRQ_TYPE_EDGE_RISING>; - clocks = <&xtal>, <&xtal>, <&xtal>; + clocks = <&xtal>, <&clkc CLKID_CLK81>, <&xtal>; clock-names = "xtal", "pclk", "baud"; status = "disabled"; };
Switch the uart_ao pclk to CLK81 since the clock driver is ready. Signed-off-by: Yixun Lan <yixun.lan@amlogic.com> --- This is a fixup for the previous version Changes in v8 since [1] - move clock DT info into soc.dtsi [1] http://lists.infradead.org/pipermail/linux-amlogic/2017-December/005741.html --- arch/arm64/boot/dts/amlogic/meson-axg.dtsi | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)