| Message ID | 1515317771-4499-1-git-send-email-venkat.prashanth2498@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Sun, 7 Jan 2018 15:06:11 +0530 venkat.prashanth2498@gmail.com wrote: > From: Venkat Prashanth B U <venkat.prashanth2498@gmail.com> > > Use DEFINE_DEBUGFS_ATTRIBUTE rather than DEFINE_SIMPLE_ATTRIBUTE > for debugfs files. > > Semantic patch information: > Rationale: DEFINE_SIMPLE_ATTRIBUTE + debugfs_create_file() > imposes some significant overhead as compared to > DEFINE_DEBUGFS_ATTRIBUTE + debugfs_create_file_unsafe(). > > Generated by: scripts/coccinelle/api/debugfs/debugfs_simple_attr.cocci > > Signed-off-by: Venkat Prashanth B U <venkat.prashanth2498@gmail.com> Applied, thanks Jonathan > --- > drivers/iio/imu/adis16480.c | 28 ++++++++++++++++------------ > 1 file changed, 16 insertions(+), 12 deletions(-) > > diff --git a/drivers/iio/imu/adis16480.c b/drivers/iio/imu/adis16480.c > index 7a33d6b..8e9f31f 100644 > --- a/drivers/iio/imu/adis16480.c > +++ b/drivers/iio/imu/adis16480.c > @@ -194,7 +194,7 @@ static int adis16480_show_serial_number(void *arg, u64 *val) > > return 0; > } > -DEFINE_SIMPLE_ATTRIBUTE(adis16480_serial_number_fops, > +DEFINE_DEBUGFS_ATTRIBUTE(adis16480_serial_number_fops, > adis16480_show_serial_number, NULL, "0x%.4llx\n"); > > static int adis16480_show_product_id(void *arg, u64 *val) > @@ -212,7 +212,7 @@ static int adis16480_show_product_id(void *arg, u64 *val) > > return 0; > } > -DEFINE_SIMPLE_ATTRIBUTE(adis16480_product_id_fops, > +DEFINE_DEBUGFS_ATTRIBUTE(adis16480_product_id_fops, > adis16480_show_product_id, NULL, "%llu\n"); > > static int adis16480_show_flash_count(void *arg, u64 *val) > @@ -230,24 +230,28 @@ static int adis16480_show_flash_count(void *arg, u64 *val) > > return 0; > } > -DEFINE_SIMPLE_ATTRIBUTE(adis16480_flash_count_fops, > +DEFINE_DEBUGFS_ATTRIBUTE(adis16480_flash_count_fops, > adis16480_show_flash_count, NULL, "%lld\n"); > > static int adis16480_debugfs_init(struct iio_dev *indio_dev) > { > struct adis16480 *adis16480 = iio_priv(indio_dev); > > - debugfs_create_file("firmware_revision", 0400, > + debugfs_create_file_unsafe("firmware_revision", 0400, > indio_dev->debugfs_dentry, adis16480, > &adis16480_firmware_revision_fops); > - debugfs_create_file("firmware_date", 0400, indio_dev->debugfs_dentry, > - adis16480, &adis16480_firmware_date_fops); > - debugfs_create_file("serial_number", 0400, indio_dev->debugfs_dentry, > - adis16480, &adis16480_serial_number_fops); > - debugfs_create_file("product_id", 0400, indio_dev->debugfs_dentry, > - adis16480, &adis16480_product_id_fops); > - debugfs_create_file("flash_count", 0400, indio_dev->debugfs_dentry, > - adis16480, &adis16480_flash_count_fops); > + debugfs_create_file_unsafe("firmware_date", 0400, > + indio_dev->debugfs_dentry, adis16480, > + &adis16480_firmware_date_fops); > + debugfs_create_file_unsafe("serial_number", 0400, > + indio_dev->debugfs_dentry, adis16480, > + &adis16480_serial_number_fops); > + debugfs_create_file_unsafe("product_id", 0400, > + indio_dev->debugfs_dentry, adis16480, > + &adis16480_product_id_fops); > + debugfs_create_file_unsafe("flash_count", 0400, > + indio_dev->debugfs_dentry, adis16480, > + &adis16480_flash_count_fops); > > return 0; > } > -- > 1.9.1 > -- To unsubscribe from this list: send the line "unsubscribe linux-iio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/iio/imu/adis16480.c b/drivers/iio/imu/adis16480.c index 7a33d6b..8e9f31f 100644 --- a/drivers/iio/imu/adis16480.c +++ b/drivers/iio/imu/adis16480.c @@ -194,7 +194,7 @@ static int adis16480_show_serial_number(void *arg, u64 *val) return 0; } -DEFINE_SIMPLE_ATTRIBUTE(adis16480_serial_number_fops, +DEFINE_DEBUGFS_ATTRIBUTE(adis16480_serial_number_fops, adis16480_show_serial_number, NULL, "0x%.4llx\n"); static int adis16480_show_product_id(void *arg, u64 *val) @@ -212,7 +212,7 @@ static int adis16480_show_product_id(void *arg, u64 *val) return 0; } -DEFINE_SIMPLE_ATTRIBUTE(adis16480_product_id_fops, +DEFINE_DEBUGFS_ATTRIBUTE(adis16480_product_id_fops, adis16480_show_product_id, NULL, "%llu\n"); static int adis16480_show_flash_count(void *arg, u64 *val) @@ -230,24 +230,28 @@ static int adis16480_show_flash_count(void *arg, u64 *val) return 0; } -DEFINE_SIMPLE_ATTRIBUTE(adis16480_flash_count_fops, +DEFINE_DEBUGFS_ATTRIBUTE(adis16480_flash_count_fops, adis16480_show_flash_count, NULL, "%lld\n"); static int adis16480_debugfs_init(struct iio_dev *indio_dev) { struct adis16480 *adis16480 = iio_priv(indio_dev); - debugfs_create_file("firmware_revision", 0400, + debugfs_create_file_unsafe("firmware_revision", 0400, indio_dev->debugfs_dentry, adis16480, &adis16480_firmware_revision_fops); - debugfs_create_file("firmware_date", 0400, indio_dev->debugfs_dentry, - adis16480, &adis16480_firmware_date_fops); - debugfs_create_file("serial_number", 0400, indio_dev->debugfs_dentry, - adis16480, &adis16480_serial_number_fops); - debugfs_create_file("product_id", 0400, indio_dev->debugfs_dentry, - adis16480, &adis16480_product_id_fops); - debugfs_create_file("flash_count", 0400, indio_dev->debugfs_dentry, - adis16480, &adis16480_flash_count_fops); + debugfs_create_file_unsafe("firmware_date", 0400, + indio_dev->debugfs_dentry, adis16480, + &adis16480_firmware_date_fops); + debugfs_create_file_unsafe("serial_number", 0400, + indio_dev->debugfs_dentry, adis16480, + &adis16480_serial_number_fops); + debugfs_create_file_unsafe("product_id", 0400, + indio_dev->debugfs_dentry, adis16480, + &adis16480_product_id_fops); + debugfs_create_file_unsafe("flash_count", 0400, + indio_dev->debugfs_dentry, adis16480, + &adis16480_flash_count_fops); return 0; }