diff mbox

mt76x2: eeprom: fix typo in mt76x2_get_power_info_5g()

Message ID 2ae397aff0b058615a558a2352067fad2c9201e6.1513248071.git.lorenzo.bianconi@redhat.com (mailing list archive)
State Accepted
Commit c3929a980b16277cf3cd5e797adcb9bdf877ef4e
Delegated to: Kalle Valo
Headers show

Commit Message

Lorenzo Bianconi Dec. 14, 2017, 10:46 a.m. UTC
Fix typo in 5GHz power vs channel eeprom parsing

Fixes: 7bc04215a66b ("mt76: add driver code for MT76x2e")
Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
---
 drivers/net/wireless/mediatek/mt76/mt76x2_eeprom.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Felix Fietkau Dec. 14, 2017, 3:29 p.m. UTC | #1
On 2017-12-14 11:46, Lorenzo Bianconi wrote:
> Fix typo in 5GHz power vs channel eeprom parsing
> 
> Fixes: 7bc04215a66b ("mt76: add driver code for MT76x2e")
> Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
Acked-by: Felix Fietkau <nbd@nbd.name>
Colin King Dec. 14, 2017, 3:42 p.m. UTC | #2
On 14/12/17 10:46, Lorenzo Bianconi wrote:
> Fix typo in 5GHz power vs channel eeprom parsing
> 
> Fixes: 7bc04215a66b ("mt76: add driver code for MT76x2e")
> Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
> ---
>  drivers/net/wireless/mediatek/mt76/mt76x2_eeprom.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/wireless/mediatek/mt76/mt76x2_eeprom.c b/drivers/net/wireless/mediatek/mt76/mt76x2_eeprom.c
> index 440b7e7d73a9..29dc52ef629d 100644
> --- a/drivers/net/wireless/mediatek/mt76/mt76x2_eeprom.c
> +++ b/drivers/net/wireless/mediatek/mt76/mt76x2_eeprom.c
> @@ -524,7 +524,7 @@ mt76x2_get_power_info_5g(struct mt76x2_dev *dev, struct mt76x2_tx_power_info *t,
>  
>  	if (channel >= 192)
>  		delta_idx = 4;
> -	else if (channel >= 484)
> +	else if (channel >= 184)
>  		delta_idx = 3;
>  	else if (channel < 44)
>  		delta_idx = 3;
> 
any possibility of adding:

Reported-by: Colin Ian King <colin.king@canonical.com>
Kalle Valo Dec. 14, 2017, 4:20 p.m. UTC | #3
Colin Ian King <colin.king@canonical.com> writes:

> On 14/12/17 10:46, Lorenzo Bianconi wrote:
>> Fix typo in 5GHz power vs channel eeprom parsing
>> 
>> Fixes: 7bc04215a66b ("mt76: add driver code for MT76x2e")
>> Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
>> ---
>>  drivers/net/wireless/mediatek/mt76/mt76x2_eeprom.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/drivers/net/wireless/mediatek/mt76/mt76x2_eeprom.c b/drivers/net/wireless/mediatek/mt76/mt76x2_eeprom.c
>> index 440b7e7d73a9..29dc52ef629d 100644
>> --- a/drivers/net/wireless/mediatek/mt76/mt76x2_eeprom.c
>> +++ b/drivers/net/wireless/mediatek/mt76/mt76x2_eeprom.c
>> @@ -524,7 +524,7 @@ mt76x2_get_power_info_5g(struct mt76x2_dev *dev, struct mt76x2_tx_power_info *t,
>>  
>>  	if (channel >= 192)
>>  		delta_idx = 4;
>> -	else if (channel >= 484)
>> +	else if (channel >= 184)
>>  		delta_idx = 3;
>>  	else if (channel < 44)
>>  		delta_idx = 3;
>> 
> any possibility of adding:
>
> Reported-by: Colin Ian King <colin.king@canonical.com>

Sure, I'll add that during commit.
Kalle Valo Jan. 8, 2018, 5:30 p.m. UTC | #4
Lorenzo Bianconi <lorenzo.bianconi@redhat.com> wrote:

> Fix typo in 5GHz power vs channel eeprom parsing
> 
> Fixes: 7bc04215a66b ("mt76: add driver code for MT76x2e")
> Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
> Acked-by: Felix Fietkau <nbd@nbd.name>
> Reported-by: Colin Ian King <colin.king@canonical.com>

Patch applied to wireless-drivers-next.git, thanks.

c3929a980b16 mt76x2: eeprom: fix typo in mt76x2_get_power_info_5g()
Kalle Valo Jan. 8, 2018, 5:32 p.m. UTC | #5
Kalle Valo <kvalo@codeaurora.org> writes:

> Colin Ian King <colin.king@canonical.com> writes:
>
>> On 14/12/17 10:46, Lorenzo Bianconi wrote:
>>> Fix typo in 5GHz power vs channel eeprom parsing
>>> 
>>> Fixes: 7bc04215a66b ("mt76: add driver code for MT76x2e")
>>> Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>

[...]

>> any possibility of adding:
>>
>> Reported-by: Colin Ian King <colin.king@canonical.com>
>
> Sure, I'll add that during commit.

Actually patchwork added that automatically based on your email, just as
it does with Acked-by. Very nice!
diff mbox

Patch

diff --git a/drivers/net/wireless/mediatek/mt76/mt76x2_eeprom.c b/drivers/net/wireless/mediatek/mt76/mt76x2_eeprom.c
index 440b7e7d73a9..29dc52ef629d 100644
--- a/drivers/net/wireless/mediatek/mt76/mt76x2_eeprom.c
+++ b/drivers/net/wireless/mediatek/mt76/mt76x2_eeprom.c
@@ -524,7 +524,7 @@  mt76x2_get_power_info_5g(struct mt76x2_dev *dev, struct mt76x2_tx_power_info *t,
 
 	if (channel >= 192)
 		delta_idx = 4;
-	else if (channel >= 484)
+	else if (channel >= 184)
 		delta_idx = 3;
 	else if (channel < 44)
 		delta_idx = 3;