| Message ID | 20180111093707.2615555-1-arnd@arndb.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 1/11/2018 1:36 AM, Arnd Bergmann wrote: > linux-4.15 warns about missing MODULE_LICENSE tags such as these > > WARNING: modpost: missing MODULE_LICENSE() in drivers/bus/omap_l3_noc.o > WARNING: modpost: missing MODULE_LICENSE() in drivers/bus/omap_l3_smx.o > > For completeness, I'm also adding MODULE_AUTHOR and MODULE_DESCRIPTION > tags, but I decided to leave out the email addresses, as all three > authors are working for other companies now. > > Cc: Sricharan R <sricharan@codeaurora.org> > Cc: Santosh Shilimkar <santosh.shilimkar@oracle.com> > Cc: Felipe Balbi <felipe.balbi@linux.intel.com> > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > --- > Unless someone sees a problem here, I'd pick this up into arm-soc > directly, either the fixes or drivers branch > --- Fine by me. Acked-by: Santosh Shilimkar <ssantosh@kernel.org> -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, Jan 11, 2018 at 08:34:06AM -0800, Santosh Shilimkar wrote: > On 1/11/2018 1:36 AM, Arnd Bergmann wrote: > > linux-4.15 warns about missing MODULE_LICENSE tags such as these > > > > WARNING: modpost: missing MODULE_LICENSE() in drivers/bus/omap_l3_noc.o > > WARNING: modpost: missing MODULE_LICENSE() in drivers/bus/omap_l3_smx.o > > > > For completeness, I'm also adding MODULE_AUTHOR and MODULE_DESCRIPTION > > tags, but I decided to leave out the email addresses, as all three > > authors are working for other companies now. > > > > Cc: Sricharan R <sricharan@codeaurora.org> > > Cc: Santosh Shilimkar <santosh.shilimkar@oracle.com> > > Cc: Felipe Balbi <felipe.balbi@linux.intel.com> > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > > --- > > Unless someone sees a problem here, I'd pick this up into arm-soc > > directly, either the fixes or drivers branch > > --- > Fine by me. > Acked-by: Santosh Shilimkar <ssantosh@kernel.org> Applied to next/drivers. -Olof -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/bus/omap_l3_noc.c b/drivers/bus/omap_l3_noc.c index 5012e3ad1225..b040447575ad 100644 --- a/drivers/bus/omap_l3_noc.c +++ b/drivers/bus/omap_l3_noc.c @@ -375,3 +375,8 @@ static void __exit omap_l3_exit(void) platform_driver_unregister(&omap_l3_driver); } module_exit(omap_l3_exit); + +MODULE_AUTHOR("Santosh Shilimkar"); +MODULE_AUTHOR("Sricharan R"); +MODULE_DESCRIPTION("OMAP L3 Interconnect error handling driver"); +MODULE_LICENSE("GPL v2"); diff --git a/drivers/bus/omap_l3_smx.c b/drivers/bus/omap_l3_smx.c index 360a5c0a4ee0..b853a729537a 100644 --- a/drivers/bus/omap_l3_smx.c +++ b/drivers/bus/omap_l3_smx.c @@ -309,3 +309,9 @@ static void __exit omap3_l3_exit(void) platform_driver_unregister(&omap3_l3_driver); } module_exit(omap3_l3_exit); + +MODULE_AUTHOR("Felipe Balbi"); +MODULE_AUTHOR("Santosh Shilimkar"); +MODULE_AUTHOR("Sricharan R"); +MODULE_DESCRIPTION("OMAP3XXX L3 Interconnect Driver"); +MODULE_LICENSE("GPL");
linux-4.15 warns about missing MODULE_LICENSE tags such as these WARNING: modpost: missing MODULE_LICENSE() in drivers/bus/omap_l3_noc.o WARNING: modpost: missing MODULE_LICENSE() in drivers/bus/omap_l3_smx.o For completeness, I'm also adding MODULE_AUTHOR and MODULE_DESCRIPTION tags, but I decided to leave out the email addresses, as all three authors are working for other companies now. Cc: Sricharan R <sricharan@codeaurora.org> Cc: Santosh Shilimkar <santosh.shilimkar@oracle.com> Cc: Felipe Balbi <felipe.balbi@linux.intel.com> Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- Unless someone sees a problem here, I'd pick this up into arm-soc directly, either the fixes or drivers branch --- drivers/bus/omap_l3_noc.c | 5 +++++ drivers/bus/omap_l3_smx.c | 6 ++++++ 2 files changed, 11 insertions(+)