diff mbox

[6/7] si2168: Announce frontend creation failure

Message ID 1515773982-6411-6-git-send-email-brad@nextdimension.cc (mailing list archive)
State New, archived
Headers show

Commit Message

Brad Love Jan. 12, 2018, 4:19 p.m. UTC 
The driver outputs on success, but is silent on failure. Give
one message that probe failed.

Signed-off-by: Brad Love <brad@nextdimension.cc>
---
 drivers/media/dvb-frontends/si2168.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Antti Palosaari Jan. 16, 2018, 5:10 a.m. UTC | #1 
hmmm, IIRC driver core even prints some error when driver probe fails? 
After that you could enable module debug logging to see more 
information. So I don't see point for that change.

regards
Antti

On 01/12/2018 06:19 PM, Brad Love wrote:
> The driver outputs on success, but is silent on failure. Give
> one message that probe failed.
> 
> Signed-off-by: Brad Love <brad@nextdimension.cc>
> ---
>   drivers/media/dvb-frontends/si2168.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/media/dvb-frontends/si2168.c b/drivers/media/dvb-frontends/si2168.c
> index 429c03a..c1a638c 100644
> --- a/drivers/media/dvb-frontends/si2168.c
> +++ b/drivers/media/dvb-frontends/si2168.c
> @@ -810,7 +810,7 @@ static int si2168_probe(struct i2c_client *client,
>   err_kfree:
>   	kfree(dev);
>   err:
> -	dev_dbg(&client->dev, "failed=%d\n", ret);
> +	dev_warn(&client->dev, "probe failed = %d\n", ret);
>   	return ret;
>   }
>   
>
diff mbox

Patch

diff --git a/drivers/media/dvb-frontends/si2168.c b/drivers/media/dvb-frontends/si2168.c
index 429c03a..c1a638c 100644
--- a/drivers/media/dvb-frontends/si2168.c
+++ b/drivers/media/dvb-frontends/si2168.c
@@ -810,7 +810,7 @@  static int si2168_probe(struct i2c_client *client,
 err_kfree:
 	kfree(dev);
 err:
-	dev_dbg(&client->dev, "failed=%d\n", ret);
+	dev_warn(&client->dev, "probe failed = %d\n", ret);
 	return ret;
 }