| Message ID | f46c90a50429201056419aae168a836fcc406f47.1516315624.git.lorenzo.bianconi@redhat.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Kalle Valo |
| Headers | show |
Lorenzo Bianconi <lorenzo.bianconi@redhat.com> writes:
> Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
No empty commit logs, please. At least the commit log should answer the
question "Why?". For example, are you fixing a reported bug or are you
fixing is a theoretical issue you found during code review? What kind of
symtomps does this bug have?
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#commit_log_does_not_answer_why
> Lorenzo Bianconi <lorenzo.bianconi@redhat.com> writes: > >> Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi@redhat.com> > > No empty commit logs, please. At least the commit log should answer the > question "Why?". For example, are you fixing a reported bug or are you > fixing is a theoretical issue you found during code review? What kind of > symtomps does this bug have? > > https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#commit_log_does_not_answer_why Ack, I will wait for some feedbacks and then I will respin a v2 with a proper commit log. Thanks. Regards, Lorenzo > > -- > Kalle Valo
diff --git a/drivers/net/wireless/mediatek/mt76/mt76x2_init.c b/drivers/net/wireless/mediatek/mt76/mt76x2_init.c index 9f20a308ff76..66d4bfc70977 100644 --- a/drivers/net/wireless/mediatek/mt76/mt76x2_init.c +++ b/drivers/net/wireless/mediatek/mt76/mt76x2_init.c @@ -614,6 +614,7 @@ void mt76x2_stop_hardware(struct mt76x2_dev *dev) void mt76x2_cleanup(struct mt76x2_dev *dev) { + tasklet_disable(&dev->pre_tbtt_tasklet); mt76x2_stop_hardware(dev); mt76x2_dma_cleanup(dev); mt76x2_mcu_cleanup(dev);
Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi@redhat.com> --- drivers/net/wireless/mediatek/mt76/mt76x2_init.c | 1 + 1 file changed, 1 insertion(+)