| Message ID | 1515639823-35782-1-git-send-email-yong.deng@magewell.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Thu, Jan 11, 2018 at 11:03:43AM +0800, Yong Deng wrote: > Add binding documentation for Allwinner V3s CSI. > > Signed-off-by: Yong Deng <yong.deng@magewell.com> > --- > .../devicetree/bindings/media/sun6i-csi.txt | 59 ++++++++++++++++++++++ > 1 file changed, 59 insertions(+) > create mode 100644 Documentation/devicetree/bindings/media/sun6i-csi.txt Reviewed-by: Rob Herring <robh@kernel.org>
在 2018年1月20日星期六 CST 上午5:14:09，Rob Herring 写道： > On Thu, Jan 11, 2018 at 11:03:43AM +0800, Yong Deng wrote: > > Add binding documentation for Allwinner V3s CSI. > > > > Signed-off-by: Yong Deng <yong.deng@magewell.com> > > --- > > > > .../devicetree/bindings/media/sun6i-csi.txt | 59 > > ++++++++++++++++++++++ 1 file changed, 59 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/media/sun6i-csi.txt > > Reviewed-by: Rob Herring <robh@kernel.org> I think other subsystem's maintainer may expect a Acked-by from you here. Why do you use Reviewed-by here instead? > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
On 01/19/2018 01:17 PM, Icenowy Zheng wrote: > 在 2018年1月20日星期六 CST 上午5:14:09，Rob Herring 写道： >> On Thu, Jan 11, 2018 at 11:03:43AM +0800, Yong Deng wrote: >>> Add binding documentation for Allwinner V3s CSI. >>> >>> Signed-off-by: Yong Deng <yong.deng@magewell.com> >>> --- >>> >>> .../devicetree/bindings/media/sun6i-csi.txt | 59 >>> ++++++++++++++++++++++ 1 file changed, 59 insertions(+) >>> create mode 100644 Documentation/devicetree/bindings/media/sun6i-csi.txt >> >> Reviewed-by: Rob Herring <robh@kernel.org> > > I think other subsystem's maintainer may expect a Acked-by from you here. > > Why do you use Reviewed-by here instead? The Reviewed-by: tag is a stronger ACK than the Acked-by: tag, so this should be sufficient for other subsystem maintainers. Please see Documentation/process/submitting-patches.rst, section 13.
Hi Yong, On Thu, Jan 11, 2018 at 11:03:43AM +0800, Yong Deng wrote: > Add binding documentation for Allwinner V3s CSI. > > Signed-off-by: Yong Deng <yong.deng@magewell.com> Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>
diff --git a/Documentation/devicetree/bindings/media/sun6i-csi.txt b/Documentation/devicetree/bindings/media/sun6i-csi.txt new file mode 100644 index 0000000..2ff47a9 --- /dev/null +++ b/Documentation/devicetree/bindings/media/sun6i-csi.txt @@ -0,0 +1,59 @@ +Allwinner V3s Camera Sensor Interface +------------------------------------- + +Allwinner V3s SoC features two CSI module. CSI0 is used for MIPI CSI-2 +interface and CSI1 is used for parallel interface. + +Required properties: + - compatible: value must be "allwinner,sun8i-v3s-csi" + - reg: base address and size of the memory-mapped region. + - interrupts: interrupt associated to this IP + - clocks: phandles to the clocks feeding the CSI + * bus: the CSI interface clock + * mod: the CSI module clock + * ram: the CSI DRAM clock + - clock-names: the clock names mentioned above + - resets: phandles to the reset line driving the CSI + +Each CSI node should contain one 'port' child node with one child 'endpoint' +node, according to the bindings defined in +Documentation/devicetree/bindings/media/video-interfaces.txt. As mentioned +above, the endpoint's bus type should be MIPI CSI-2 for CSI0 and parallel or +Bt656 for CSI1. + +Endpoint node properties for CSI1 +--------------------------------- + +- remote-endpoint : (required) a phandle to the bus receiver's endpoint + node +- bus-width: : (required) must be 8, 10, 12 or 16 +- pclk-sample : (optional) (default: sample on falling edge) +- hsync-active : (only required for parallel) +- vsync-active : (only required for parallel) + +Example: + +csi1: csi@1cb4000 { + compatible = "allwinner,sun8i-v3s-csi"; + reg = <0x01cb4000 0x1000>; + interrupts = <GIC_SPI 84 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&ccu CLK_BUS_CSI>, + <&ccu CLK_CSI1_SCLK>, + <&ccu CLK_DRAM_CSI>; + clock-names = "bus", "mod", "ram"; + resets = <&ccu RST_BUS_CSI>; + + port { + /* Parallel bus endpoint */ + csi1_ep: endpoint { + remote-endpoint = <&adv7611_ep>; + bus-width = <16>; + + /* If hsync-active/vsync-active are missing, + embedded BT.656 sync is used */ + hsync-active = <0>; /* Active low */ + vsync-active = <0>; /* Active low */ + pclk-sample = <1>; /* Rising */ + }; + }; +};
Add binding documentation for Allwinner V3s CSI. Signed-off-by: Yong Deng <yong.deng@magewell.com> --- .../devicetree/bindings/media/sun6i-csi.txt | 59 ++++++++++++++++++++++ 1 file changed, 59 insertions(+) create mode 100644 Documentation/devicetree/bindings/media/sun6i-csi.txt