diff mbox

test-suite: handle format with filename.c not existing

Message ID CANeU7QkQXoSO+wDDMUfsFuuhavt+YLZXiCCKuqNLTuq3aMc3rQ@mail.gmail.com (mailing list archive)
State Mainlined, archived
Headers show

Commit Message

Christopher Li Jan. 23, 2018, 11:38 p.m. UTC 
On Tue, Jan 23, 2018 at 10:20 AM, Randy Dunlap <rdunlap@infradead.org> wrote:
>
> I guess that I don't understand the interplay between $V and $quiet and why
> have both of them.
>

It seems that $quiet is just invert of $V, which introduce in
the following two commits by Luc.

commit: ee43fc784e52e3ee9e1b45da1be5193ea3b64334
Author: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
Date:   Mon Feb 13 00:29:04 2017 +0100

    testsuite: quieter error reporting for 'known-to-fail'

commit: d2a7009a78effb2a8ac867de9240c4a89d181f5d
Author: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
Date:   Mon Feb 13 00:29:03 2017 +0100

    testsuite: allow quieter error reporting


> Are you suggesting that $quiet should be initialized by default like this:
> (just drop the $must_fail part)
>
>> quiet=0
>> [ $V -eq 0 ] && quiet=1


yes, I was thinking some thing like this,
but I haven't give it a lot of test.

>diff --git a/validation/test-suite b/validation/test-suite
index cf151a3..5e10942 100755
Chris
--
To unsubscribe from this list: send the line "unsubscribe linux-sparse" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Randy Dunlap Jan. 24, 2018, 1:38 a.m. UTC | #1 
On 01/23/2018 03:38 PM, Christopher Li wrote:

> yes, I was thinking some thing like this,
> but I haven't give it a lot of test.
> 
>> diff --git a/validation/test-suite b/validation/test-suite
> index cf151a3..5e10942 100755
> --- a/validation/test-suite
> +++ b/validation/test-suite
> @@ -31,6 +31,7 @@ known_ko_tests=0
> 
>  # defaults to not verbose
>  [ -z "$V" ] && V=0
> +[ $V -eq 0 ] && quiet=1 || quiet=0
> 
>  ##

Fine with me.

Acked-by: Randy Dunlap <rdunlap@infradead.org>
Tested-by: Randy Dunlap <rdunlap@infradead.org>

Thanks.
Christopher Li Jan. 24, 2018, 7:19 p.m. UTC | #2 
On Tue, Jan 23, 2018 at 5:38 PM, Randy Dunlap <rdunlap@infradead.org> wrote:
>>> diff --git a/validation/test-suite b/validation/test-suite
>> index cf151a3..5e10942 100755
>> --- a/validation/test-suite
>> +++ b/validation/test-suite
>> @@ -31,6 +31,7 @@ known_ko_tests=0
>>
>>  # defaults to not verbose
>>  [ -z "$V" ] && V=0
>> +[ $V -eq 0 ] && quiet=1 || quiet=0
>>
>>  ##
>
> Fine with me.
>
> Acked-by: Randy Dunlap <rdunlap@infradead.org>
> Tested-by: Randy Dunlap <rdunlap@infradead.org>
>
I consider that as a minor tweak of your original patch.
May I apply that change and keep you as the author of the
patch?

Thanks

Chris
--
To unsubscribe from this list: send the line "unsubscribe linux-sparse" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Randy Dunlap Jan. 24, 2018, 7:26 p.m. UTC | #3 
On 01/24/2018 11:19 AM, Christopher Li wrote:
> On Tue, Jan 23, 2018 at 5:38 PM, Randy Dunlap <rdunlap@infradead.org> wrote:
>>>> diff --git a/validation/test-suite b/validation/test-suite
>>> index cf151a3..5e10942 100755
>>> --- a/validation/test-suite
>>> +++ b/validation/test-suite
>>> @@ -31,6 +31,7 @@ known_ko_tests=0
>>>
>>>  # defaults to not verbose
>>>  [ -z "$V" ] && V=0
>>> +[ $V -eq 0 ] && quiet=1 || quiet=0
>>>
>>>  ##
>>
>> Fine with me.
>>
>> Acked-by: Randy Dunlap <rdunlap@infradead.org>
>> Tested-by: Randy Dunlap <rdunlap@infradead.org>
>>
> I consider that as a minor tweak of your original patch.
> May I apply that change and keep you as the author of the
> patch?

Sure, no problem.

Thanks.
diff mbox

Patch

--- a/validation/test-suite
+++ b/validation/test-suite
@@ -31,6 +31,7 @@  known_ko_tests=0

 # defaults to not verbose
 [ -z "$V" ] && V=0
+[ $V -eq 0 ] && quiet=1 || quiet=0

 ##