Message ID | 20180117101405.16700-1-nbd@nbd.name (mailing list archive) |
---|---|
State | Accepted |
Commit | 3c0efb745a172bfe96459e20cbd37b0c945d5f8d |
Delegated to: | Kalle Valo |
Headers | show |
Felix Fietkau <nbd@nbd.name> wrote: > Sometimes the hardware will push small packets that trigger a WARN_ON > in mac80211. Discard them early to avoid this issue. > > Reported-by: Stijn Tintel <stijn@linux-ipv6.be> > Signed-off-by: Felix Fietkau <nbd@nbd.name> > Signed-off-by: Kalle Valo <kvalo@codeaurora.org> Patch applied to ath-next branch of ath.git, thanks. 3c0efb745a17 ath9k: discard undersized packets
diff --git a/drivers/net/wireless/ath/ath9k/recv.c b/drivers/net/wireless/ath/ath9k/recv.c index 2197aee2bb72..a8ac42c96d71 100644 --- a/drivers/net/wireless/ath/ath9k/recv.c +++ b/drivers/net/wireless/ath/ath9k/recv.c @@ -826,9 +826,9 @@ static int ath9k_rx_skb_preprocess(struct ath_softc *sc, sc->rx.discard_next = false; /* - * Discard zero-length packets. + * Discard zero-length packets and packets smaller than an ACK */ - if (!rx_stats->rs_datalen) { + if (rx_stats->rs_datalen < 10) { RX_STAT_INC(rx_len_err); goto corrupt; }
Sometimes the hardware will push small packets that trigger a WARN_ON in mac80211. Discard them early to avoid this issue. Reported-by: Stijn Tintel <stijn@linux-ipv6.be> Signed-off-by: Felix Fietkau <nbd@nbd.name> --- drivers/net/wireless/ath/ath9k/recv.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)