| Message ID | 20180126142449.18954-1-jarkko.nikula@linux.intel.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 993181e151311936d7a343fccd6cc4cebe83ad81 |
| Headers | show |
On Fri, 2018-01-26 at 16:24 +0200, Jarkko Nikula wrote: > Local struct chip_data has two members that are not used: > > - cs. Looks like was never used > - enable_dma. Became unused by the commit f89a6d8f43eb ("spi: dw-mid: > move > to use core SPI DMA mappings"). Good clean up! Acked-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > Signed-off-by: Jarkko Nikula <jarkko.nikula@linux.intel.com> > --- > drivers/spi/spi-dw.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/spi/spi-dw.c b/drivers/spi/spi-dw.c > index b217c22ff72f..211cc7d75bf8 100644 > --- a/drivers/spi/spi-dw.c > +++ b/drivers/spi/spi-dw.c > @@ -30,13 +30,11 @@ > > /* Slave spi_dev related */ > struct chip_data { > - u8 cs; /* chip select pin */ > u8 tmode; /* TR/TO/RO/EEPROM */ > u8 type; /* SPI/SSP/MicroWire */ > > u8 poll_mode; /* 1 means use poll mode */ > > - u8 enable_dma; > u16 clk_div; /* baud rate divider */ > u32 speed_hz; /* baud rate */ > void (*cs_control)(u32 command);
diff --git a/drivers/spi/spi-dw.c b/drivers/spi/spi-dw.c index b217c22ff72f..211cc7d75bf8 100644 --- a/drivers/spi/spi-dw.c +++ b/drivers/spi/spi-dw.c @@ -30,13 +30,11 @@ /* Slave spi_dev related */ struct chip_data { - u8 cs; /* chip select pin */ u8 tmode; /* TR/TO/RO/EEPROM */ u8 type; /* SPI/SSP/MicroWire */ u8 poll_mode; /* 1 means use poll mode */ - u8 enable_dma; u16 clk_div; /* baud rate divider */ u32 speed_hz; /* baud rate */ void (*cs_control)(u32 command);
Local struct chip_data has two members that are not used: - cs. Looks like was never used - enable_dma. Became unused by the commit f89a6d8f43eb ("spi: dw-mid: move to use core SPI DMA mappings"). Signed-off-by: Jarkko Nikula <jarkko.nikula@linux.intel.com> --- drivers/spi/spi-dw.c | 2 -- 1 file changed, 2 deletions(-)