| Message ID | 20180126113244.26946-1-eric.engestrom@imgtec.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Am 26.01.2018 um 12:32 schrieb Eric Engestrom: > Signed-off-by: Eric Engestrom <eric.engestrom@imgtec.com> Reviewed-by: Christian König <christian.koenig@amd.com> > --- > amdgpu/amdgpu_cs.c | 2 +- > tests/exynos/exynos_fimg2d_test.c | 2 +- > tests/modeprint/modeprint.c | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/amdgpu/amdgpu_cs.c b/amdgpu/amdgpu_cs.c > index 987daa4036f2d99ff15f..46dffe1dffc7a68408fa 100644 > --- a/amdgpu/amdgpu_cs.c > +++ b/amdgpu/amdgpu_cs.c > @@ -582,7 +582,7 @@ static int amdgpu_cs_reset_sem(amdgpu_semaphore_handle sem) > if (!sem || !sem->signal_fence.context) > return -EINVAL; > > - sem->signal_fence.context = NULL;; > + sem->signal_fence.context = NULL; > sem->signal_fence.ip_type = 0; > sem->signal_fence.ip_instance = 0; > sem->signal_fence.ring = 0; > diff --git a/tests/exynos/exynos_fimg2d_test.c b/tests/exynos/exynos_fimg2d_test.c > index 03a79c4e9d2579d71ed3..dcb2e35ab3c5a15b3dd7 100644 > --- a/tests/exynos/exynos_fimg2d_test.c > +++ b/tests/exynos/exynos_fimg2d_test.c > @@ -533,7 +533,7 @@ static int g2d_copy_with_scale_test(struct exynos_device *dev, > fail: > g2d_fini(ctx); > > - return ret;; > + return ret; > } > > #ifdef EXYNOS_G2D_USERPTR_TEST > diff --git a/tests/modeprint/modeprint.c b/tests/modeprint/modeprint.c > index 0d854103c5ae65b96004..c81dd91db74d0c301b20 100644 > --- a/tests/modeprint/modeprint.c > +++ b/tests/modeprint/modeprint.c > @@ -244,7 +244,7 @@ static int printFrameBuffer(int fd, drmModeResPtr res, drmModeFBPtr fb) > printf("\thandle : %i\n", fb->handle); > printf("\twidth : %i\n", fb->width); > printf("\theight : %i\n", fb->height); > - printf("\tpitch : %i\n", fb->pitch);; > + printf("\tpitch : %i\n", fb->pitch); > printf("\tbpp : %i\n", fb->bpp); > printf("\tdepth : %i\n", fb->depth); > printf("\tbuffer_id : %i\n", fb->handle);
I think you meant s/empty statements/double semi-colon/.
- please keep the nouveau debug patch out for the time being
- regardless if you keep as-is or fold the Wundef patch with the Werror one
- with the shadowing issue pointed by Chrisian
Both 7 patch series are
Reviewed-by: Emil Velikov <emil.velikov@collabora.com>
-Emil
diff --git a/amdgpu/amdgpu_cs.c b/amdgpu/amdgpu_cs.c index 987daa4036f2d99ff15f..46dffe1dffc7a68408fa 100644 --- a/amdgpu/amdgpu_cs.c +++ b/amdgpu/amdgpu_cs.c @@ -582,7 +582,7 @@ static int amdgpu_cs_reset_sem(amdgpu_semaphore_handle sem) if (!sem || !sem->signal_fence.context) return -EINVAL; - sem->signal_fence.context = NULL;; + sem->signal_fence.context = NULL; sem->signal_fence.ip_type = 0; sem->signal_fence.ip_instance = 0; sem->signal_fence.ring = 0; diff --git a/tests/exynos/exynos_fimg2d_test.c b/tests/exynos/exynos_fimg2d_test.c index 03a79c4e9d2579d71ed3..dcb2e35ab3c5a15b3dd7 100644 --- a/tests/exynos/exynos_fimg2d_test.c +++ b/tests/exynos/exynos_fimg2d_test.c @@ -533,7 +533,7 @@ static int g2d_copy_with_scale_test(struct exynos_device *dev, fail: g2d_fini(ctx); - return ret;; + return ret; } #ifdef EXYNOS_G2D_USERPTR_TEST diff --git a/tests/modeprint/modeprint.c b/tests/modeprint/modeprint.c index 0d854103c5ae65b96004..c81dd91db74d0c301b20 100644 --- a/tests/modeprint/modeprint.c +++ b/tests/modeprint/modeprint.c @@ -244,7 +244,7 @@ static int printFrameBuffer(int fd, drmModeResPtr res, drmModeFBPtr fb) printf("\thandle : %i\n", fb->handle); printf("\twidth : %i\n", fb->width); printf("\theight : %i\n", fb->height); - printf("\tpitch : %i\n", fb->pitch);; + printf("\tpitch : %i\n", fb->pitch); printf("\tbpp : %i\n", fb->bpp); printf("\tdepth : %i\n", fb->depth); printf("\tbuffer_id : %i\n", fb->handle);
Signed-off-by: Eric Engestrom <eric.engestrom@imgtec.com> --- amdgpu/amdgpu_cs.c | 2 +- tests/exynos/exynos_fimg2d_test.c | 2 +- tests/modeprint/modeprint.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-)