| Message ID | 20180122125529.6291-1-andriy.shevchenko@linux.intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Mon, 2018-01-22 at 14:55 +0200, Andy Shevchenko wrote: > Instead of using PROPERTY_ENTRY_INTEGER() with explicitly supplied > type, > use PROPERTY_ENTRY_U32() dedicated macro. > > It will help modify internals of built-in device properties API. > > No functional change intended. > Can someone apply that, or at least Ack? It's needed as a prerequisite to fix one bug in device property core API. > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > --- > arch/arm/mach-pxa/raumfeld.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/arch/arm/mach-pxa/raumfeld.c b/arch/arm/mach- > pxa/raumfeld.c > index 9d662fed03ec..0bf5419a9d10 100644 > --- a/arch/arm/mach-pxa/raumfeld.c > +++ b/arch/arm/mach-pxa/raumfeld.c > @@ -378,9 +378,9 @@ static struct gpiod_lookup_table > raumfeld_rotary_gpios_table = { > }; > > static const struct property_entry raumfeld_rotary_properties[] > __initconst = { > - PROPERTY_ENTRY_INTEGER("rotary-encoder,steps-per-period", > u32, 24), > - PROPERTY_ENTRY_INTEGER("linux,axis", > u32, REL_X), > - PROPERTY_ENTRY_INTEGER("rotary-encoder,relative_axis", > u32, 1), > + PROPERTY_ENTRY_U32("rotary-encoder,steps-per-period", 24), > + PROPERTY_ENTRY_U32("linux,axis", REL_X), > + PROPERTY_ENTRY_U32("rotary-encoder,relative_axis", 1), > { }, > }; >
Andy Shevchenko <andriy.shevchenko@linux.intel.com> writes: > On Mon, 2018-01-22 at 14:55 +0200, Andy Shevchenko wrote: >> Instead of using PROPERTY_ENTRY_INTEGER() with explicitly supplied >> type, >> use PROPERTY_ENTRY_U32() dedicated macro. >> >> It will help modify internals of built-in device properties API. >> >> No functional change intended. >> > > Can someone apply that, or at least Ack? It's needed as a prerequisite > to fix one bug in device property core API. I can certainly ack it : Acked-by: Robert Jarzmik <robert.jarzmik@free.fr> I would have gladly taken it into my pxa/for-next branch, but for a reason your original mail did not land in my mailbox ... computers can be deceiving sometimes. I you send it to me again I'll apply it to my tree. Cheers. -- Robert
On Mon, 2018-01-29 at 18:31 +0100, Robert Jarzmik wrote: > I would have gladly taken it into my pxa/for-next branch, but for a > reason your > original mail did not land in my mailbox ... computers can be > deceiving > sometimes. > > I you send it to me again I'll apply it to my tree. Done!
diff --git a/arch/arm/mach-pxa/raumfeld.c b/arch/arm/mach-pxa/raumfeld.c index 9d662fed03ec..0bf5419a9d10 100644 --- a/arch/arm/mach-pxa/raumfeld.c +++ b/arch/arm/mach-pxa/raumfeld.c @@ -378,9 +378,9 @@ static struct gpiod_lookup_table raumfeld_rotary_gpios_table = { }; static const struct property_entry raumfeld_rotary_properties[] __initconst = { - PROPERTY_ENTRY_INTEGER("rotary-encoder,steps-per-period", u32, 24), - PROPERTY_ENTRY_INTEGER("linux,axis", u32, REL_X), - PROPERTY_ENTRY_INTEGER("rotary-encoder,relative_axis", u32, 1), + PROPERTY_ENTRY_U32("rotary-encoder,steps-per-period", 24), + PROPERTY_ENTRY_U32("linux,axis", REL_X), + PROPERTY_ENTRY_U32("rotary-encoder,relative_axis", 1), { }, };
Instead of using PROPERTY_ENTRY_INTEGER() with explicitly supplied type, use PROPERTY_ENTRY_U32() dedicated macro. It will help modify internals of built-in device properties API. No functional change intended. Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> --- arch/arm/mach-pxa/raumfeld.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)