diff mbox

[libdrm] tests/amdgpu: add missing config.h include

Message ID 20180129145604.12305-1-emil.l.velikov@gmail.com (mailing list archive)
State New, archived
Headers show

Commit Message

Emil Velikov Jan. 29, 2018, 2:56 p.m. UTC
From: Emil Velikov <emil.velikov@collabora.com>

Otherwise we'll end up without the macros set during configure stage.
And effectively error out in sanity tests such as the mmap static
assert.

To reproduce, do a multilib build - 32bit build on 64bit machine.

Cc: Fabio Pedretti <pedretti.fabio@gmail.com>
Cc: Andrey Grodzovsky <Andrey.Grodzovsky@amd.com>
Fixes: 33dcc29f7cc ("amdgpu: Add VMID reservation per GPU context test.")
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=104819
Signed-off-by: Emil Velikov <emil.velikov@collabora.com>
---
 tests/amdgpu/vm_tests.c | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Eric Engestrom Jan. 29, 2018, 3:20 p.m. UTC | #1
On Monday, 2018-01-29 14:56:04 +0000, Emil Velikov wrote:
> From: Emil Velikov <emil.velikov@collabora.com>
> 
> Otherwise we'll end up without the macros set during configure stage.
> And effectively error out in sanity tests such as the mmap static
> assert.
> 
> To reproduce, do a multilib build - 32bit build on 64bit machine.
> 
> Cc: Fabio Pedretti <pedretti.fabio@gmail.com>
> Cc: Andrey Grodzovsky <Andrey.Grodzovsky@amd.com>
> Fixes: 33dcc29f7cc ("amdgpu: Add VMID reservation per GPU context test.")
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=104819
> Signed-off-by: Emil Velikov <emil.velikov@collabora.com>

Reviewed-by: Eric Engestrom <eric.engestrom@imgtec.com>

And my apologies for being a bit too trigger-happy when blaming
autotools :(

> ---
>  tests/amdgpu/vm_tests.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/tests/amdgpu/vm_tests.c b/tests/amdgpu/vm_tests.c
> index 4b0121ff..0379a79d 100644
> --- a/tests/amdgpu/vm_tests.c
> +++ b/tests/amdgpu/vm_tests.c
> @@ -21,6 +21,10 @@
>   *
>  */
>  
> +#ifdef HAVE_CONFIG_H
> +#include "config.h"
> +#endif
> +
>  #include "CUnit/Basic.h"
>  
>  #include "amdgpu_test.h"
> -- 
> 2.16.0
>
diff mbox

Patch

diff --git a/tests/amdgpu/vm_tests.c b/tests/amdgpu/vm_tests.c
index 4b0121ff..0379a79d 100644
--- a/tests/amdgpu/vm_tests.c
+++ b/tests/amdgpu/vm_tests.c
@@ -21,6 +21,10 @@ 
  *
 */
 
+#ifdef HAVE_CONFIG_H
+#include "config.h"
+#endif
+
 #include "CUnit/Basic.h"
 
 #include "amdgpu_test.h"