| Message ID | 20180119174401.23051-1-andriy.shevchenko@linux.intel.com (mailing list archive) |
|---|---|
| State | Rejected, archived |
| Headers | show |
On Fri, 2018-01-19 at 19:44 +0200, Andy Shevchenko wrote: > Since the commit > > 0777591e715a ("clk: fractional-divider: switch to rational best > approximation") > > enables rational best approximation to all common based clocks, there > is > no need to repeat the selection in each of them. > > No functional changes intended. Any comment on this? > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > --- > drivers/clk/Kconfig | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/clk/Kconfig b/drivers/clk/Kconfig > index 98ce9fc6e6c0..2e65cf731b00 100644 > --- a/drivers/clk/Kconfig > +++ b/drivers/clk/Kconfig > @@ -76,7 +76,6 @@ config COMMON_CLK_SI5351 > tristate "Clock driver for SiLabs 5351A/B/C" > depends on I2C > select REGMAP_I2C > - select RATIONAL > ---help--- > This driver supports Silicon Labs 5351A/B/C programmable > clock > generators. > @@ -105,7 +104,6 @@ config COMMON_CLK_CDCE706 > tristate "Clock driver for TI CDCE706 clock synthesizer" > depends on I2C > select REGMAP_I2C > - select RATIONAL > ---help--- > This driver supports TI CDCE706 programmable 3-PLL clock > synthesizer. >
On Mon, 2018-01-29 at 17:46 +0200, Andy Shevchenko wrote: > On Fri, 2018-01-19 at 19:44 +0200, Andy Shevchenko wrote: > > Since the commit > > > > 0777591e715a ("clk: fractional-divider: switch to rational best > > approximation") > > > > enables rational best approximation to all common based clocks, > > there > > is > > no need to repeat the selection in each of them. > > > > No functional changes intended. > > Any comment on this? Do we have any active maintainer for clock related patches? Who is that right now? Can we somehow keep patches commented? > > > > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > > --- > > drivers/clk/Kconfig | 2 -- > > 1 file changed, 2 deletions(-) > > > > diff --git a/drivers/clk/Kconfig b/drivers/clk/Kconfig > > index 98ce9fc6e6c0..2e65cf731b00 100644 > > --- a/drivers/clk/Kconfig > > +++ b/drivers/clk/Kconfig > > @@ -76,7 +76,6 @@ config COMMON_CLK_SI5351 > > tristate "Clock driver for SiLabs 5351A/B/C" > > depends on I2C > > select REGMAP_I2C > > - select RATIONAL > > ---help--- > > This driver supports Silicon Labs 5351A/B/C programmable > > clock > > generators. > > @@ -105,7 +104,6 @@ config COMMON_CLK_CDCE706 > > tristate "Clock driver for TI CDCE706 clock synthesizer" > > depends on I2C > > select REGMAP_I2C > > - select RATIONAL > > ---help--- > > This driver supports TI CDCE706 programmable 3-PLL clock > > synthesizer. > > > >
Quoting Andy Shevchenko (2018-01-19 09:44:01) > Since the commit > > 0777591e715a ("clk: fractional-divider: switch to rational best approximation") > > enables rational best approximation to all common based clocks, there is > no need to repeat the selection in each of them. > > No functional changes intended. > I'd prefer we leave it alone. It would be better to push the basic clk types into Kconfig and then have platforms select the ones they want to use. -- To unsubscribe from this list: send the line "unsubscribe linux-clk" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, 2018-03-16 at 16:32 -0700, Stephen Boyd wrote: > Quoting Andy Shevchenko (2018-01-19 09:44:01) > > Since the commit > > > > 0777591e715a ("clk: fractional-divider: switch to rational best > > approximation") > > > > enables rational best approximation to all common based clocks, > > there is > > no need to repeat the selection in each of them. > > > > No functional changes intended. > > > > I'd prefer we leave it alone. It would be better to push the basic clk > types into Kconfig and then have platforms select the ones they want > to > use. Fair enough.
diff --git a/drivers/clk/Kconfig b/drivers/clk/Kconfig index 98ce9fc6e6c0..2e65cf731b00 100644 --- a/drivers/clk/Kconfig +++ b/drivers/clk/Kconfig @@ -76,7 +76,6 @@ config COMMON_CLK_SI5351 tristate "Clock driver for SiLabs 5351A/B/C" depends on I2C select REGMAP_I2C - select RATIONAL ---help--- This driver supports Silicon Labs 5351A/B/C programmable clock generators. @@ -105,7 +104,6 @@ config COMMON_CLK_CDCE706 tristate "Clock driver for TI CDCE706 clock synthesizer" depends on I2C select REGMAP_I2C - select RATIONAL ---help--- This driver supports TI CDCE706 programmable 3-PLL clock synthesizer.
Since the commit 0777591e715a ("clk: fractional-divider: switch to rational best approximation") enables rational best approximation to all common based clocks, there is no need to repeat the selection in each of them. No functional changes intended. Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> --- drivers/clk/Kconfig | 2 -- 1 file changed, 2 deletions(-)