diff mbox

btrfs: fix err_cast.cocci warnings

Message ID 20180128185010.GA26805@intel17.lkp.intel.com (mailing list archive)
State New, archived
Headers show

Commit Message

Fengguang Wu Jan. 28, 2018, 6:50 p.m. UTC 
From: Fengguang Wu <fengguang.wu@intel.com>

fs/btrfs/volumes.c:742:10-17: WARNING: ERR_CAST can be used with fs_devices


 Use ERR_CAST inlined function instead of ERR_PTR(PTR_ERR(...))

Generated by: scripts/coccinelle/api/err_cast.cocci

Fixes: bf155c98d312 ("btrfs: get device pointer from device_list_add()")
CC: Anand Jain <anand.jain@oracle.com>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---

 volumes.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

David Sterba Jan. 29, 2018, 6:40 p.m. UTC | #1 
On Mon, Jan 29, 2018 at 02:50:10AM +0800, kbuild test robot wrote:
> From: Fengguang Wu <fengguang.wu@intel.com>
> 
> fs/btrfs/volumes.c:742:10-17: WARNING: ERR_CAST can be used with fs_devices
> 
> 
>  Use ERR_CAST inlined function instead of ERR_PTR(PTR_ERR(...))
> 
> Generated by: scripts/coccinelle/api/err_cast.cocci
> 
> Fixes: bf155c98d312 ("btrfs: get device pointer from device_list_add()")
> CC: Anand Jain <anand.jain@oracle.com>
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>

Thanks for the fix, I'll fold it to the patch.
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Anand Jain Jan. 29, 2018, 11:11 p.m. UTC | #2 
On 01/30/2018 02:40 AM, David Sterba wrote:
> On Mon, Jan 29, 2018 at 02:50:10AM +0800, kbuild test robot wrote:
>> From: Fengguang Wu <fengguang.wu@intel.com>
>>
>> fs/btrfs/volumes.c:742:10-17: WARNING: ERR_CAST can be used with fs_devices
>>
>>
>>   Use ERR_CAST inlined function instead of ERR_PTR(PTR_ERR(...))
>>
>> Generated by: scripts/coccinelle/api/err_cast.cocci
>>
>> Fixes: bf155c98d312 ("btrfs: get device pointer from device_list_add()")
>> CC: Anand Jain <anand.jain@oracle.com>
>> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
> 
> Thanks for the fix, I'll fold it to the patch.

  Oh. I just saw this email thread, err my filters. sorry.
  Thanks for the fix.

Anand

> --
> To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

--- a/fs/btrfs/volumes.c
+++ b/fs/btrfs/volumes.c
@@ -739,7 +739,7 @@  static noinline struct btrfs_device *dev
 	if (!fs_devices) {
 		fs_devices = alloc_fs_devices(disk_super->fsid);
 		if (IS_ERR(fs_devices))
-			return ERR_PTR(PTR_ERR(fs_devices));
+			return ERR_CAST(fs_devices);
 
 		list_add(&fs_devices->list, &fs_uuids);