| Message ID | 20180129113323.18961-8-andi.shyti@samsung.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
On Mon, Jan 29, 2018 at 08:33:22PM +0900, Andi Shyti wrote: > Replace the original license statement with the SPDX identifier. > > Signed-off-by: Andi Shyti <andi.shyti@samsung.com> Applied, thank you. > --- > drivers/input/touchscreen/mms114.c | 13 +++++-------- > 1 file changed, 5 insertions(+), 8 deletions(-) > > diff --git a/drivers/input/touchscreen/mms114.c b/drivers/input/touchscreen/mms114.c > index d70c03adf148..3230c92de1ed 100644 > --- a/drivers/input/touchscreen/mms114.c > +++ b/drivers/input/touchscreen/mms114.c > @@ -1,11 +1,8 @@ > -/* > - * Copyright (C) 2012 Samsung Electronics Co.Ltd > - * Author: Joonyoung Shim <jy0922.shim@samsung.com> > - * > - * This program is free software; you can redistribute it and/or modify > - * it under the terms of the GNU General Public License version 2 as > - * published by the Free Software Foundation. > - */ > +// SPDX-License-Identifier: GPL-2.0 > +// Samsung S6SY761 Touchscreen device driver > +// > +// Copyright (c) 2012 Samsung Electronics Co., Ltd. > +// Author: Joonyoung Shim <jy0922.shim@samsung.com> > > #include <linux/module.h> > #include <linux/delay.h> > -- > 2.15.1 >
Hi Dmitry, > > -/* > > - * Copyright (C) 2012 Samsung Electronics Co.Ltd > > - * Author: Joonyoung Shim <jy0922.shim@samsung.com> > > - * > > - * This program is free software; you can redistribute it and/or modify > > - * it under the terms of the GNU General Public License version 2 as > > - * published by the Free Software Foundation. > > - */ > > +// SPDX-License-Identifier: GPL-2.0 > > +// Samsung S6SY761 Touchscreen device driver I'm very sorry, but my distrcation will kill me one day. Is it possible to revert this patch or do you want me to send a fix? Sorry, Andi -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Andy, On Wed, Jan 31, 2018 at 03:07:26PM +0900, Andi Shyti wrote: > Hi Dmitry, > > > > -/* > > > - * Copyright (C) 2012 Samsung Electronics Co.Ltd > > > - * Author: Joonyoung Shim <jy0922.shim@samsung.com> > > > - * > > > - * This program is free software; you can redistribute it and/or modify > > > - * it under the terms of the GNU General Public License version 2 as > > > - * published by the Free Software Foundation. > > > - */ > > > +// SPDX-License-Identifier: GPL-2.0 > > > +// Samsung S6SY761 Touchscreen device driver > > I'm very sorry, but my distrcation will kill me one day. More coffee or sleep - your choice ;-) > > Is it possible to revert this patch or do you want me to send a > fix? When you are on it; Change MODULE_LICENSE("GPL"); to MODULE_LICENSE("GPL v2"); To match the former license text and SPDX-identifier. See include/linux/module.h: * "GPL" [GNU Public License v2 or later] * "GPL v2" [GNU Public License v2] Thanks, > > Sorry, > Andi Best regards Marcus Folkesson
On Wed, Jan 31, 2018 at 08:31:38AM +0100, Marcus Folkesson wrote: > Hi Andy, > > On Wed, Jan 31, 2018 at 03:07:26PM +0900, Andi Shyti wrote: > > Hi Dmitry, > > > > > > -/* > > > > - * Copyright (C) 2012 Samsung Electronics Co.Ltd > > > > - * Author: Joonyoung Shim <jy0922.shim@samsung.com> > > > > - * > > > > - * This program is free software; you can redistribute it and/or modify > > > > - * it under the terms of the GNU General Public License version 2 as > > > > - * published by the Free Software Foundation. > > > > - */ > > > > +// SPDX-License-Identifier: GPL-2.0 > > > > +// Samsung S6SY761 Touchscreen device driver > > > > I'm very sorry, but my distrcation will kill me one day. > > More coffee or sleep - your choice ;-) > > > > > Is it possible to revert this patch or do you want me to send a > > fix? > > When you are on it; > > Change > MODULE_LICENSE("GPL"); > > to > MODULE_LICENSE("GPL v2"); > To match the former license text and SPDX-identifier. > > See include/linux/module.h: > * "GPL" [GNU Public License v2 or later] > * "GPL v2" [GNU Public License v2] OK, I dropped the patch, please resend the correct version. Thanks.
Hi Marcus, > > > > - * Copyright (C) 2012 Samsung Electronics Co.Ltd > > > > - * Author: Joonyoung Shim <jy0922.shim@samsung.com> > > > > - * > > > > - * This program is free software; you can redistribute it and/or modify > > > > - * it under the terms of the GNU General Public License version 2 as > > > > - * published by the Free Software Foundation. > > > > - */ > > > > +// SPDX-License-Identifier: GPL-2.0 > > > > +// Samsung S6SY761 Touchscreen device driver > > > > I'm very sorry, but my distrcation will kill me one day. > > More coffee or sleep - your choice ;-) I see that beer is not working, indeed :) > > Is it possible to revert this patch or do you want me to send a > > fix? > > When you are on it; > > Change > MODULE_LICENSE("GPL"); > > to > MODULE_LICENSE("GPL v2"); > To match the former license text and SPDX-identifier. > > See include/linux/module.h: > * "GPL" [GNU Public License v2 or later] > * "GPL v2" [GNU Public License v2] I haven't noticed that. I will fix it in a separate patch. Thanks, Andi -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Dmitry, > > > > > - * Copyright (C) 2012 Samsung Electronics Co.Ltd > > > > > - * Author: Joonyoung Shim <jy0922.shim@samsung.com> > > > > > - * > > > > > - * This program is free software; you can redistribute it and/or modify > > > > > - * it under the terms of the GNU General Public License version 2 as > > > > > - * published by the Free Software Foundation. > > > > > - */ > > > > > +// SPDX-License-Identifier: GPL-2.0 > > > > > +// Samsung S6SY761 Touchscreen device driver > > > > > > I'm very sorry, but my distrcation will kill me one day. > > > > > > Is it possible to revert this patch or do you want me to send a > > > fix? > > > > OK, I dropped the patch, please resend the correct version. Thanks, will do! Andi -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/input/touchscreen/mms114.c b/drivers/input/touchscreen/mms114.c index d70c03adf148..3230c92de1ed 100644 --- a/drivers/input/touchscreen/mms114.c +++ b/drivers/input/touchscreen/mms114.c @@ -1,11 +1,8 @@ -/* - * Copyright (C) 2012 Samsung Electronics Co.Ltd - * Author: Joonyoung Shim <jy0922.shim@samsung.com> - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License version 2 as - * published by the Free Software Foundation. - */ +// SPDX-License-Identifier: GPL-2.0 +// Samsung S6SY761 Touchscreen device driver +// +// Copyright (c) 2012 Samsung Electronics Co., Ltd. +// Author: Joonyoung Shim <jy0922.shim@samsung.com> #include <linux/module.h> #include <linux/delay.h>
Replace the original license statement with the SPDX identifier. Signed-off-by: Andi Shyti <andi.shyti@samsung.com> --- drivers/input/touchscreen/mms114.c | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-)