diff mbox

IB/rxe: Change RDMA_RXE kconfig to use select

Message ID 20180126211833.GA26670@ziepe.ca (mailing list archive)
State Accepted
Headers show

Commit Message

Jason Gunthorpe Jan. 26, 2018, 9:18 p.m. UTC 
NET_UDP_TUNNEL is not user selectable, so it should be used as a select
in kconfig.

CRYPTO_CRC32 is a required library for RDMA_RXE so it should active
automatically, as most other CRYPTO_ users do.

Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
---
 drivers/infiniband/sw/rxe/Kconfig | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Make configuring work better

Comments

Jason Gunthorpe Jan. 29, 2018, 7:59 p.m. UTC | #1 
On Fri, Jan 26, 2018 at 02:18:33PM -0700, Jason Gunthorpe wrote:
> NET_UDP_TUNNEL is not user selectable, so it should be used as a select
> in kconfig.
> 
> CRYPTO_CRC32 is a required library for RDMA_RXE so it should active
> automatically, as most other CRYPTO_ users do.
> 
> Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
>  drivers/infiniband/sw/rxe/Kconfig | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Applied

Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/infiniband/sw/rxe/Kconfig b/drivers/infiniband/sw/rxe/Kconfig
index 320bffc980d87d..bad4a576d7cf13 100644
--- a/drivers/infiniband/sw/rxe/Kconfig
+++ b/drivers/infiniband/sw/rxe/Kconfig
@@ -1,8 +1,8 @@ 
 config RDMA_RXE
 	tristate "Software RDMA over Ethernet (RoCE) driver"
 	depends on INET && PCI && INFINIBAND
-	depends on NET_UDP_TUNNEL
-	depends on CRYPTO_CRC32
+	select NET_UDP_TUNNEL
+	select CRYPTO_CRC32
 	select DMA_VIRT_OPS
 	---help---
 	This driver implements the InfiniBand RDMA transport over