| Message ID | 20180131155718.5237-3-a.hajda@samsung.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
On Wed, Jan 31, 2018 at 4:57 PM, Andrzej Hajda <a.hajda@samsung.com> wrote: > OF graph describes USB data lanes between USB-PHY and respective MUIC. > Since graph is present and DWC driver can use it to get extcon, obsolete > extcon property can be removed. > > Signed-off-by: Andrzej Hajda <a.hajda@samsung.com> > --- > arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi | 18 +++++++++++++++++- > 1 file changed, 17 insertions(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi b/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi > index 427ff861b441..b20b42659206 100644 > --- a/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi > +++ b/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi > @@ -828,6 +828,17 @@ > }; > }; > }; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@0 { > + reg = <0>; > + muic_to_usb: endpoint { > + remote-endpoint = <&usb_to_muic>; > + }; > + }; > }; > }; > > @@ -1242,12 +1253,17 @@ > > &usbdrd_dwc3 { > dr_mode = "otg"; > - extcon = <&muic>; Look ok for me. Does this depend on #1 patch for DWC? Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 01.02.2018 08:50, Krzysztof Kozlowski wrote: > On Wed, Jan 31, 2018 at 4:57 PM, Andrzej Hajda <a.hajda@samsung.com> wrote: >> OF graph describes USB data lanes between USB-PHY and respective MUIC. >> Since graph is present and DWC driver can use it to get extcon, obsolete >> extcon property can be removed. >> >> Signed-off-by: Andrzej Hajda <a.hajda@samsung.com> >> --- >> arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi | 18 +++++++++++++++++- >> 1 file changed, 17 insertions(+), 1 deletion(-) >> >> diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi b/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi >> index 427ff861b441..b20b42659206 100644 >> --- a/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi >> +++ b/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi >> @@ -828,6 +828,17 @@ >> }; >> }; >> }; >> + >> + ports { >> + #address-cells = <1>; >> + #size-cells = <0>; >> + >> + port@0 { >> + reg = <0>; >> + muic_to_usb: endpoint { >> + remote-endpoint = <&usb_to_muic>; >> + }; >> + }; >> }; >> }; >> >> @@ -1242,12 +1253,17 @@ >> >> &usbdrd_dwc3 { >> dr_mode = "otg"; >> - extcon = <&muic>; > Look ok for me. > > Does this depend on #1 patch for DWC? Yes, it depends. #1 adds code to find extcon using graph, without it dwc3 won't be able to work in dual-role mode. Alternatively, I could split this patch into two parts: 2a. adding graph bindings. 2b. removing extcon property. In such case only 2b depends on #1. Regards Andrzej > > Best regards, > Krzysztof > > > -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, Feb 1, 2018 at 9:19 AM, Andrzej Hajda <a.hajda@samsung.com> wrote: > On 01.02.2018 08:50, Krzysztof Kozlowski wrote: >> On Wed, Jan 31, 2018 at 4:57 PM, Andrzej Hajda <a.hajda@samsung.com> wrote: >>> OF graph describes USB data lanes between USB-PHY and respective MUIC. >>> Since graph is present and DWC driver can use it to get extcon, obsolete >>> extcon property can be removed. >>> >>> Signed-off-by: Andrzej Hajda <a.hajda@samsung.com> >>> --- >>> arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi | 18 +++++++++++++++++- >>> 1 file changed, 17 insertions(+), 1 deletion(-) >>> >>> diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi b/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi >>> index 427ff861b441..b20b42659206 100644 >>> --- a/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi >>> +++ b/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi >>> @@ -828,6 +828,17 @@ >>> }; >>> }; >>> }; >>> + >>> + ports { >>> + #address-cells = <1>; >>> + #size-cells = <0>; >>> + >>> + port@0 { >>> + reg = <0>; >>> + muic_to_usb: endpoint { >>> + remote-endpoint = <&usb_to_muic>; >>> + }; >>> + }; >>> }; >>> }; >>> >>> @@ -1242,12 +1253,17 @@ >>> >>> &usbdrd_dwc3 { >>> dr_mode = "otg"; >>> - extcon = <&muic>; >> Look ok for me. >> >> Does this depend on #1 patch for DWC? > > Yes, it depends. #1 adds code to find extcon using graph, without it > dwc3 won't be able to work in dual-role mode. > Alternatively, I could split this patch into two parts: > 2a. adding graph bindings. > 2b. removing extcon property. > In such case only 2b depends on #1. Without splitting, this patch would have to wait till #1 gets into mainline (so probably till v4.17-rc1 because we are in merge window already). I am fine with this split-approach so only the cleanup patch would get postponed. Up to you. Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi b/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi index 427ff861b441..b20b42659206 100644 --- a/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi +++ b/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi @@ -828,6 +828,17 @@ }; }; }; + + ports { + #address-cells = <1>; + #size-cells = <0>; + + port@0 { + reg = <0>; + muic_to_usb: endpoint { + remote-endpoint = <&usb_to_muic>; + }; + }; }; }; @@ -1242,12 +1253,17 @@ &usbdrd_dwc3 { dr_mode = "otg"; - extcon = <&muic>; }; &usbdrd30_phy { vbus-supply = <&safeout1_reg>; status = "okay"; + + port { + usb_to_muic: endpoint { + remote-endpoint = <&muic_to_usb>; + }; + }; }; &xxti {
OF graph describes USB data lanes between USB-PHY and respective MUIC. Since graph is present and DWC driver can use it to get extcon, obsolete extcon property can be removed. Signed-off-by: Andrzej Hajda <a.hajda@samsung.com> --- arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi | 18 +++++++++++++++++- 1 file changed, 17 insertions(+), 1 deletion(-)