| Message ID | e7dfe444-616a-e156-31d5-8ed626434d1f@users.sourceforge.net (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Mon, 29 Jan 2018 22:04:11 +0100 SF Markus Elfring <elfring@users.sourceforge.net> wrote: > From: Markus Elfring <elfring@users.sourceforge.net> > Date: Mon, 29 Jan 2018 21:55:08 +0100 > > Omit an extra message for a memory allocation failure in this function. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> Whilst the error message doesn't add a lot, it does add some information over a simple memory copy failed error. Hence I think we should keep it. Jonathan > --- > drivers/iio/pressure/hid-sensor-press.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/iio/pressure/hid-sensor-press.c b/drivers/iio/pressure/hid-sensor-press.c > index 4c437918f1d2..9de7590d50b0 100644 > --- a/drivers/iio/pressure/hid-sensor-press.c > +++ b/drivers/iio/pressure/hid-sensor-press.c > @@ -280,10 +280,8 @@ static int hid_press_probe(struct platform_device *pdev) > > indio_dev->channels = kmemdup(press_channels, sizeof(press_channels), > GFP_KERNEL); > - if (!indio_dev->channels) { > - dev_err(&pdev->dev, "failed to duplicate channels\n"); > + if (!indio_dev->channels) > return -ENOMEM; > - } > > ret = press_parse_report(pdev, hsdev, > (struct iio_chan_spec *)indio_dev->channels, -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/iio/pressure/hid-sensor-press.c b/drivers/iio/pressure/hid-sensor-press.c index 4c437918f1d2..9de7590d50b0 100644 --- a/drivers/iio/pressure/hid-sensor-press.c +++ b/drivers/iio/pressure/hid-sensor-press.c @@ -280,10 +280,8 @@ static int hid_press_probe(struct platform_device *pdev) indio_dev->channels = kmemdup(press_channels, sizeof(press_channels), GFP_KERNEL); - if (!indio_dev->channels) { - dev_err(&pdev->dev, "failed to duplicate channels\n"); + if (!indio_dev->channels) return -ENOMEM; - } ret = press_parse_report(pdev, hsdev, (struct iio_chan_spec *)indio_dev->channels,